From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CAD4C61CE7 for ; Fri, 6 Jun 2025 21:37:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A6EC6B007B; Fri, 6 Jun 2025 17:37:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 758006B0088; Fri, 6 Jun 2025 17:37:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66E6C6B0089; Fri, 6 Jun 2025 17:37:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 43D036B007B for ; Fri, 6 Jun 2025 17:37:24 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E2772C0AD6 for ; Fri, 6 Jun 2025 21:37:23 +0000 (UTC) X-FDA: 83526287166.19.4880D3E Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf21.hostedemail.com (Postfix) with ESMTP id 2EFF31C0007 for ; Fri, 6 Jun 2025 21:37:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mqbtouSJ; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749245842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/pieQ7+VVtXUA4iDkDPPxKOhsSM0tgvQpcOvxQc/+qU=; b=3JpOIvHGkxBhNR+gGeE4+WaI3Up/Dla/8wVcHzlkA8w/UbzlWNIdlvrA2A0fVP3pftopTL eNCVwHcXZs2h89JnoARsXZ64IupjNxGMJYnFM6v0ejb1OZFkfZ56JtkeEBIBnZpDTAdKsf b8FGKPq3hrprkUa1v8Vx3zmrc+gqBdo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mqbtouSJ; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749245842; a=rsa-sha256; cv=none; b=Cn/UYaSEychdUYTegnl3SBVTPnU57S52c5+p7jWAiv11snVirtjVir/KYdkieKVhMDDkcl Oc18xm0MtV+GE118f69nNeSx6c/YL1k9Z53UgNrsdMMIpPN6ORfRK/9CxJ8Li1jlMO8w1o j53YyChMzMGi989Hf5JbBBdiiIwXsfs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749245838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/pieQ7+VVtXUA4iDkDPPxKOhsSM0tgvQpcOvxQc/+qU=; b=mqbtouSJFd/0JXZm7T9p4BVUeZ18o1l/MWnTVXVwkgM96NgMKUVTmpN2Pq1vObIKHyGCJV uHYa6+CCsSP6+e+v0Gr9PlxyF3LnwKy4ksIcpy+CsOLRsQE4aYdAkQN730OuN+yNi3UlwU HtDn2xkEZNnkT1VlAhfhJNA/DmU/mKM= From: Roman Gushchin To: Matthew Wilcox Cc: linux-mm@kvack.org Subject: Re: Fixing memcg_slabinfo.py In-Reply-To: (Matthew Wilcox's message of "Fri, 6 Jun 2025 18:33:07 +0100") References: Date: Fri, 06 Jun 2025 14:37:14 -0700 Message-ID: <87o6v0lfg5.fsf@linux.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2EFF31C0007 X-Stat-Signature: 5jocaumxo3eb7tsdh1yfzhi7fhitezni X-Rspam-User: X-HE-Tag: 1749245841-844653 X-HE-Meta: U2FsdGVkX1+IemC3KYVZS+QAivNjujTZzyHGPdXLA7B0dLakWcu+tfNK3+EfwNb4RUStWnOR4sh4e75pdiiW/Nyt3ZKYLiGm9oGTUYtoARpQNYQWsU960pqVbKWDsKOw4AUUVhPwsqwKZrWP10rL4SbsvFr9B/e+F3L/9rgUu/5cTWKKe+9ERqebtyuAv95uokeiEDhz4y/mskaejn3kZUq3FCZUh6x5AqbQ6Q563cVOiBtA+K6BxMfmE/i1Z5LgZB8iHmwVHzBZY0mCk3TZ0TJKwW3FVaoY20fKi1RLlJRf+XFELWl001Q01NxKtuUFyIgH/N7+dBcvDY9WISkOHCzT/9LMY94mBqYYhRwrgTEVaR0qb44EPisEuVkHk5xz+viIUktmmidqKvuQEVWWi0s67+wLYj4V3H0qxipi5dX5X8JAsDlXJ558PQTGb3Z18eYyOCcbp78AUkEJsZ+lxgdavsSZUfHck/K/me6p7XHbnzyeGz5SYobcnmNlBQxLjXxmjhGS37DoVpw0sV12AUE7lahwlhw3SaN9k31EjS1PJtop0y82l2eGBIitsBjgLOxcwod2vimF5T8zXY1LnZkd3EwdXGsWNvyaPaNNkVODp+5UDv9NDYXfUvOnqd/zCKGtvbP0pPwB/NTMqGJF1BxOPPaM9rkSm4dRaopiWemPrWnchB8EHidQEJ5U8JWHCC3ACgkbbjcHGelUD4GnTZ/qw8kKoN78Z/yLwt7ouoZTE7Zo4A9vKCM1HcIU1XBCRdV0LSxLwmAYNNtHuMM5SqKPkLbyXqYOl3q7r1oTi23Jq6q3Xfpf8KEkw25dJSZW3ATqEXwfnpxtXuhQsy7oQI20Gxeix/76Ne/xqfdGZ9H2CUfzmwYTY6rJhM9NOKzBYkD6TRi5Y7xdpXzhkTbUEttl5MqY6qXWN5jiWDMnDbhNfakzfVL7AeVcorf6AAXtm4RN6J6fZGAImHNghX5 KmlloTVk rPY+H0m0vUQiDJFH4hkx8TjsMVachnpYKV8pXEWmfxn10l5N9nPluA44PS5IVVch0NAJ17Ya4uhN2UilC7ANhhTyEkZmbJdUwz4DJMdHBiKtj2enhFZuGoeVgKwfI7ET7CBVfssv1X0h4soB309bseRK7U6tTCTOpyXr1+XhADHvHrqwbL2GGqYDWOYD1FmTDeApDDNNkIRSw4QyFs4HYsF2oZwPEbebgD3Wz77c19EAL/aLqijItq+9qkbuh0nbTCB0KjfSLNFPetLmpnTAdl72Ygg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.013631, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox writes: > Looks like nobody's used memcg_slabinfo.py in the last year when I broke > it with 4ffca5a96678. It should probably be fixed, but I'm not fluent > in Python and don't use drgn myself, so have no way to verify the below > is even syntactically correct, let alone works. Hi Matthew! The patch looks good to me (assuming a proper commit log). I gave it a test on top of 6.14.9 (which is running my Fedora laptop currently) and it worked fine. Tested-by: Roman Gushchin Reviewed-by: Roman Gushchin Thanks! > > diff --git a/tools/cgroup/memcg_slabinfo.py b/tools/cgroup/memcg_slabinfo.py > index 270c28a0d098..bb3de16e3510 100644 > --- a/tools/cgroup/memcg_slabinfo.py > +++ b/tools/cgroup/memcg_slabinfo.py > @@ -146,11 +146,11 @@ def detect_kernel_config(): > > > def for_each_slab(prog): > - PGSlab = ~prog.constant('PG_slab') > + PGTYslab = prog.constant('PGTY_slab') > > for page in for_each_page(prog): > try: > - if page.page_type.value_() == PGSlab: > + if (page.page_type.value_() >> 24) == PGTYslab: > yield cast('struct slab *', page) > except FaultError: > pass