From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B8FEC77B7F for ; Tue, 24 Jun 2025 14:43:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2A066B009F; Tue, 24 Jun 2025 10:43:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB3066B00B6; Tue, 24 Jun 2025 10:43:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2CEF6B00B7; Tue, 24 Jun 2025 10:43:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8DC336B009F for ; Tue, 24 Jun 2025 10:43:47 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 39FF0121AED for ; Tue, 24 Jun 2025 14:43:47 +0000 (UTC) X-FDA: 83590563294.06.400944D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id D03411C0008 for ; Tue, 24 Jun 2025 14:43:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TsszAST5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750776224; a=rsa-sha256; cv=none; b=ZYqCdsoZ9Shxv+E/RPV7B2k29//dMsjO2xhJXTIXGSPex6IbMuaQLYlZJkSUv5iMZiEUkc ApRIZZzkX+5IFx1n/aR1hVaQMBREPgipZGXKMIBgeJbLxbHqo+DlWrwY5IvHpGb/T7K0Cv qIa4nIH5ROFkk+FCN6gx5A19TWSbGS0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TsszAST5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750776224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A1mUkubgs0SksCT6tY6SOJAtTf1PWq3gjPrEkfXNqHE=; b=zOyqecc2IGwvHHEHbDP2KZDyu0ozuwfiKIEV7iqCAjrMQLvlCpBLJa371IZFBE4MAjCD3g 1XpWfZLWb9PkNNDJWgvX1o/cp+LljK39nfAddfDvl1T3fwN5yJH5Oyj5jftOIXT5Jp9Ozy f1AfBXlZc9nUyOkG4RPwFruyXQvPAho= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750776224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A1mUkubgs0SksCT6tY6SOJAtTf1PWq3gjPrEkfXNqHE=; b=TsszAST5JKdsls2o0j4Xy04UP9PxtL3FhY4D9TAbedGY/BoP/NDlN9iDZpjuDvK9GRZIO2 wBLeJpe1dHdyDYNsps6a8cBcxS7MniANogDpW8g6myOwcX/hhx4wFRD44UBObdTQqF+apK 4ZIiOLUWYSE25jB4CkIlOUK/h3HLmgQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-ZthBC3SSOs2bZvQu7TXcRQ-1; Tue, 24 Jun 2025 10:43:40 -0400 X-MC-Unique: ZthBC3SSOs2bZvQu7TXcRQ-1 X-Mimecast-MFC-AGG-ID: ZthBC3SSOs2bZvQu7TXcRQ_1750776219 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-553bb73e055so2660594e87.1 for ; Tue, 24 Jun 2025 07:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750776219; x=1751381019; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AsJFD8Xb7TNUkeNMyUpPYkjT7yFBNxg0JTSP55Zxpfs=; b=X+xmtUeyb2cyOjZ9Ju8dX/ae7qTljMylm4Q1fAQAZY3INQN3JK70WmME2j9jEkncF8 NqxHkpxa6r8RfEBfyu8NTSVvgo5Qi1ach0n6ps4G9px5diUbyhd3MnmWiZJ6oiPQ0kIG 96XGAm8QeJiSXk1PISlyPyejs5k6IwS8hNWi9CQ+0VA2FMhDZMzrWBRRKx7kdJoLqOyR 4blXJSzeKRy3EiInbx28X6+xyg8DPWoYQXh4JTo8ykrXHWMe88kbXH4PPhrch9cRFats LH7djWGRp1enM0yoi/H0Yp+mdKULnTk34mXKknuUlgPc72nUmQOGU9vTvPD6U+iEZbyl 2Oyg== X-Forwarded-Encrypted: i=1; AJvYcCV3XFMDVsibAuKNAn0ZQoPz27t+GEDcbIBaL52ga2vWOASecs0KTWfVXZFnFyRDf0NkAsc9O4OCzA==@kvack.org X-Gm-Message-State: AOJu0YxVU+fVaTUYVlC02ecbi3aCyN5pA4cHqPGGY90lyd1RnXld59nL SLWw63jVN6SNXIeRmyy8vjnH7aQfIhj6RS6N7QZkF4HSWjbs3lT5jB15uGKN8oGVLKaMJ8N69BU 7nYsn3VjOTFWzBDDpPgK7QRpYTq9uI5PGncEcVHZV1eqdaz2lWuYe X-Gm-Gg: ASbGncuGe7ouuFaMyOHzsvu5mKAYahtIIu5ZlnTDEzeYEew8puIgurhJMUrv+8fF/0m 7n2gq1OFB4eia0Ai3t0bbr1beH6C16H9lyT/3BhRLpQqpxSPF/U9XQX7WIYSSS7rq8JGmls0I/3 3ct7JxSb11XORNy0r7WSjIodr8MjyoLit/EB3vLTDshiJnTLWYLkcgWUa5cf2cf4+qImM1q+GPQ 967Be/0fSc7J7NI7vIW5Xz80cJ7bnwgctOrr8sID+N4wzG6nilq4ICo3Kz1iXUNs5COwFZ0zLkJ PES/bnJnriDioL3ZUoDNek9rRy+pmgrjcplmTe1QrYofzxw= X-Received: by 2002:ac2:51d5:0:b0:553:349c:646c with SMTP id 2adb3069b0e04-553e3bf2109mr4783127e87.27.1750776218743; Tue, 24 Jun 2025 07:43:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0aXMGFpRJQr9IDGvwiXOXGJUpblWAgU5bfHFxKSwW7q7amMW/E+3VuHA5u82kZnQnHCkEPw== X-Received: by 2002:ac2:51d5:0:b0:553:349c:646c with SMTP id 2adb3069b0e04-553e3bf2109mr4783111e87.27.1750776218257; Tue, 24 Jun 2025 07:43:38 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553e41cdf64sm1839877e87.234.2025.06.24.07.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 07:43:37 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 178B01B37786; Tue, 24 Jun 2025 16:43:36 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Zi Yan , David Hildenbrand Cc: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, jackmanb@google.com, "jesper@cloudflare.com" Subject: Re: [PATCH net-next v6 9/9] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() In-Reply-To: <42E9BEA8-9B02-440F-94BF-74393827B01E@nvidia.com> References: <20250620041224.46646-1-byungchul@sk.com> <20250620041224.46646-10-byungchul@sk.com> <20250623101622.GB3199@system.software.com> <460ACE40-9E99-42B8-90F0-2B18D2D8C72C@nvidia.com> <42E9BEA8-9B02-440F-94BF-74393827B01E@nvidia.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 24 Jun 2025 16:43:36 +0200 Message-ID: <87o6udfbdz.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2BlXTi0pgv6Hr2jD-xPUPriRGc6ZX1cTh7msXOL9UHw_1750776219 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: D03411C0008 X-Rspamd-Server: rspam10 X-Stat-Signature: 9z7kyeo55rddgq4is1xco9gnuwuxt6p5 X-HE-Tag: 1750776224-883279 X-HE-Meta: U2FsdGVkX1+Uzz8J4L5rcNNz56fTqZXXaQkyAg8PdHO+64qaYX4IjZ7z/+tm3SFlUP9xJaGp9etu9uV1eVg3kqJ+qHiPBwQoU0yfDWqVyD0jjPHCI1TTct8Pj2y8bJyxrfL9+30StmGeyvPTJGne45mZk50kQbRmmKEvXcP5YLWLAMFJ3sfUmc4eXmqOwjALL6MzE928iPrd6GS4/HI3xfO7AaCTBrdoOV/CyyLvxDsQEHYCcaixZVrA3ScJudFoJS5kouZFQ36OYZMGtqDS/ydczr0wkOllQBqXJ/WpOx+2xCPMv7pl8yazWgT+4EfOu4aLRdLMWV3PJqVRiOrnjeXAPjYfmX1lea8PdnUJRJYGQmc7uPlQp6rWAK12PdK5TitMpnXqmxf0CNQ3SWl5aGvTGKaNjeQWO6u8EkRsuysKbhbBeY/d4vbsLXAie70Me75G5N9ZF+cFJdRtu0XmrsAHYjB7Oz0TSDlYAYNHsyPk/fWQl3TC/jSL4XL3DlQ1veoVmcVaiF3TRsdEVIyiD//0bVMrPT48UbrkkkTZBQ2/nDqKF8WeTs88uZIWs6cO0RMUNIupiyIov//sZCnu+jtBvM+QKUm+VY8qxIOgZMEH/u/CULqCbrrlPd8YPEbvjU5eq9hInGLfz6JfHAvWldzEveRw+ZANi8+p9gUROQb4mouP2ZJvklVzNfj8XPRhaG4eyeJaMLOIKwWFasHutMcJwx+6iWH6rntguTUfHmlQNWdU+RNTDDmgVb2JI3hdgg45Kde70dYGv8wqPbdXAw6NzhlOpQUdb/S6cuoMsQmfaTyD4fsMf7d7BE0Ab+o2tnGIz7tKOAgc/GqJn0BWCVKaDwZlKFLbeH/iq9hZdNVp7tniWth2MlN8FZI+w636pNx45rKpO8iDhjvq1QWjuSomCi+Q/UdArVBWsSuTKbQ2EbmjdrIbIvLOWECa3KWBQFT9MKpQ46COf4TfVuW CGFuOLTx POY4O6+kqQ5pSv4i0RbYaQm7nA+ivUm4pH2nf+tlfcXN6JbIbeLMgRZjUz6RIj1Hb9h5Cr0VD0j25QlDgRTlmBNy8+VLqWjJ+a973m3rz5es5FRsL51jcYGjwGxr6P7v3KgVbK7WylIBfP9wmB9nY7gLI4AxvInWZEyBhKTjRLrgcCUx60hk3Uhh8Sspu8ekvQkfKkbbf7IvPjmu8cpDVxA/rr+7z8ovgZQMDZw+JY9izHiiZKAdweZ1GCvMthIMGhTLnx+7cwbPcN+/6rGUBqIuV+v1njpXJ1+ScgYegsTtJ89gs6d05AfyYZhQEmv+EAhsXSIdxIkv10coNoUF6XohIMCsEJIjU3ubIk3Yc/edlSLRBVbYW5aWsPr+vAe5HOqKMNTqPtw/Ko+aeLDq3gN1QsakzfC1/4iBGev5L2n+u4jxMidFv8soVbZOD7HbudWTIRHCrHILlEzqhCWpBWTj5mEpArO97dUsUzW6GWwUnFKI5XlqRdkLw+Pj31SnLds03yniJlLVoiZJ1CvNfFXw6wTqhnHCzyt3jpo+iFPC4TjViPe9Gi2Nwp/RJJjP7D5Ak2iyVM60klIF0zB4586KwvAZDcyF2aZm/J7UPC4gZRZW23rsay8zQCyY2eLX6+U3WUo+6ddy8lMaOrt2oq0q5oltEkiNWHDR/xla1FDrt7/BxwBTCCDKDm59wgtBCkBrVeHodLdqnNWeuV/YAG7Ix3Jq7DEx5N8gqt10Yr2Ukm2kzpZa7jnUdwLGHWE7Md6dnTDYPKQDfhUFgIBcE/a5fBsq8jBEIaZecxymjjWBnhxWTrhAfsnCf6D3WnOg7SVEH1hY1Od7BC7chvWXkD5oMB6zOil2vvEEhbUTZ24CSowglMEdxPqdW0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: > On 23 Jun 2025, at 10:58, David Hildenbrand wrote: > >> On 23.06.25 13:13, Zi Yan wrote: >>> On 23 Jun 2025, at 6:16, Byungchul Park wrote: >>> >>>> On Mon, Jun 23, 2025 at 11:16:43AM +0200, David Hildenbrand wrote: >>>>> On 20.06.25 06:12, Byungchul Park wrote: >>>>>> To simplify struct page, the effort to separate its own descriptor f= rom >>>>>> struct page is required and the work for page pool is on going. >>>>>> >>>>>> To achieve that, all the code should avoid directly accessing page p= ool >>>>>> members of struct page. >>>>>> >>>>>> Access ->pp_magic through struct netmem_desc instead of directly >>>>>> accessing it through struct page in page_pool_page_is_pp(). Plus, m= ove >>>>>> page_pool_page_is_pp() from mm.h to netmem.h to use struct netmem_de= sc >>>>>> without header dependency issue. >>>>>> >>>>>> Signed-off-by: Byungchul Park >>>>>> Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen >>>>>> Reviewed-by: Mina Almasry >>>>>> Reviewed-by: Pavel Begunkov >>>>>> Reviewed-by: Vlastimil Babka >>>>>> Acked-by: Harry Yoo >>>>>> --- >>>>>> include/linux/mm.h | 12 ------------ >>>>>> include/net/netmem.h | 14 ++++++++++++++ >>>>>> mm/page_alloc.c | 1 + >>>>>> 3 files changed, 15 insertions(+), 12 deletions(-) >>>>>> >>>>>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>>>>> index 0ef2ba0c667a..0b7f7f998085 100644 >>>>>> --- a/include/linux/mm.h >>>>>> +++ b/include/linux/mm.h >>>>>> @@ -4172,16 +4172,4 @@ int arch_lock_shadow_stack_status(struct task= _struct *t, unsigned long status); >>>>>> */ >>>>>> #define PP_MAGIC_MASK ~(PP_DMA_INDEX_MASK | 0x3UL) >>>>>> >>>>>> -#ifdef CONFIG_PAGE_POOL >>>>>> -static inline bool page_pool_page_is_pp(struct page *page) >>>>>> -{ >>>>>> - return (page->pp_magic & PP_MAGIC_MASK) =3D=3D PP_SIGNATURE; >>>>>> -} >>>>>> -#else >>>>>> -static inline bool page_pool_page_is_pp(struct page *page) >>>>>> -{ >>>>>> - return false; >>>>>> -} >>>>>> -#endif >>>>>> - >>>>>> #endif /* _LINUX_MM_H */ >>>>>> diff --git a/include/net/netmem.h b/include/net/netmem.h >>>>>> index d49ed49d250b..3d1b1dfc9ba5 100644 >>>>>> --- a/include/net/netmem.h >>>>>> +++ b/include/net/netmem.h >>>>>> @@ -56,6 +56,20 @@ NETMEM_DESC_ASSERT_OFFSET(pp_ref_count, pp_ref_co= unt); >>>>>> */ >>>>>> static_assert(sizeof(struct netmem_desc) <=3D offsetof(struct pag= e, _refcount)); >>>>>> >>>>>> +#ifdef CONFIG_PAGE_POOL >>>>>> +static inline bool page_pool_page_is_pp(struct page *page) >>>>>> +{ >>>>>> + struct netmem_desc *desc =3D (struct netmem_desc *)page; >>>>>> + >>>>>> + return (desc->pp_magic & PP_MAGIC_MASK) =3D=3D PP_SIGNATURE; >>>>>> +} >>>>>> +#else >>>>>> +static inline bool page_pool_page_is_pp(struct page *page) >>>>>> +{ >>>>>> + return false; >>>>>> +} >>>>>> +#endif >>>>> >>>>> I wonder how helpful this cleanup is long-term. >>>>> >>>>> page_pool_page_is_pp() is only called from mm/page_alloc.c, right? >>>> >>>> Yes. >>>> >>>>> There, we want to make sure that no pagepool page is ever returned to >>>>> the buddy. >>>>> >>>>> How reasonable is this sanity check to have long-term? Wouldn't we be >>>>> able to check that on some higher-level freeing path? >>>>> >>>>> The reason I am commenting is that once we decouple "struct page" fro= m >>>>> "struct netmem_desc", we'd have to lookup here the corresponding "str= uct >>>>> netmem_desc". >>>>> >>>>> ... but at that point here (when we free the actual pages), the "stru= ct >>>>> netmem_desc" would likely already have been freed separately (remembe= r: >>>>> it will be dynamically allocated). >>>>> >>>>> With that in mind: >>>>> >>>>> 1) Is there a higher level "struct netmem_desc" freeing path where we >>>>> could check that instead, so we don't have to cast from pages to >>>>> netmem_desc at all. >>>> >>>> I also thought it's too paranoiac. However, I thought it's other issu= e >>>> than this work. That's why I left the API as is for now, it can be go= ne >>>> once we get convinced the check is unnecessary in deep buddy. Wrong? >>>> >>>>> 2) How valuable are these sanity checks deep in the buddy? >>>> >>>> That was also what I felt weird on. >>> >>> It seems very useful when I asked last time[1]: >>> >>> |> We have actually used this at Cloudflare to catch some page_pool bug= s. >> >> My question is rather, whether there is some higher-level freeing path f= or netmem_desc where we could check that instead (IOW, earlier). >> >> Or is it really arbitrary put_page() (IOW, we assume that many possible = references can be held)? > > +Toke, who I talked about this last time. > > Maybe he can shed some light on it. As others have pointed out, basically, AFAIU: Yes, pages are *supposed* to go through a common freeing path where this check could reside, but we've had bugs where they ended up leaking anyway, which is why this check in MM was added in the first place. I don't recall the specifics of *what* the bug was; +Jesper who maybe does? -Toke