From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6CD5C433F5 for ; Tue, 21 Sep 2021 07:07:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50113610CA for ; Tue, 21 Sep 2021 07:07:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50113610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CBAD86B0071; Tue, 21 Sep 2021 03:07:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6B5F6B0072; Tue, 21 Sep 2021 03:07:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5A386B0073; Tue, 21 Sep 2021 03:07:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id A41746B0071 for ; Tue, 21 Sep 2021 03:07:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 545A72BA8F for ; Tue, 21 Sep 2021 07:07:35 +0000 (UTC) X-FDA: 78610700070.06.C761F57 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf14.hostedemail.com (Postfix) with ESMTP id 8B05B600198B for ; Tue, 21 Sep 2021 07:07:34 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="221410111" X-IronPort-AV: E=Sophos;i="5.85,310,1624345200"; d="scan'208";a="221410111" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 00:07:26 -0700 X-IronPort-AV: E=Sophos;i="5.85,310,1624345200"; d="scan'208";a="556822401" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 00:07:23 -0700 From: "Huang, Ying" To: Weizhao Ouyang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual , Michal Hocko , John Hubbard , Pavel Tatashin , Yang Shi , Zi Yan , Dave Hansen , Minchan Kim , Mina Almasry , "Matthew Wilcox (Oracle)" , Oscar Salvador , Wei Xu Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to migrate_reason_names References: <20210921064553.293905-1-o451686892@gmail.com> <20210921064553.293905-3-o451686892@gmail.com> Date: Tue, 21 Sep 2021 15:07:21 +0800 In-Reply-To: <20210921064553.293905-3-o451686892@gmail.com> (Weizhao Ouyang's message of "Tue, 21 Sep 2021 14:45:53 +0800") Message-ID: <87mto676fq.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8B05B600198B X-Stat-Signature: k4ku5uds33z8bz8mukbzsezh8abdmmid Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf14.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=ying.huang@intel.com X-HE-Tag: 1632208054-554332 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Weizhao Ouyang writes: > Sync up MR_DEMOTION to migrate_reason_names and add a synch prompt. > > Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim") > Signed-off-by: Weizhao Ouyang > Reviewed-by: "Huang, Ying" > --- > include/linux/migrate.h | 6 +++++- > mm/debug.c | 1 + > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index 326250996b4e..c8077e936691 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -19,6 +19,11 @@ struct migration_target_control; > */ > #define MIGRATEPAGE_SUCCESS 0 > > +/* > + * Keep sync with: > + * - macro MIGRATE_REASON in include/trace/events/migrate.h > + * - migrate_reason_names[MR_TYPES] in mm/debug.c > + */ > enum migrate_reason { > MR_COMPACTION, > MR_MEMORY_FAILURE, > @@ -32,7 +37,6 @@ enum migrate_reason { > MR_TYPES > }; > > -/* In mm/debug.c; also keep sync with include/trace/events/migrate.h */ > extern const char *migrate_reason_names[MR_TYPES]; > > #ifdef CONFIG_MIGRATION > diff --git a/mm/debug.c b/mm/debug.c > index e61037cded98..fae0f81ad831 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -26,6 +26,7 @@ const char *migrate_reason_names[MR_TYPES] = { > "numa_misplaced", > "contig_range", > "longterm_pin", > + "demotion", > }; > > const struct trace_print_flags pageflag_names[] = { Can we add BUILD_BUG_ON() somewhere to capture at least some synchronization issue? Best Regards, Huang, Ying