From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Kees Cook <keescook@chromium.org>
Cc: Niklas Cassel <Niklas.Cassel@wdc.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Greg Ungerer <gerg@linux-m68k.org>,
Mike Frysinger <vapier@gentoo.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
kernel test robot <lkp@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: [PATCH] binfmt_flat; Drop vestigates of coredump support
Date: Tue, 19 Apr 2022 09:16:41 -0500 [thread overview]
Message-ID: <87mtgh17li.fsf_-_@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <202204181501.D55C8D2A@keescook> (Kees Cook's message of "Mon, 18 Apr 2022 15:01:35 -0700")
There is the briefest start of coredump support in binfmt_flat. It is
actually a pain to maintain as binfmt_flat is not built on most
architectures so it is easy to overlook.
Since the support does not do anything remove it.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
Apologies for hijacking this thread but it looks like we have people who
are actively using binfmt_flat on it.
Does anyone have any objections to simply removing what little there
is of coredump support from binfmt_flat?
Eric
fs/binfmt_flat.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
index 626898150011..0ad2c7bbaddd 100644
--- a/fs/binfmt_flat.c
+++ b/fs/binfmt_flat.c
@@ -37,7 +37,6 @@
#include <linux/flat.h>
#include <linux/uaccess.h>
#include <linux/vmalloc.h>
-#include <linux/coredump.h>
#include <asm/byteorder.h>
#include <asm/unaligned.h>
@@ -98,33 +97,12 @@ static int load_flat_shared_library(int id, struct lib_info *p);
#endif
static int load_flat_binary(struct linux_binprm *);
-#ifdef CONFIG_COREDUMP
-static int flat_core_dump(struct coredump_params *cprm);
-#endif
static struct linux_binfmt flat_format = {
.module = THIS_MODULE,
.load_binary = load_flat_binary,
-#ifdef CONFIG_COREDUMP
- .core_dump = flat_core_dump,
- .min_coredump = PAGE_SIZE
-#endif
};
-/****************************************************************************/
-/*
- * Routine writes a core dump image in the current directory.
- * Currently only a stub-function.
- */
-
-#ifdef CONFIG_COREDUMP
-static int flat_core_dump(struct coredump_params *cprm)
-{
- pr_warn("Process %s:%d received signr %d and should have core dumped\n",
- current->comm, current->pid, cprm->siginfo->si_signo);
- return 1;
-}
-#endif
/****************************************************************************/
/*
--
2.35.3
next prev parent reply other threads:[~2022-04-19 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 20:09 [PATCH] binfmt_flat: fix sparse annotation ordering Niklas Cassel
2022-04-18 22:01 ` Kees Cook
2022-04-19 14:16 ` Eric W. Biederman [this message]
2022-04-19 16:35 ` [PATCH] binfmt_flat; Drop vestigates of coredump support Niklas Cassel
2022-04-19 17:46 ` (subset) " Kees Cook
2022-04-20 13:48 ` Eric W. Biederman
2022-04-19 23:08 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtgh17li.fsf_-_@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=Niklas.Cassel@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=gerg@linux-m68k.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=stable@vger.kernel.org \
--cc=vapier@gentoo.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox