From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3552EC433FE for ; Tue, 1 Nov 2022 05:06:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79AB36B0072; Tue, 1 Nov 2022 01:06:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74A8F6B0073; Tue, 1 Nov 2022 01:06:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613136B0074; Tue, 1 Nov 2022 01:06:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4EB7B6B0072 for ; Tue, 1 Nov 2022 01:06:36 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E3154A2430 for ; Tue, 1 Nov 2022 05:06:35 +0000 (UTC) X-FDA: 80083687950.02.542D1AD Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf16.hostedemail.com (Postfix) with ESMTP id BD844180004 for ; Tue, 1 Nov 2022 05:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667279194; x=1698815194; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=IvSOtGrzZN2pV+uWfoyYt5wv9j9DhXJ+Scyj4+toEww=; b=jZfRjOIdyF2Rdp+G+bTvO1Po80VO81N1wuhYTpxbMmdBFyxODzGAmUAu Z0rib9c+n/1SWVQSAwik3V6lOtdB/UMO0p+1MpzMvMshrptCiNpsy9dS5 37t/U9pNpPiN262Ft36NYCyR+goZTho1k3NPErBrpd4p6Yod+uO21XyNc LxXA6VpneWnTjE8zQtOqqGUC5a0ZxySAOU/wRVmGr22bRZGbVCKv5OPvT vq6lfl7T4OmWYJfXJMyXetisoL1Elhj6zPR8mm0eG/0Kha54CrpMPq+XO ZdJxDMQjedWZKCEd/q93uEyxyGlgwwrgrdi2+S93ACI/OSG4xDdtqMC/8 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="371147601" X-IronPort-AV: E=Sophos;i="5.95,229,1661842800"; d="scan'208";a="371147601" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2022 22:06:33 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="628474616" X-IronPort-AV: E=Sophos;i="5.95,229,1661842800"; d="scan'208";a="628474616" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2022 22:06:31 -0700 From: "Huang, Ying" To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Miaohe Lin , David Hildenbrand , HORIGUCHI NAOYA , Andrea Arcangeli Subject: Re: [PATCH 0/2] mm: Use pte marker for swapin errors References: <20221030214151.402274-1-peterx@redhat.com> <87h6zkepog.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Tue, 01 Nov 2022 13:05:51 +0800 In-Reply-To: (Peter Xu's message of "Mon, 31 Oct 2022 10:14:39 -0400") Message-ID: <87mt9bclhs.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667279195; a=rsa-sha256; cv=none; b=joEhZM9ty7GY10qlljQOV7dDmeFtRAicS2LJcPQtvxZWfdZba1YCpjtLRLsLDhlIKwRj8F 0GxMkaUqc28xWy2J2AC8PJXQMZ7NYupDLkmQDn9yABYyfD+xyRextWhw+B1/PC4aei3lfC h1c5fyqJBM7G98ZiESLoL2OKARdGKOI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=jZfRjOId; spf=pass (imf16.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667279195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A+huhM/wZest6eeeyla6q7472OUwj/FmoP1BR2Z57v0=; b=ypQ/TsjhiH1LBIKWTLecycIhxWlvRJajUS4kxXGM79N8RBzsbnPoeYk8Eodz8Ai7adB4w6 CA9vADgmuPp18JlDVWxEcsJAojHyrRtMA2Z8OqwgDUPhR851bI40ioryB8PzDtTqlwlIxb ULrU6cVhgkl6XfhyYEST67M/XdawzFw= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BD844180004 X-Rspam-User: X-Stat-Signature: 8fjnha7dgp9pg4yqzxtt3fj9aa4phfxp Authentication-Results: imf16.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=jZfRjOId; spf=pass (imf16.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1667279194-616545 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Peter Xu writes: > On Mon, Oct 31, 2022 at 09:40:15AM +0800, Huang, Ying wrote: >> Peter Xu writes: >> >> > rfc->v1: >> > - Rename SWAP_ERROR -> SWAPIN_ERROR [David, Miaohe] >> > - Added r-bs for Ying and Miaohe >> > >> > Hi, >> > >> > This series uses the pte marker to replace the swapin error swap entry, >> > then we save one more swap entry slot for swap devices. A new pte marker >> > bit is defined. >> >> Per my understanding, "swap entry" describes one swap page (4KB on x86) >> in one swap device. So, the original swapin error implementation uses >> one swap file (or swap device) instead of one swap entry. So your patch >> saves one swap file (or swap device). > > Yeah I was definitely not accurate enough, I wanted to use "slot" to mean > "type" here but obviously I didn't make it, sorry. Hopefully the whole > patchset is still clear enough anyway so no reader will get confused by it. The terminology used in swap code is a little complex. The swap slot is used to describe swap entry (swap page) too in swap slots cache (swap_slots.c/h). Best Regards, Huang, Ying