From: "Huang, Ying" <ying.huang@intel.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
David Hildenbrand <david@redhat.com>,
HORIGUCHI NAOYA <naoya.horiguchi@nec.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH 0/2] mm: Use pte marker for swapin errors
Date: Tue, 01 Nov 2022 13:05:51 +0800 [thread overview]
Message-ID: <87mt9bclhs.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <Y1/YT9/PcF6kx/gq@x1n> (Peter Xu's message of "Mon, 31 Oct 2022 10:14:39 -0400")
Peter Xu <peterx@redhat.com> writes:
> On Mon, Oct 31, 2022 at 09:40:15AM +0800, Huang, Ying wrote:
>> Peter Xu <peterx@redhat.com> writes:
>>
>> > rfc->v1:
>> > - Rename SWAP_ERROR -> SWAPIN_ERROR [David, Miaohe]
>> > - Added r-bs for Ying and Miaohe
>> >
>> > Hi,
>> >
>> > This series uses the pte marker to replace the swapin error swap entry,
>> > then we save one more swap entry slot for swap devices. A new pte marker
>> > bit is defined.
>>
>> Per my understanding, "swap entry" describes one swap page (4KB on x86)
>> in one swap device. So, the original swapin error implementation uses
>> one swap file (or swap device) instead of one swap entry. So your patch
>> saves one swap file (or swap device).
>
> Yeah I was definitely not accurate enough, I wanted to use "slot" to mean
> "type" here but obviously I didn't make it, sorry. Hopefully the whole
> patchset is still clear enough anyway so no reader will get confused by it.
The terminology used in swap code is a little complex. The swap slot is
used to describe swap entry (swap page) too in swap slots cache
(swap_slots.c/h).
Best Regards,
Huang, Ying
prev parent reply other threads:[~2022-11-01 5:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 21:41 Peter Xu
2022-10-30 21:41 ` [PATCH 1/2] mm: Always compile in pte markers Peter Xu
2022-11-02 9:15 ` David Hildenbrand
2022-10-30 21:41 ` [PATCH 2/2] mm: Use pte markers for swap errors Peter Xu
2022-11-02 9:16 ` David Hildenbrand
2022-10-31 1:40 ` [PATCH 0/2] mm: Use pte marker for swapin errors Huang, Ying
2022-10-31 14:14 ` Peter Xu
2022-11-01 5:05 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt9bclhs.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox