From: Jonathan Corbet <corbet@lwn.net>
To: Nhat Pham <nphamcs@gmail.com>
Cc: hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
kernel-team@meta.com, akpm@linux-foundation.org
Subject: Re: [PATCH] Docs/admin-guide/mm/zswap: remove zsmalloc's lack of writeback warning
Date: Wed, 11 Jan 2023 16:13:02 -0700 [thread overview]
Message-ID: <87mt6ovf5t.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230106220016.172303-1-nphamcs@gmail.com>
Nhat Pham <nphamcs@gmail.com> writes:
> Writeback has been implemented for zsmalloc, so this warning no longer
> holds.
>
> Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
> Documentation/admin-guide/mm/zswap.rst | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/zswap.rst b/Documentation/admin-guide/mm/zswap.rst
> index f67de481c7f6..6dd74a18268b 100644
> --- a/Documentation/admin-guide/mm/zswap.rst
> +++ b/Documentation/admin-guide/mm/zswap.rst
> @@ -70,9 +70,7 @@ e.g. ``zswap.zpool=zbud``. It can also be changed at runtime using the sysfs
> The zbud type zpool allocates exactly 1 page to store 2 compressed pages, which
> means the compression ratio will always be 2:1 or worse (because of half-full
> zbud pages). The zsmalloc type zpool has a more complex compressed page
> -storage method, and it can achieve greater storage densities. However,
> -zsmalloc does not implement compressed page eviction, so once zswap fills it
> -cannot evict the oldest page, it can only reject new pages.
> +storage method, and it can achieve greater storage densities.
>
Applied, thanks.
jon
prev parent reply other threads:[~2023-01-11 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 22:00 Nhat Pham
2023-01-06 22:03 ` Nhat Pham
2023-01-11 23:13 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt6ovf5t.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox