From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE5EC6FD1B for ; Mon, 6 Mar 2023 23:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 384DE280005; Mon, 6 Mar 2023 18:12:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 334AE280001; Mon, 6 Mar 2023 18:12:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2234F280005; Mon, 6 Mar 2023 18:12:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 10D1A280001 for ; Mon, 6 Mar 2023 18:12:04 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CF4451A053F for ; Mon, 6 Mar 2023 23:12:03 +0000 (UTC) X-FDA: 80540023326.22.6F1249B Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf04.hostedemail.com (Postfix) with ESMTP id 69CB240011 for ; Mon, 6 Mar 2023 23:12:01 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b="G+Sab/KI"; spf=pass (imf04.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678144322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y3ZQe1v9yNGZGVZM7F5FvSpbccPl60HdWh6Jlu25Uj4=; b=hBIfOCIQ61HSOAPreG1HHlSwiLLj2A3eraSUk8izOI4enHnHw9Ofszpdt3DeEEl/tOyIYv mhNjaPH0vUu8+0up8MhqO59KnSovJ5wofREZ4VErST2lTh/nGTLOaI11hhVArNItp4Z8Wr HPxvpsbrWu+YRQOsxai//zEG+yWtsQ4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b="G+Sab/KI"; spf=pass (imf04.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678144322; a=rsa-sha256; cv=none; b=bQ+BoL7prs8YQ+CYOLslKpqo4SBf0lArUCmxtofgVLF+xeonxhzsUKS2hF/1e7cMAe+fo2 CgCBNXjsLNaw8K64Tom4PV2ln8GQxpiXvWBgX21DOHbcgVQD04nCH4ZJEv8KbQsyVqwJOH FhfQp8BRi2ZGPCjp4WsLlN/n3FUTfGU= Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PVvV227K5z4wgq; Tue, 7 Mar 2023 10:11:54 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1678144317; bh=Y3ZQe1v9yNGZGVZM7F5FvSpbccPl60HdWh6Jlu25Uj4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=G+Sab/KI7GAdy0Diebk6cQ/coHwcVMTqNmdTfQxYLnOVvsIndv9rl72OPozMBlYMe Va4LySAlFrcJ4TuVE14hxLaQ9JYQIiR9AN3z5EmgKmEhqBM84PEO4ZbGo1ccID9Ebm olatYOdWLf41Dqaq+qy1i05gpFdoTdeJAOtcfeC306+ClAa8E4O8DK+nUSlu+njFEP 3auPTqQhaABfq8gsiySo+KUowhvu4Lg+vCfJuZixOxHqq5aDNDftd1HYeHD4cJAMK3 cCAJXBNKuC0w0B7clhHf+fYnXLGSBv3I9wXVnnec+nGJu+XSzbMXBLpNjTD7lQWVdh VlwMZSuOylJmw== From: Michael Ellerman To: Gerald Schaefer , Andrew Morton Cc: David Hildenbrand , Matthew Wilcox , Catalin Marinas , Anshuman Khandual , Will Deacon , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Alexander Gordeev , linux-mips , linux-power , linux-x86 , linux-s390 , LKML , linux-mm Subject: Re: [PATCH] mm: add PTE pointer parameter to flush_tlb_fix_spurious_fault() In-Reply-To: <20230306161548.661740-1-gerald.schaefer@linux.ibm.com> References: <20230306161548.661740-1-gerald.schaefer@linux.ibm.com> Date: Tue, 07 Mar 2023 10:11:53 +1100 Message-ID: <87mt4p1nly.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: zypfigwkpn9bbm37d5cwf7pch3xz9nsb X-Rspam-User: X-Rspamd-Queue-Id: 69CB240011 X-Rspamd-Server: rspam06 X-HE-Tag: 1678144321-343397 X-HE-Meta: U2FsdGVkX19HRXQH09mJEk1EXFWoedPTAcsrzjhNDjSb0CrKjrv8/YJrnUuGn3W9NblaDb0H8mrwNijC9jh171mdFt8wq8BQwQ8FTVtV74vOJ17bqTEN6SVr1A736ml+I/wB8Nk3fvQPvKbriZ/mOhcDmM1ebhhgysNFs9F1bA4z7aXaU2w6DZ/AwFactujRMz2lHUzZA8jBJhVfcIZ7jUATWWMcNXk+Rtd9Vw4j+a52K6MkIPptz8VCvtIT/4LBVOTHedfMicYpnps+FKpMmjJN92XUOfOVBTEf9OL1dkmkIaoxwcigXu0VN/oIe/FZaX0lZA8EgQEE6uEtOe5P37VjjUBCWMNLRN3J6K+J/e/BuiWrMlw8YTnbcTv40aw+Ao7KWtOdR4iLWXjsfN7JivwkKuVTIhuWAWBGmkdGdqP2YPiWIaIc67qvFtAnGcob+WYzCCujR2E1JPJKh0ak2SQYvjflFxiSkrTs7PSZYWrJAoFhi5AUaoKBSa5on5J+HymK6fcO73dhV+Y/TMNEsv1/A1Oschlnz5kf7FYIPoSUZd6f+f5bJAq73LDnHx6ZhaiJSJV0dRFKbk/ILs2mh3FY2jk2OIxmodtBrD2RSwdziyyZt/Ftp8uYoL4TtZrnPB8NVWISR/fM/YsL9h8CWr5YdLHZRFkuCiZqRSOv2PHKhNpWjC09aWRHCrlQjuSTq6HMRb1fdU07SDmFZWAS9Hr5X2lMGflimAXdwAXsmCRz2F+FLh09vLnEyHLrziLaQLVLMC6FIHb6fDXdsKCnAKGGYJtG26ZDh+4rUBGJjQRDTRIyPS7P1ilWy78iqnsRIOxjrgqxACPivWs9RUplmzg6XxKRMNcmwlS5WQyb1sV9EYR+lLjQ1conRF/ADyovylZ0wK+gIPUQqJBegBpKuLizuuIH24oBoKU9N7qO/oB9wh5zop6sYN1hd9/JidXgrx1Y3N4ZPN/aK/cqKaL OFd537j1 UswY0aMdOh/e2PMySi+dfS5YVNsEnOTbFv7IsZPhKZCArxqxW4LvqgdVngpRnoflijvNpQC24rM4doPx2OsbhSmAzrpKcyGYg+29JIiCrFToAiSZEQ+8fV5cjRhfqpXSBmscoIsCeCg9DrsGPqsL1xa7MzhseSwSwzU9oBDW5U0EKjedsE5vDYNjp+sRdeWGuDXlj+ZOaEH1MisC3vAsq9sqFwZa/2/fjoRfnFnj5Z0fvg2s0QlIex781nKjXMoe1AyfP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Gerald Schaefer writes: > s390 can do more fine-grained handling of spurious TLB protection faults, > when there also is the PTE pointer available. > > Therefore, pass on the PTE pointer to flush_tlb_fix_spurious_fault() as > an additional parameter. > > This will add no functional change to other architectures, but those with > private flush_tlb_fix_spurious_fault() implementations need to be made > aware of the new parameter. > > Reviewed-by: Alexander Gordeev > Signed-off-by: Gerald Schaefer > --- > arch/arm64/include/asm/pgtable.h | 2 +- > arch/mips/include/asm/pgtable.h | 3 ++- > arch/powerpc/include/asm/book3s/64/tlbflush.h | 3 ++- > arch/s390/include/asm/pgtable.h | 12 +++++++----- > arch/x86/include/asm/pgtable.h | 2 +- > include/linux/pgtable.h | 2 +- > mm/memory.c | 3 ++- > mm/pgtable-generic.c | 2 +- > 8 files changed, 17 insertions(+), 12 deletions(-) ... > diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush.h b/arch/powerpc/include/asm/book3s/64/tlbflush.h > index 2bbc0fcce04a..ff7f0ee179e5 100644 > --- a/arch/powerpc/include/asm/book3s/64/tlbflush.h > +++ b/arch/powerpc/include/asm/book3s/64/tlbflush.h > @@ -121,7 +121,8 @@ static inline void flush_tlb_page(struct vm_area_struct *vma, > > #define flush_tlb_fix_spurious_fault flush_tlb_fix_spurious_fault > static inline void flush_tlb_fix_spurious_fault(struct vm_area_struct *vma, > - unsigned long address) > + unsigned long address, > + pte_t *ptep) > { > /* > * Book3S 64 does not require spurious fault flushes because the PTE Acked-by: Michael Ellerman (powerpc) cheers