From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED69C77B75 for ; Fri, 21 Apr 2023 09:05:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60E866B0072; Fri, 21 Apr 2023 05:05:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BE226B0074; Fri, 21 Apr 2023 05:05:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 485966B0075; Fri, 21 Apr 2023 05:05:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3A0566B0072 for ; Fri, 21 Apr 2023 05:05:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F1C40406A2 for ; Fri, 21 Apr 2023 09:05:41 +0000 (UTC) X-FDA: 80704815282.16.C3DAB8E Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf14.hostedemail.com (Postfix) with ESMTP id 75090100015 for ; Fri, 21 Apr 2023 09:05:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gm2bccWT; spf=pass (imf14.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682067940; a=rsa-sha256; cv=none; b=P+CUUPl8d+NE6QxBqNNc//YuQiCws20qJnFF4rx4yCVICCfo3A+D7nZK1oSJ7ZkKoMr8AQ JA/xvjufvnwaxW8uclE8zUZyncSn3bmdC0h5jLFqIzNDCo7w+TlLCqIZfL/VgxW4Ck68AA VA2HXvFEkCKWyYNXK3OhFvVIimjDz9M= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gm2bccWT; spf=pass (imf14.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682067940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cJyBbYPucpr8mldWuaWQgYBlAJ3kGwijIxvndeNkdNo=; b=ThuYwD/mVju93+GIVPW+TDSTzcYQX/plLyUYbhdDBBygMdHnLcL/0BX414BRonxEnrZFfv bN1j4HZDvhiovpVP6aoNZXyIaWl0uCQWFMhl3DxzcSIfz5AlWWm9GWkQSPFOeT7RqFbWyZ 5s6LRMW2hMUnsaTxSvuteiFNFjjHuE0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682067939; x=1713603939; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=ZJoYa/AXWIJW8/H4efRh+74qEMHSA59/EWCE4cBJ92I=; b=gm2bccWTpA6wvDNhp5D1ZSKEqGjbIYdsoiyAcHix65exE88JKqh8vu4D EdA5H3xvLvBMBu6fMS4HZ+ToKkUL24kSdzEwIdGA/mszcoWL+3RFoc35c PVpO8U1WtXWPaZ40plQ9dhSWyTq+cfUcJBTCNOxvpKnV2o0NIgsgA0YvL HhYGm84uA4zpt2UhldpFKGBSHjkwenag3sQFHmYABgxgok8Tvww3fecUX E+YH5xChBnrgFDUOwbzO+tCZsKU8v22IXkCUSk1AIp1ZxXwh9Ds3t7pV6 /51MvPecdtk6BO/8XUypPXb0w3PIVd+451mMJZCtR8heXXw6bf/Jj+kOH A==; X-IronPort-AV: E=McAfee;i="6600,9927,10686"; a="334826282" X-IronPort-AV: E=Sophos;i="5.99,214,1677571200"; d="scan'208";a="334826282" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2023 02:05:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10686"; a="816355993" X-IronPort-AV: E=Sophos;i="5.99,214,1677571200"; d="scan'208";a="816355993" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2023 02:05:36 -0700 From: "Huang, Ying" To: Zhaoyang Huang Cc: "zhaoyang.huang" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCHv2] mm: skip CMA pages when they are not available References: <1681979577-11360-1-git-send-email-zhaoyang.huang@unisoc.com> <87v8hpspge.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Fri, 21 Apr 2023 17:02:12 +0800 In-Reply-To: (Zhaoyang Huang's message of "Fri, 21 Apr 2023 17:00:04 +0800") Message-ID: <87mt31sj57.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 75090100015 X-Rspamd-Server: rspam01 X-Stat-Signature: sgjh6b19hmkynb7o45diq6fw19rmb65y X-HE-Tag: 1682067939-889091 X-HE-Meta: U2FsdGVkX1/YcmXJ29ZIYs83FYPO7hatnyEVHzgPwaxenT5W80AIH3icO0j8EUJnC25fMmDZIn6aZyrVODwKjAzJmRaIMNyQi6LCIOH7Mt4Cv7obmCKZYCqrV0EihNY53atVsnRRv24uSRSV+Dln7txRLnZjW1ygq17nKJ8v+9lKVFuo6Bl2TTPY2M83a9KZa0Hcd/LvDLzhXzm99XzURffynxz6FuelhxUIHy+1WRrKWMTcKjmlqwtIhkSMrlYF8Lve08VZ9XUBnFHMwrDt8crj3dzo1YIL/qrZnbWnxGQt0LIDfnxphiM0QsaFmLTq2xsLi5NvrL87jIPaM069XTJq6ncM/W0Y5cREeyCUY4mnaqrYxRK1SGODn1QlRFgwxEe1DpniVUMpkMLoaDpDqKR3fjI26AGDchg3qHVFRKLDSGPKDlKw8eYm+hhzuZfH0eXjgUQjHjWKataA0U/cejChe5oJQcueMWawIRQvKCW6Hh/rUc1RMklGsEseCNlHvrgCWFG7QP0YZTGrZujh+j2OY3sORrvRnLF3DHlQ90tPtswbRY6FJjOPtbrHvxkaDrihTF8+FsRyEHdR2EJMZOFSE3se1hH7dI/S36e1I6O+uDSzrLCeFn/7I1EH3AqLKQupf/zmfqR3eDUBLw5WWjJcWxsGzIWcaVQe9mR19hjDRJKtZ3Vx6XI+1xDCDiMxk+7bbnj2vWeEd0uWmeJT5cq5wcIBewjKIIxtueEm18Xp/32SVmPknZ0o5Wg61jAlyJq6j2wPRYtFRpbXHi9GGwAev5dfweKS7aM2CIkJf5b+UrRrPtyhssCuNi0AB0mkhCrocgIWqE0vbGS+beTf5+oY1mCRCJ+XjtVY/X+39CEjhwVVZ53nnRCv7gfhz7pCWtUf8Zo7WYVvsdP8OoQiiGgzYwsBBKpmEtYXDkP4sxz2L21aPWj+IKwUfL1UzB7hmBqcXVdA2hk1zLRyXbf 8LR13Ti2 KcVUOkOw7ZbGjZZKmeQpMR/KRSbs/DU9lJD1XKvR6p9L/7xdRB2/zdG63cH5rwfNa8YKCR0X1uMXizbxhXScuZAshR+Y9Gutjr+MrqgNoCvHYnJWnJmmEr/vJR1Ojd6hYW3wI9isjUQvaNJR3tko8frsBdKr608+qDlZLseO8Rwjr3mOgfdPM4OXdyyi05G/gYTDDVFYWN4vWh5/233EfDQvFlAgNPdszaaJNSMkeTMwbXMR9ezSVk3jFNv9i30Pxb0z6tEw75jLk7Z9C7A3icbKIQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Zhaoyang Huang writes: > On Fri, Apr 21, 2023 at 2:47=E2=80=AFPM Huang, Ying wrote: >> >> "zhaoyang.huang" writes: >> >> > From: Zhaoyang Huang >> > >> > This patch fixes unproductive reclaiming of CMA pages by skipping them= when they >> > are not available for current context. It is arise from bellowing OOM = issue, which >> > caused by large proportion of MIGRATE_CMA pages among free pages. Ther= e has been >> > commit(168676649) to fix it by trying CMA pages first instead of fallb= ack in >> > rmqueue. I would like to propose another one from reclaiming perspecti= ve. >> > >> > 04166 < 4> [ 36.172486] [03-19 10:05:52.172] ActivityManager: page a= llocation failure: order:0, mode:0xc00(GFP_NOIO), nodemask=3D(null),cpuset= =3Dforeground,mems_allowed=3D0 >> > 0419C < 4> [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C= ) 217*16kB (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB = (C) 0*1024kB 0*2048kB 0*4096kB =3D 35848kB >> > 0419D < 4> [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) = 49*8kB (MEH) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB= (H) 0*1024kB 0*2048kB 0*4096kB =3D 3236kB >> > ...... >> > 041EA < 4> [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocat= e memory on node -1, gfp=3D0xa20(GFP_ATOMIC) >> > 041EB < 4> [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, obj= ect size: 64, buffer size: 64, default order: 0, min order: 0 >> > 041EC < 4> [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs:= 3392, free: 0 >> >> From the above description, you are trying to resolve an issue that has >> been resolved already. If so, why do we need your patch? What is the >> issue it try to resolve in current upstream kernel? > > Please consider this bellowing sequence as __perform_reclaim() return > with reclaiming 32 CMA pages successfully and then lead to > get_page_from_freelist failure if MIGRATE_CMA is NOT over 1/2 number > of free pages which will then unreserve H pageblocks and drain percpu > pageset. right? Furthermore, this could also introduce OOM as > direct_reclaim is the final guard for alloc_pages. > > *did_some_progress =3D __perform_reclaim(gfp_mask, order, ac); > > retry: > page =3D get_page_from_freelist(gfp_mask, order, alloc_flags, ac); > > if (!page && !drained) { > unreserve_highatomic_pageblock(ac, false); > drain_all_pages(NULL); > drained =3D true; > goto retry; > } If you think OOM can be triggered, please try to reproduce it. Best Regards, Huang, Ying > return page; >> >> At the first glance, I don't think your patch doesn't make sense. But >> you really need to show the value of the patch. >> >> Best Regards, >> Huang, Ying >> >> > Signed-off-by: Zhaoyang Huang >> > --- >> > v2: update commit message and fix build error when CONFIG_CMA is not s= et >> > --- >> > --- >> > mm/vmscan.c | 15 +++++++++++++-- >> > 1 file changed, 13 insertions(+), 2 deletions(-) >> > >> > diff --git a/mm/vmscan.c b/mm/vmscan.c >> > index bd6637f..19fb445 100644 >> > --- a/mm/vmscan.c >> > +++ b/mm/vmscan.c >> > @@ -2225,10 +2225,16 @@ static unsigned long isolate_lru_folios(unsign= ed long nr_to_scan, >> > unsigned long nr_skipped[MAX_NR_ZONES] =3D { 0, }; >> > unsigned long skipped =3D 0; >> > unsigned long scan, total_scan, nr_pages; >> > + bool cma_cap =3D true; >> > + struct page *page; >> > LIST_HEAD(folios_skipped); >> > >> > total_scan =3D 0; >> > scan =3D 0; >> > + if ((IS_ENABLED(CONFIG_CMA)) && !current_is_kswapd() >> > + && (gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABLE)) >> > + cma_cap =3D false; >> > + >> > while (scan < nr_to_scan && !list_empty(src)) { >> > struct list_head *move_to =3D src; >> > struct folio *folio; >> > @@ -2239,12 +2245,17 @@ static unsigned long isolate_lru_folios(unsign= ed long nr_to_scan, >> > nr_pages =3D folio_nr_pages(folio); >> > total_scan +=3D nr_pages; >> > >> > - if (folio_zonenum(folio) > sc->reclaim_idx) { >> > + page =3D &folio->page; >> > + >> > + if ((folio_zonenum(folio) > sc->reclaim_idx) >> > +#ifdef CONFIG_CMA >> > + || (get_pageblock_migratetype(page) =3D=3D MIGRA= TE_CMA && !cma_cap) >> > +#endif >> > + ) { >> > nr_skipped[folio_zonenum(folio)] +=3D nr_pages; >> > move_to =3D &folios_skipped; >> > goto move; >> > } >> > - >> > /* >> > * Do not count skipped folios because that makes the fu= nction >> > * return with no isolated folios if the LRU mostly cont= ains