From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CF3EB64DD for ; Wed, 9 Aug 2023 08:38:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76D1D6B0074; Wed, 9 Aug 2023 04:38:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71E586B0075; Wed, 9 Aug 2023 04:38:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C8408E0001; Wed, 9 Aug 2023 04:38:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4641D6B0074 for ; Wed, 9 Aug 2023 04:38:03 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 12D5A80E1D for ; Wed, 9 Aug 2023 08:38:03 +0000 (UTC) X-FDA: 81103913646.27.60B93DE Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by imf12.hostedemail.com (Postfix) with ESMTP id D6E8D4001A for ; Wed, 9 Aug 2023 08:37:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691570281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGM/Znnnwz3/kBMK8Bh+uNOfA4AVYlN0i8ULGEsF93M=; b=7XgCUCobCgxf2FJgKpZFdrdYF7tFmPDOrkIohgYuaTYxZtlFI6VJYlwwg33RWxE+H1p5Mp 4nmAWeplIBdOHx4FydCA7zelzF/LTtaYvHUxuv2MOpKztoZFzfZGiJu4Km6irOUXzAOm47 3F7YwlzyjWJ+94+0BoHpdjapAmdmnaY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691570281; a=rsa-sha256; cv=none; b=fBBG4nvSHNSiuwvH/t3LRV7nd4y0/qg3gBoCSyCLPKeP0NOzoBiErSyrpHIpoBu/wrMRjJ 5Kq4b1ZEdpTNrXUsmELYu6DwCnb0iSCyp50o1lDryVjh745gPWdnDt/aYu/eI3soqKqTak WfWAa+57iEw0+1Yr7NTxZwgI7xsqbw8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp; dmarc=none Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 5F6A22055F9C; Wed, 9 Aug 2023 17:37:57 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 3798btR4208465 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 17:37:56 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 3798btTt140448 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 17:37:55 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 3798biDW140435; Wed, 9 Aug 2023 17:37:44 +0900 From: OGAWA Hirofumi To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp In-Reply-To: <20230807-mgctime-v7-5-d1dec143a704@kernel.org> (Jeff Layton's message of "Mon, 07 Aug 2023 15:38:36 -0400") References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> Date: Wed, 09 Aug 2023 17:37:44 +0900 Message-ID: <87msz08vc7.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: D6E8D4001A X-Rspam-User: X-Stat-Signature: 38dx3h3k8na5sxxj44f113bm7hk6b3ba X-Rspamd-Server: rspam03 X-HE-Tag: 1691570279-990727 X-HE-Meta: U2FsdGVkX1/Y7RTUdDvXMtmrMCdtEksl8yPIPJcz4wAPZnHJERraLuJTIo/zwMKOAld7HBkq/DcU785xUA5bbGjWXMtsPFsL873lD73YvkUo5Ysh78JfNe2JN8+uzVeDGOy4QaigqHUMM1h/LrbdYNXJqIHIYSF+uWlgnAVuYqVmDpdNiKTgiguzqRMcQg/ZJetIA/0fTuD6YyDiU0TXHGl+6SluWlzPMVL5tZwNwqzPxV4cvr8sdpZRFrMkeBnNvnA6GpyUDjZtIncmEUuh3maPAyXOTMOrJcb9bTljFn5AN4sHerGM6LLp0V4vOiOL+HZHrK6u3R8bv2HQziyzkGVd7N2Aw2eHOuO8AvXIqS8WVth8geheGLuOjNHuf5GXCvTl/16j6dHfUY2S20s7iLaU0zT+xdUfBp51yK10slQqjsQps6+r+B2bjuk24GU2qVuyHCfjhxKGfUCJ/qb3DoOOrXG0bfRqPRWUJp8FY7QNyHFHfbJKaQYuNWfQHhP0OVEX1KvCTXaPgj2ND92HI4Sc+JuNXiphgfGiIovOEibeTLvhUZK3voPit+fV/fduC6WPgblz8xtJF9pNBnZUNL8mBHFdXTYB/G8kHLFpjk2WDoWyddCjQHn/4R0CSqxbe1oE/ZO2fQIkFyY5rW/NUsIb04hJmtBB+TVpLbW+gVQijOYgHjxmOk+gtwpyQBxoZfv44GkIef6NCerqYh3IAzRpCEQhgrDsMguGW6P13WlO/TXxjOJdbuS1PsrKjJtHvrwjkx6po8cXN4h/VRVBvqDX8jQdG76cPxN29dHz3CS52AYTeUOhpUd8ujTaxv/QfgoATvMTDCD58/qCxOIB2Y+Lw8JWMVqzY7VS83+lBwSmMs/Z1p6B0MlwfNsX8eaIgy240Z5757sJgeY1l5+hG38NzPRWLDqJ/L0+ITubzpOy69LlTWsmoY+YLg/eCyjLmu18Kp6p1k02bASs9cc bpghF44U PudWQ62PxlLv7yC9rZxHe/4g6f8sVaKU1/ZG/D08QGl4siGL9xvo88Tz+6hW309x1YTcJ5v6G+Mgd1ir/skePQaE1ZY9ro8iy7wqVQ7+yXoMoIKcUbX1fZo1FT7kid7I9Yd7CIvZsx3Vv4sU8P7FHMKiON/Mq3DLEdZ2qVH+YwVjootN6c+zfF6dcc/Qsoj+7j1EOBxh+LeMSgbFBsdURtnRr/NikW4ckRWqdcRUYMrVVkEb2/pg/k+l+b88kWv4gyNasADyYqCvuqMd/wWEksg608shqHRwXCTYsVL8sfJw+32c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jeff Layton writes: > Also, it may be that things have changed by the time we get to calling > fat_update_time after checking inode_needs_update_time. Ensure that we > attempt the i_version bump if any of the S_* flags besides S_ATIME are > set. I'm not sure what it meaning though, this is from generic_update_time(). Are you going to change generic_update_time() too? If so, it doesn't break lazytime feature? Thanks. > Signed-off-by: Jeff Layton > --- > fs/fat/misc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > index 67006ea08db6..8cab87145d63 100644 > --- a/fs/fat/misc.c > +++ b/fs/fat/misc.c > @@ -347,14 +347,14 @@ int fat_update_time(struct inode *inode, struct timespec64 *now, int flags) > return 0; > > if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > - fat_truncate_time(inode, now, flags); > + fat_truncate_time(inode, NULL, flags); > if (inode->i_sb->s_flags & SB_LAZYTIME) > dirty_flags |= I_DIRTY_TIME; > else > dirty_flags |= I_DIRTY_SYNC; > } > > - if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > + if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && inode_maybe_inc_iversion(inode, false)) > dirty_flags |= I_DIRTY_SYNC; > > __mark_inode_dirty(inode, dirty_flags); -- OGAWA Hirofumi