From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C27C83F12 for ; Tue, 29 Aug 2023 11:48:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 520458E0024; Tue, 29 Aug 2023 07:48:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF1B8E001A; Tue, 29 Aug 2023 07:48:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BE418E0024; Tue, 29 Aug 2023 07:48:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 29C9E8E001A for ; Tue, 29 Aug 2023 07:48:32 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E177DA05A0 for ; Tue, 29 Aug 2023 11:48:31 +0000 (UTC) X-FDA: 81176969622.08.D1EA583 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf26.hostedemail.com (Postfix) with ESMTP id 695FE140010 for ; Tue, 29 Aug 2023 11:48:29 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=ld+GC+EV; spf=pass (imf26.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693309710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V7fp4M9m50UUinbeFQ1LBWrcpG397hshYrmRg4hs78o=; b=soqIcbdsjk+p4H+XvumI3dWFFggt+EELQqWg3zWQU+zk6bRRZj3/BBt2I23JRMK9W+dyi9 0xfPvVxcftXdz6HPG+7mRkkyq6nUhFT+ImXl/RT0LY0rOSJ5rpQoE3MwhiCWjIi9wL2N7O KYlGK5RiLcoEWX523G23edq4rbHkKwg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693309710; a=rsa-sha256; cv=none; b=7BGTISXxFWOhFQfSkIP/PTxScwfZLOmPHr0cb65sy7J0uyicsmtzHX61PrgEAl4O2Sp2gP 0rA7KqF8AgpExNysTrPL9SVGpD4WM8CnEqRuamOl0BXUBwFahZqcfgJsNk143BXpI6/2Y/ FMsc2LGKoc8txO/DEwx1E7H8X3dYRhg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=ld+GC+EV; spf=pass (imf26.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1693309705; bh=V7fp4M9m50UUinbeFQ1LBWrcpG397hshYrmRg4hs78o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ld+GC+EV4Zu+j0MWCz9YSYef3C+5Ig5srlyGRbxzJY1VRX0A7tAuee/Im30uP23XS hLzLy9MNLElY+77KNRrDZEApxw+r5WXfZwXLZcU0I3Cv7AR0bs4GwHj6m0RgIcl5i7 pGHiKFSI7QYWqvakfvamyqq4K+T1GGciAx9EE2HYz3bN9YsyVmAEscsInMPGLvjZA+ uqZZ4mPASaPlNfTNNtBEbdCyjg8orG0ECVaNS/VCcauiGQifpBvDFD0sWz3/o2UAIS DMYxgWIOUFvZZgoFj9GTgdvF228twAda/t9F60m7bebZnCe9RECs8yLjJKc0GGaGI9 sAAMichvM70mw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RZm090DPRz4wxQ; Tue, 29 Aug 2023 21:48:25 +1000 (AEST) From: Michael Ellerman To: Herbert Xu , kernel test robot , Linux Crypto Mailing List , linuxppc-dev@lists.ozlabs.org Cc: Danny Tsen , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: crypto: powerpc/chacha20,poly1305-p10 - Add dependency on VSX In-Reply-To: References: <202308251906.SYawej6g-lkp@intel.com> Date: Tue, 29 Aug 2023 21:48:17 +1000 Message-ID: <87msyakr26.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: gzxsdn4mtaspf3xjc8htcadzobqkmyth X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 695FE140010 X-Rspam-User: X-HE-Tag: 1693309709-254151 X-HE-Meta: U2FsdGVkX18tWjwzNGD6MnlY/NxsowfGZBFPebL+plILcoakSARULjIaHO3Gx3UtTJ/qgjBJmOnzQX/JNIBNX83xzgRinUTpUkaQWlGKH4+jxHruCjjcbp6khkzTDPuJ5OUGJCrL+Ta9+DT4rLLrs7vTFjlKCVUU7gHCdA4VJ815OY+Nl9tNYaXxQh64mqhLzO9w1WQfkbdY+moRXZAbracqqf4wcI/s4DWcdzspZ78h+/r6x60ebInG3CFn7LQw1Hl2m/oWzc4BmdbEb7QH0SddZiYe25VTI7xTLtKTfQH+NHRbxSrZUyhdukOIngoKGKi+J/SEM05gcS+EsqE5hW+VygOULo17bZ6f5toEYJvd3vNgQkJ9G2+h+r08uDc+rab/ipRik1vAt8PyW1Ivgf4fvNUPS6WbCBsxxfikVS+cnGTQs7B/VYpZ791uLkag/Z/je7xZGMyxg908uzliaHRh/pg65FvzDUbZauq+w2iiiPICBcszGqCOoLNECaQKHN3USPzBw6UEx01LZXC7x+JTB3qS90GQbUqmYnBkIKIfHebc7rriozFI98yO5KmpJM0asOPmUorYibRpkOTqsMORK/y7flVNa6N3Q61Wmjd4Xvc6tPPe3Vp+MHNqKqQfzGtY5VnjBS0+0GiEduEIhHoAYqARbwprds9svp0ds9Ms887o/xVgllmppltX3vqKiPbKzI9jvCBo3757QWvYbNnQG9dEUwdE6C8+XuIW6E15KjFITh3lewec0UY7RXWn8EL7Vjze59uRPPrP58rGLQf2iFlly9sbVU7Ul60qRBB/nNNIdefsajVdGdb2Asj2XgAYYZyUZ7Xznoc/CDbl8zEjppyu/pmaEJLToX6qIkFzbbqUyCp1IJanVuIuBwgXmZm/P/yX08pa1PkeJ9F29u8EpAZJfJG4+ebz4HiCMwVs66nWeb6JGzzok5Q/jT3h2sYibzcblF3E/2QKQxz iNrAx4D/ Duhfz/D4dgS9mtEP4GBRsXV5v4brYX5VGFT0a3wVfAfxZX7u8R68undNL07102A0YHSYqgcENyn8jkhP8iJPR5FJLDgwobQd3d4ve8HcM5qAk36/OnHK4qHGR8is8PForu3ZF1siqVwNiCse7zd2hHB75ZqykZ30NDTHpNlg514p5wQ6FJEOlGUaOHuqp+b099DdRBveqYOAvNOt4nef9CPXQ58bcKOoKkcM9kyH70HIrtfw40m1RMwGjmxS9ob34bJXn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Herbert Xu writes: > On Fri, Aug 25, 2023 at 07:44:32PM +0800, kernel test robot wrote: >> >> All errors (new ones prefixed by >>): >> >> In file included from arch/powerpc/crypto/poly1305-p10-glue.c:19: > > ... > >> ae3a197e3d0bfe3 David Howells 2012-03-28 75 >> ae3a197e3d0bfe3 David Howells 2012-03-28 76 #ifdef CONFIG_VSX >> d1e1cf2e38def30 Anton Blanchard 2015-10-29 77 extern void enable_kernel_vsx(void); >> ae3a197e3d0bfe3 David Howells 2012-03-28 78 extern void flush_vsx_to_thread(struct task_struct *); >> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 79 static inline void disable_kernel_vsx(void) >> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 80 { >> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 81 msr_check_and_clear(MSR_FP|MSR_VEC|MSR_VSX); >> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 82 } >> bd73758803c2eed Christophe Leroy 2021-03-09 83 #else >> bd73758803c2eed Christophe Leroy 2021-03-09 84 static inline void enable_kernel_vsx(void) >> bd73758803c2eed Christophe Leroy 2021-03-09 85 { >> bd73758803c2eed Christophe Leroy 2021-03-09 @86 BUILD_BUG(); >> bd73758803c2eed Christophe Leroy 2021-03-09 87 } >> bd73758803c2eed Christophe Leroy 2021-03-09 88 > > ---8<--- > Add dependency on VSX as otherwise the build will fail without > it. > > Fixes: 161fca7e3e90 ("crypto: powerpc - Add chacha20/poly1305-p10 to Kconfig and Makefile") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202308251906.SYawej6g-lkp@intel.com/ > Signed-off-by: Herbert Xu Acked-by: Michael Ellerman (powerpc) cheers > diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig > index f25024afdda5..7a66d7c0e6a2 100644 > --- a/arch/powerpc/crypto/Kconfig > +++ b/arch/powerpc/crypto/Kconfig > @@ -113,7 +113,7 @@ config CRYPTO_AES_GCM_P10 > > config CRYPTO_CHACHA20_P10 > tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)" > - depends on PPC64 && CPU_LITTLE_ENDIAN > + depends on PPC64 && CPU_LITTLE_ENDIAN && VSX > select CRYPTO_SKCIPHER > select CRYPTO_LIB_CHACHA_GENERIC > select CRYPTO_ARCH_HAVE_LIB_CHACHA > @@ -127,7 +127,7 @@ config CRYPTO_CHACHA20_P10 > > config CRYPTO_POLY1305_P10 > tristate "Hash functions: Poly1305 (P10 or later)" > - depends on PPC64 && CPU_LITTLE_ENDIAN > + depends on PPC64 && CPU_LITTLE_ENDIAN && VSX > select CRYPTO_HASH > select CRYPTO_LIB_POLY1305_GENERIC > help > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt