From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83063CDB46E for ; Thu, 12 Oct 2023 13:37:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E1F88D012A; Thu, 12 Oct 2023 09:37:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 094888D0002; Thu, 12 Oct 2023 09:37:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9C9B8D012A; Thu, 12 Oct 2023 09:37:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D95698D0002 for ; Thu, 12 Oct 2023 09:37:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A988AC04F3 for ; Thu, 12 Oct 2023 13:37:39 +0000 (UTC) X-FDA: 81336911838.08.CB70580 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by imf10.hostedemail.com (Postfix) with ESMTP id A33DEC0003 for ; Thu, 12 Oct 2023 13:37:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iaw1PRzH; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697117857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DlsMoTwDjOsqMcslz8wvJSyaA9FQoGSQ2eR6cRRonq8=; b=W0bABE7ZLdPKOcX5H4eiTHRh06eAvPYrZRGK3k6SwX23q4WYMHLRBmE7ZPinP9gzYw/q5n X0soebOqlS/XQiMvvVCDZCQC5k3TelmNhMFZliOpycXJLqTIGdcmmK8BYN8W3ekitxfbWN eC4hi6RuE7F/YgwNEmICi6uannesFdQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iaw1PRzH; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697117857; a=rsa-sha256; cv=none; b=uzexzwBOk9/rMtUkyVNic2nkhOFP7cRKGZ8AtQHGOkJMx1spoILSdiofg3iEgqKmmx7CQW ocUyfGKWtmQqH30P3nGXVwsTlwENrxyYoYnm+IpiaARJE0UGSVr9uDcUUo18MRWQbMOMnx JLP27qsR1UZbnWqzXNPjzkDt6OK5lHg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697117856; x=1728653856; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=2es9QpCjQe0fxU3AdQYO6Eo7Ee3E5kJdWJAssUgAlGU=; b=iaw1PRzHyDPM1faTMxdhozWGwG1ShpTKV6xs0ST4NinkO2AAXDWoNKOS qkzeBn2xZo/s3L6pS5y3k3yfyA/DAJMZiUJ7khbV0X87hjXD7ZHzBfxKh FIR3rk2vxqNrzqXWppfD45PEP+BrcJfD3Y2SpqjdjxUP5GceDX3E7prcs ocX0GFn7+/rF1cophgt8qs/eqNYyKp6ogXFs42x9oEuNVYBu45+kI6Dwd U0Oe3uV/fsPg34HHLIs/1DnnGx45Gs9n0dWmlhJ3qeFnzCtcwo0jeRcL6 XrSF+4wmXYmKYSz9px/yVD3dCbu8dbcaHGLMY00MXdbMv0tEbMEA+j9/U A==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="415971375" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="415971375" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 06:37:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="845003581" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="845003581" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 06:37:32 -0700 From: "Huang, Ying" To: Mel Gorman Cc: Andrew Morton , , , Arjan Van De Ven , Vlastimil Babka , David Hildenbrand , Johannes Weiner , Dave Hansen , Michal Hocko , Pavel Tatashin , Matthew Wilcox , "Christoph Lameter" Subject: Re: [PATCH 01/10] mm, pcp: avoid to drain PCP when process exit References: <20230920061856.257597-1-ying.huang@intel.com> <20230920061856.257597-2-ying.huang@intel.com> <20231011124610.4punxroovolyvmgr@techsingularity.net> <20231011101617.2f814633defaa13e77308d9b@linux-foundation.org> <20231012130921.mkcftgq4njnpl3qy@techsingularity.net> Date: Thu, 12 Oct 2023 21:35:26 +0800 In-Reply-To: <20231012130921.mkcftgq4njnpl3qy@techsingularity.net> (Mel Gorman's message of "Thu, 12 Oct 2023 14:09:21 +0100") Message-ID: <87mswodkv5.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: A33DEC0003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 51mcdaadisph7oag7fbs89qtppgj14nm X-HE-Tag: 1697117856-472047 X-HE-Meta: U2FsdGVkX1/JjYtkm46euBaux23akPZNFTk59yBEsL3CDd6E0ttUBHgVT1ah5Is+PIp2YE8Lw2A1Gczq5XifZtJdA2M+iRfhbxnfJwLD++iyghCSr9eUTTaIxemKeJtz4azFIGlVvJXKQWpAiFxJ7HDHY0jcieSY0f27+2KApdiYyyJlszPFNOrTMzVuKdhabDZyoW9GzEC4y0YhOQJVz4//w5LD+bBGlCIsQETczybVKu7dEe7L5sX7UQN+ercbPcgdN+xzUTMo0w7RfVGiLNVpDaDgoTBVlbzhcIK9E1cQoK2AXf64IlFStZu1MsKFzwkTnEGpb2BuCHkmgUveMRMsTH9uXUcc+ToKuTs4/FS6LcqfDq1penaAGzslLb54uJi9BaRrqgFFLwWfc009zKhDDhz5fga1gxkuRniK8rmxUIyWoti4xxtWtuM1NFF5vEJlKFHgjBPFbgIZqhS/+sKK0PIltZjshINbe4mPhrz/Bf3P+C4un9fsYP/0mAjha8X8KnBK+pgHqPSahkMPmpCVNdcJndlSu3QcWCXJ9ZyVh/w3tvy4gs0nq/Aw+TsvoC96BjzzZ00LrusdWJwiD2un3i6qT116wSWgLEaiXgjOUKOhWeu5M7C/VdQpGnqQHIqP337KcetveN0OoOGVtn0Z6a8J6yB4YJT1sKZfGoSx0x2C0a2gBEYsQuk52ogb1vOR837fIRnBXYTjcEY52zHrJConFPIVmAVj6/G5US69sgu7uSDzqlm553asj6eUuoMVb8D9cOdc7/qFjgXUptJT0u/E18UFuYtUCXt9ySFP4x8DdiFQxNxsclu7Lk1ohyKY3Be89glT46mprVb6jjSAGp0QAqZ+LHZtDIwjWoalofpmjU2v9CRslmztwiPwHHDLQaF+h/yiDkM8ILx1HbGIQxQa+0581CsQ1tzd/zXVpcOQHyi1M8DJx38aQW5SBv2C66pVEXjntnVYW0l OXYCLJyJ L5heyKJ6mlGXoBjey1b1s6QAKAzQV+YmSwDE4uC3rbnlR0IhPO1t1GpwKVI0Yd4PboJblsVk8koG0sz4oavF8PB3Vv0cCQMrJASx7dl1XbuXAVYS+DsQOxRTaD4+TmaybcM9mmQ8WXIFPi9DV+xLNLLeZZoJHUstx4+/LDV4cgUSDTE+r5WqaMZ6uko/TmxlVaivOuZz10u7f/ZI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mel Gorman writes: > On Wed, Oct 11, 2023 at 10:16:17AM -0700, Andrew Morton wrote: >> On Wed, 11 Oct 2023 13:46:10 +0100 Mel Gorman wrote: >> >> > > --- a/include/linux/mmzone.h >> > > +++ b/include/linux/mmzone.h >> > > @@ -676,12 +676,15 @@ enum zone_watermarks { >> > > #define high_wmark_pages(z) (z->_watermark[WMARK_HIGH] + z->watermark_boost) >> > > #define wmark_pages(z, i) (z->_watermark[i] + z->watermark_boost) >> > > >> > > +#define PCPF_PREV_FREE_HIGH_ORDER 0x01 >> > > + >> > >> > The meaning of the flag and its intent should have been documented. >> >> I need to rebase mm-stable for other reasons. So let's please >> decide (soon) whether Mel's review comments can be addressed >> via add-on patches or whether I should drop this version of this >> series altogether, during that rebase. > > The cache slice calculation is the only change I think may deserve a > respin as it may have a material impact on the performance figures if the > "size_data" value changes by too much. Huang, what do you think and how > long do you think it would take to update the performance figures? As it > may require multiple tests for each patch in the series, I would also be ok > with a follow-on patch like "mm: page_alloc: Simply cache size estimation > for PCP tuning" that documents the limitation of summing the unified caches > and the impact, if any, on performance. It makes for a messy history *but* > it would also record the reasons why summing hierarchies is not necessarily > the best approach which also has value. I am OK to respin the series. It will take 3-4 days to update the performance figures. > I think patch 9 should be dropped as it has no impact on headline performance > while adding a relatively tricky heuristic that updates within a fast > path. Again, I'd like to give Huang a chance to respond and to evaluate > if it materially impacts patch 10 -- I don't think it does but I didn't > think very hard about it. Even if patch 9+10 had to be dropped, it would > not take much from the overall value of the series. I am OK to drop patch 9 at least for now. In the future we may revisit it when we found workloads that benefit more from it. It's not too hard to rebase patch 10. > Comments and documentation alone are not grounds for pulling the series but > I hope they do get addressed in follow-on patches. I think requiring them > for accepting the series is unfair even if the only reason is I took too > long to review. Never mind, your review are very value! -- Best Regards, Huang, Ying