From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 860FAC48BF6 for ; Sat, 24 Feb 2024 18:28:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 020E76B009F; Sat, 24 Feb 2024 13:28:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F12F36B00AD; Sat, 24 Feb 2024 13:28:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E016C6B00AE; Sat, 24 Feb 2024 13:28:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CF6F06B00AD for ; Sat, 24 Feb 2024 13:28:02 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 99A83140474 for ; Sat, 24 Feb 2024 18:28:02 +0000 (UTC) X-FDA: 81827531604.26.A1230A9 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by imf10.hostedemail.com (Postfix) with ESMTP id 6F8BBC0011 for ; Sat, 24 Feb 2024 18:28:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708799281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rGZvU+ajg/yAlYr7yAVRnElGrXtJFQVB2yaXH3E4JqE=; b=s2jJP+b2vhsse6P7grKRJm/QwhCl1ea2pNKb5D959n1C6ugSH/2306hVB16XgntKGzcONB 8j8/syZ6zRGm0ASgOTeAC9/ZdA0LRppE87ARY8+GNdmOimTyUDaE5ZAchtf5bJv2iDXh9F aM+atR6zkGNt8xpcp4MYoNCshaX6Sw0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708799281; a=rsa-sha256; cv=none; b=YgNyvkhb/JD7JYodNe0zaMv3tOHYXRnVwWTMfi8JIsh/7EsSCOQKR7XGp6EiGPNEaLM2Si Om9bd6L0zoaWmqsZwYYMynhq4Wa7ul8IXpxfvWo+9Z1YiGJo5xuCKvv19QQQooCyvOzPE0 io29W/rdv6Ufvh8NPyKdhCFMTuRJLOI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp; dmarc=none Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id E70D3233CCB9; Sun, 25 Feb 2024 03:27:57 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.18.1/8.18.1/Debian-1) with ESMTPS id 41OIRsU4094238 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 25 Feb 2024 03:27:55 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.18.1/8.18.1/Debian-1) with ESMTPS id 41OIRsIi308651 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 25 Feb 2024 03:27:54 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.18.1/8.18.1/Submit) id 41OIRsIL308642; Sun, 25 Feb 2024 03:27:54 +0900 From: OGAWA Hirofumi To: Andrew Morton Cc: chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou Subject: Re: [PATCH] fat: remove SLAB_MEM_SPREAD flag usage In-Reply-To: <20240224134828.829481-1-chengming.zhou@linux.dev> (chengming zhou's message of "Sat, 24 Feb 2024 13:48:28 +0000") References: <20240224134828.829481-1-chengming.zhou@linux.dev> Date: Sun, 25 Feb 2024 03:27:54 +0900 Message-ID: <87msrpaf9x.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 6F8BBC0011 X-Rspam-User: X-Stat-Signature: 5puwh5wekjsk87w78sr4mgeuzfu9mg95 X-Rspamd-Server: rspam03 X-HE-Tag: 1708799280-715870 X-HE-Meta: U2FsdGVkX1+gtNgjmYmnVKlx0IcVgbXKPHsl8oil5xslUYMhc8lp3YgUVT9jvhGs7BkBT/GxkbJSutjz/DrS2ol/mmMGj4+r/T7lPVoauzpEznr1O/c2rL8LQYI/FzHMgBmryPe8r7zAwxM6vjdsg6TunkBGempCQPXbylgsUolSFldp21G4qae/5+d3rKoCMwRJNiMFV86cfNi+nQ0Q1jnz1UVIEz10CJBB9mCRvD2KZaO1igWmIyXv0su2W9qgsATpuR+ZWEel4Tic1FAFPt4/gUGFyWei7jkY12rR96ThBGZ7jXJkdnh4b/LRhEv0unzknuaztP4ChG3fuNH4xkwOTNmxOn63LJk3AsUNYQmCoNdRh3sQ003EJ+so+2L8hCDB8I6zh/+Y9eUVd/GoHPl1yEym38rdumOrdVufhoDiayCJ9uoKI4j4YddSSVeWMZ5VQZxqICP4Pg9VxXu5eGGg38RXufJkIlaUQJK7gkTMtf4srtWyEmQRamI+fdciDj/ipB4j93fFeN/PPwWzwEG6yfvj+P8L17m+AufHqiB4Y+RMWqk/VVH5AyvUNVE5uGTXUPNllZtHd2QO5lu4jPBwpIoV97pPc4fTQVxxL5MjynmVHkja5udWBKKLiwBWCjH5OniAs/0KCYKV6QC7FsBaNqvuOtkw1Szwkndc81HGlwcPa8V83ZXioIOP5/4USKweRmc9IKn6kFMKntbofhOIdtG0y8PMbBtwIt49weFkrh3suAYUg0660hOQS3l9ELq2MS6MUpoddPrvBaU4fAJaY6zlP/M1b6RZ7v+hIbejqeyWkUi4fEDo/+a/e6+ifeTwNFU5eg9mA+DIfDNRn9I9Q4hMkJXTMiS+RE3RRsNGbA1TyvSiovRjzrRjznaw6b2USKymVLLmA1SymTlL7h0JncG/YzyQj7wjh47QVaiK38tLFs/4OxIM0Z9GLlnjXVrgbPqdEyHn7hKVa7a cMKVumtQ 1+5LUqPl8Ma2AyWo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: chengming.zhou@linux.dev writes: > From: Chengming Zhou > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. > > Signed-off-by: Chengming Zhou Looks good. Acked-by: OGAWA Hirofumi Thanks. > --- > fs/fat/cache.c | 2 +- > fs/fat/inode.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/fat/cache.c b/fs/fat/cache.c > index 738e427e2d21..2af424e200b3 100644 > --- a/fs/fat/cache.c > +++ b/fs/fat/cache.c > @@ -47,7 +47,7 @@ int __init fat_cache_init(void) > { > fat_cache_cachep = kmem_cache_create("fat_cache", > sizeof(struct fat_cache), > - 0, SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD, > + 0, SLAB_RECLAIM_ACCOUNT, > init_once); > if (fat_cache_cachep == NULL) > return -ENOMEM; > diff --git a/fs/fat/inode.c b/fs/fat/inode.c > index 5c813696d1ff..d9e6fbb6f246 100644 > --- a/fs/fat/inode.c > +++ b/fs/fat/inode.c > @@ -787,7 +787,7 @@ static int __init fat_init_inodecache(void) > fat_inode_cachep = kmem_cache_create("fat_inode_cache", > sizeof(struct msdos_inode_info), > 0, (SLAB_RECLAIM_ACCOUNT| > - SLAB_MEM_SPREAD|SLAB_ACCOUNT), > + SLAB_ACCOUNT), > init_once); > if (fat_inode_cachep == NULL) > return -ENOMEM; -- OGAWA Hirofumi