From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: chengming.zhou@linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev,
Xiongwei.Song@windriver.com,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH] fat: remove SLAB_MEM_SPREAD flag usage
Date: Sun, 25 Feb 2024 03:27:54 +0900 [thread overview]
Message-ID: <87msrpaf9x.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20240224134828.829481-1-chengming.zhou@linux.dev> (chengming zhou's message of "Sat, 24 Feb 2024 13:48:28 +0000")
chengming.zhou@linux.dev writes:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Looks good.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks.
> ---
> fs/fat/cache.c | 2 +-
> fs/fat/inode.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 738e427e2d21..2af424e200b3 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -47,7 +47,7 @@ int __init fat_cache_init(void)
> {
> fat_cache_cachep = kmem_cache_create("fat_cache",
> sizeof(struct fat_cache),
> - 0, SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
> + 0, SLAB_RECLAIM_ACCOUNT,
> init_once);
> if (fat_cache_cachep == NULL)
> return -ENOMEM;
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 5c813696d1ff..d9e6fbb6f246 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -787,7 +787,7 @@ static int __init fat_init_inodecache(void)
> fat_inode_cachep = kmem_cache_create("fat_inode_cache",
> sizeof(struct msdos_inode_info),
> 0, (SLAB_RECLAIM_ACCOUNT|
> - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> init_once);
> if (fat_inode_cachep == NULL)
> return -ENOMEM;
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2024-02-24 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:48 chengming.zhou
2024-02-24 18:27 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msrpaf9x.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=Xiongwei.Song@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox