From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B829C25B79 for ; Fri, 24 May 2024 06:58:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFE326B008C; Fri, 24 May 2024 02:58:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DADA06B0092; Fri, 24 May 2024 02:58:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9CA76B0093; Fri, 24 May 2024 02:58:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AC5F56B008C for ; Fri, 24 May 2024 02:58:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 45E66160937 for ; Fri, 24 May 2024 06:58:27 +0000 (UTC) X-FDA: 82152385854.07.D908955 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf17.hostedemail.com (Postfix) with ESMTP id BFB6140002 for ; Fri, 24 May 2024 06:58:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pc5DIUMv; spf=pass (imf17.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716533905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=WUxSDJgPVHpIgkdW/SJCU4zEFv1caSZKZZ1ujvSgGJk=; b=boqa31CueFkC9iLCbrwLeOP5qChYPRBmntOzsfnw9k+0dghCZ6d0nfUUBK/dPYKh+wsjRB UK2fS2H0feYge9OQbbfnG7ByzdJc6OIZNdCWJSICwE3p8qV/vEzgbNtnkPezaVB1AMPIhr fXqM/qfWrAdJz7r2Q53OhrOD6zg1fMU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pc5DIUMv; spf=pass (imf17.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716533905; a=rsa-sha256; cv=none; b=mujcb85omCzDMYHQL00fMMmVc04aJBonwsDZyDqGlfMGiqzrEL20ljEoGeeNrJ4QD/TyON HwOAkErspT6pWO8FvmHzHY216CX0kpT69awoCQ4UHcigCuCYFTAFtfxGBn00SyUdGCvcMg JP+DfLZtNwLV+N3aEBZan7AElxSf4+c= Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-681a4422f49so395254a12.2 for ; Thu, 23 May 2024 23:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716533904; x=1717138704; darn=kvack.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=WUxSDJgPVHpIgkdW/SJCU4zEFv1caSZKZZ1ujvSgGJk=; b=Pc5DIUMvq71NS5hlR/e4RZZYrDCAsnYM948So4pVGH7TxoRfx6ZhrLdq09XP5XpP9Q SpbmIHJSMjI/mh1gtKdOx+TK80adejtIE5JgvjBmZbu50Xju6eEWGJ3g3vkg/3bCwHfq g4SRMA8d9xucdLUoDWUegVpuI0eYb48G5Y1uYIC0IaEPYosSpWqwu7Us20na0bDBH60b KoEzrSIWklmTiKhJVOIITWE4kiGuem5Oy+PyJW6MfNn6Fv84gQz2qPCWbH/wKQtoBBzv wsi/KRZ9JHiAW4smlL2rtkKxeMkdtuSNHCRZiSuxKwCcb3CMvzn/R9vg0Pi4KvQGw9k9 Tzdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716533904; x=1717138704; h=references:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WUxSDJgPVHpIgkdW/SJCU4zEFv1caSZKZZ1ujvSgGJk=; b=qj9z0PGGXMto7bKKNYOUILkklFG2magJX/0L8fUlSo68CBNO+qwekWnNreTd1/pWE4 N+ag43hW1xP3yB/fiQn08I6WuWUq7+Rmx+iU9uFfotQgcB0XzajSN7pkxGgGqa52IahW kEKlXQgotz3QA+KYcFf2oLdVhYYVH3vvguFZq7uxLbXuLkpOmsRUDyTwwspyh9oxzvBg dRECgD8YieLAIOhlsMwVBjord9onr/NPwidL/9k+6xChZdzQykiWm7KWGymOUNNSwbxt u+EwbTcgQXZnw6N1lnZSE8KVlNSwI1TNiVOeRhyk3+D551Ei5tbIekNlSzntCpmimxXg 78vg== X-Forwarded-Encrypted: i=1; AJvYcCVOULdc8W3WB7IXdcQ9Aam3UMYqG+WmAcCHqo5SyhcJwua9xSDh+psy8MIVPfep3PlTRbXHiva/OAnmeDLfBXmi/2k= X-Gm-Message-State: AOJu0Yzguqn4/1gZQtL2GAut77A/nEi0k0+SoG7RUmpmjEGQbKcQ9Rbh uxlT7/4NrVMqUqCUkWCiNT12H0DUARRticDx3Mth24/GsdRNuJnO X-Google-Smtp-Source: AGHT+IEyVxDn/tS3CPfkN4tv2etQTfMV97SvgDd69GnzXXAD79FVP1cAiZsDA/Dek/GUkxq0C6bqvA== X-Received: by 2002:a05:6a21:3e05:b0:1af:5d8e:c6c with SMTP id adf61e73a8af0-1b212d5df8emr1657909637.18.1716533904568; Thu, 23 May 2024 23:58:24 -0700 (PDT) Received: from dw-tp ([129.41.58.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c7d1b46sm6763385ad.110.2024.05.23.23.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 23:58:23 -0700 (PDT) From: Ritesh Harjani (IBM) To: David Hildenbrand , Andrew Morton , Donet Tom Cc: Shuah Khan , Matthew Wilcox , Tony Battersby , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , Muchun Song Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() In-Reply-To: Date: Fri, 24 May 2024 12:23:15 +0530 Message-ID: <87msofsntw.fsf@gmail.com> References: <20240523063905.3173-1-donettom@linux.ibm.com> <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BFB6140002 X-Stat-Signature: ub3zm851uofs9jpuqdn8skys18ipn8z7 X-HE-Tag: 1716533905-939164 X-HE-Meta: U2FsdGVkX1/s6LIokpFiL7huj+heyGyM7O+tWxFM7lFLxa1TJVLH0nwZZ9POJxcGk5FdX6FAkeXJq+q3pyzJdnbEdqTzcEfP9LW9T/4aRCd/qbWoL9v6DwQYEx1QNgzlRucAjFSJgu6OrG3Uf78DtZZcY3V37smGUZQKkXqF7kpg9vCS8+r7FppkzaFNJfVa4/ebt3LZ5A7PnAmlIWZR7qi7RyG5Hl3h/b7U4G4KL5/ck1UMZkZv8mD5nRQq8W8HdMMVsvOwv9pne5e2WCsU9DYG/rrGOcwkwUGIPdZhfC1y/ZjTck+FugCjF4PiQGpjoAfSstkld4pjEcd+jnGmUkvwaBh0zGbevzT+ZuI3XjYrIInTem9D3i2T/ubGyoUIklc10qmszP56QUdg17vYgvzPHNl6dZP3Rviud3yHXUVTqAPoOjourZCZLRt7DV24uBNXa8Kks1LC/cB76PIx/kbx7RNXJGEBezCNAnmi36QKicyLbH6BeFkVYcc9ygyfph5QUxYqslSl2KZkwpM1CbIvr2d3YKyPMxW4Y6nal4SLihLLRmWR9ey62fgrrkEDN2QXolbm445oU6AGPXOsKGzYe9HpX0xaQnYn2CEMQwT8HAfwH4u6FEimsUYPfn/1r6HFk9vnyewkXcentpAqHpqZrPJqJSZ1wznA+pEhrSIt1/16sP75lv4yjNbtj/DcKFlHySNRZEmGYjxRQBbCB/e2ZWUUQ2DKKBUDHdoQUy7szXpjxFHiDuQdUXCY1WQsWtQpQxou5X57aLuQXIxcUm90WxE+GBitY+D1qe+qZ4p0UjAkFlQFJ+NF9u4NrA1O/vcVwcp1jeVVlYvL62hGLfzvS8JQV32FB3uza1WiQY5G0W4wJ9Z1SNPOQYg3uaXe0Gip9o/dz/rrpvZw/qF0eU1XVfjTawkJrnzrPBL+QyXlhrrlAD/clGMGAGZooauLtEdfh3ckOcyzOMk9wpL 4ht+WizT HwfBYczoQW2Y40TU0qSFEYM071/AsnJ4JE3t2MkOe/Ziyrzd2kedb/T+J/AlhpFhkk+g2ukwr1DKcjF/gPJ7FCK2YaYtb0kzKVCzob99M8AN0D/uM/jYbN8gCTOXueiYYC91RzSCnw4jjYlRR3kGVisnmwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000178, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: dropping stable email again. David Hildenbrand writes: > On 23.05.24 21:13, Andrew Morton wrote: >> On Thu, 23 May 2024 01:39:05 -0500 Donet Tom wrote: >> >>> Commit 1b151e2435fc ("block: Remove special-casing of compound >>> pages") caused a change in behaviour when releasing the pages >>> if the buffer does not start at the beginning of the page. This >>> was because the calculation of the number of pages to release >>> was incorrect. >>> This was fixed by commit 38b43539d64b ("block: Fix page refcounts >>> for unaligned buffers in __bio_release_pages()"). >>> >>> We pin the user buffer during direct I/O writes. If this buffer is a >>> hugepage, bio_release_page() will unpin it and decrement all references >>> and pin counts at ->bi_end_io. However, if any references to the hugepage >>> remain post-I/O, the hugepage will not be freed upon unmap, leading >>> to a memory leak. >>> >>> This patch verifies that a hugepage, used as a user buffer for DIO >>> operations, is correctly freed upon unmapping, regardless of whether >>> the offsets are aligned or unaligned w.r.t page boundary. >>> >> > > Two SOF, is there a Co-developed-by: missing? > Sorry about that. Andrew, could you please add the tag (let me know if you would like me to send v2). Will take care of it next time. Co-developed-by: Ritesh Harjani (IBM) -ritesh