From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA36C52D7C for ; Mon, 12 Aug 2024 02:24:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53E186B008A; Sun, 11 Aug 2024 22:24:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4ED916B008C; Sun, 11 Aug 2024 22:24:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DC896B0092; Sun, 11 Aug 2024 22:24:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 174036B008A for ; Sun, 11 Aug 2024 22:24:00 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 70C861A19F8 for ; Mon, 12 Aug 2024 02:23:59 +0000 (UTC) X-FDA: 82441998198.28.35B51B2 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf13.hostedemail.com (Postfix) with ESMTP id 6556920003 for ; Mon, 12 Aug 2024 02:23:56 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZO6KSlT8; spf=pass (imf13.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723429383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sDZPVreHap+bI7rgu2Tjjl84rCSx2hJ5+oDGxSBoOUo=; b=Z9uH7Xvzn8k9kPsSw89UozIMINNU1F+b073rFAcQHjS4Sh1OO0U1NjmNAHRttpxCUv7VDG JfcIUnzD+zjd9gglaqdmohnrzpLIbuJp7y82/mANN7pKnwKc+6FuVuwVEpyk2xjW3aAzsD CqCcAiyj7tjeIvVd6cguyQXfu4X/7V0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZO6KSlT8; spf=pass (imf13.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723429383; a=rsa-sha256; cv=none; b=vGxBXR7z6ms20G8MPfAJd9RgjgIy8UKk1oLeEeYAiiSwFJYyjlvLWLgf6O/WzgUvYviUhc 87X0PH86ml8EOTfPkszTj7YBf9Q/gWLI6X8bkhsJzmIZKzsR+pjk/7+oFTrCUiTn3I30E5 QY6khu8+EQDQVi6SetIx66VUIm0XpqY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723429436; x=1754965436; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=97r3q4G7hJL2mOvZM1v/Mk/LoCU2r7TX511e4FaldzU=; b=ZO6KSlT8Mfk5Sp9+zO8ksoVuKj2YycwjVxwPFuUsaTU//Fjm29pJkxIM ZzEL4NkSLcwbX1dM5YC4Ej/smU49t3POc0wOSnoH9SZoOvppluMvehiHS Buj5YJNJoiPR298QmmoWtfRl75BXAu5i3DUmXndBo36s4ET2hL6b5+jqq 2VjPPhPT9pCT6AxGfnMs1TiVegKBXnHErvqODX5IOmDVNwo3MBy7INzID C8c+fX6xUlztPUStNfGWSTGvDlgj3uJyQ2GWGDUoScRqVqiyYyLSDnv2V /frAtRlvtIR/MQ1koylPvQ8neoX4AD7STvwIsFj4YMZ7dccByzsctVTA+ w==; X-CSE-ConnectionGUID: +x16OOHrTsysCn5bFnNkVA== X-CSE-MsgGUID: qawK1WwqQwyAkZ9Qe7rwUQ== X-IronPort-AV: E=McAfee;i="6700,10204,11161"; a="21496107" X-IronPort-AV: E=Sophos;i="6.09,282,1716274800"; d="scan'208";a="21496107" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2024 19:23:54 -0700 X-CSE-ConnectionGUID: 0+XGaZU1RAKCA/bMzzYiVA== X-CSE-MsgGUID: rXIcx2LURg6rI0VjN9Vz2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,282,1716274800"; d="scan'208";a="62769652" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2024 19:23:52 -0700 From: "Huang, Ying" To: David Hildenbrand Cc: Zi Yan , linux-mm@kvack.org, Andrew Morton , Baolin Wang , Kefeng Wang , Yang Shi , Mel Gorman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] mm/migrate: move common code to numa_migrate_check (was numa_migrate_prep) In-Reply-To: <17597d58-7da8-4555-b583-1997d78be018@redhat.com> (David Hildenbrand's message of "Fri, 9 Aug 2024 17:32:43 +0200") References: <20240809145906.1513458-1-ziy@nvidia.com> <20240809145906.1513458-4-ziy@nvidia.com> <17597d58-7da8-4555-b583-1997d78be018@redhat.com> Date: Mon, 12 Aug 2024 10:20:18 +0800 Message-ID: <87msliv5wd.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: 7ma8n3nq9a9b87krdn48mjuhkdqwwz55 X-Rspam-User: X-Rspamd-Queue-Id: 6556920003 X-Rspamd-Server: rspam02 X-HE-Tag: 1723429436-46415 X-HE-Meta: U2FsdGVkX18ea5z7s3Zvdnm647+FNuuKgWjhNoF20esHlmybHWbyqON0mHBVrlC6Reh3whqm7CotNbUp1G05dBFKZmrc67ozMIxnllu75B4MvZVEzHxunhYBIbo7In/CiZXkyQOvV6hGxjDvBEEZ1xJ4kyXPuXkptgtexyNZH4pdjoHAR5Y+144IXiJj2Z1CN+jzhE9Wz6Ah6VM0ahai+gN/VDFKIoT46KikB7hXAec3ybDytwNhLiDR1B/pLlsqkAsdOEClr4bxAEYoLXhWtwpMaESoFvOdTYS/KLi9Nz1TfQGegyg6UZ3VBKg5jESQYUQufneAZjaJHpWk+aZXs/Fieqro3tSiC8BXzBI4E6MVcH1sGvhLsVbLDJZ09NeXcetbuK2wbFFO9kIuygAhDYmAleUEQOqjIzJCAMm689f8zHvDJ89ghvbzsULZawdUDFtCIcAnnCKfu8C0DYOd+LFvr9sfPxHldyTMqsE7rGue9HDCGTUSV3aL9tgakKTnb4rnG6YsEv6/2iZCY+fb2pnxXQLlAjxfQeBljIHb+6GU50DE96bHMJ8qxQP/dKwlAzhkWrHWpVAWHG6XfG4wXSadivaxXVis72E+PVzdMn5vbc1oi/kf0Lw1DP7IvYjiyq5tXnTITP+fzZ7T+sYBa+HkEvnie9Ajq7V1ZpqROOR4JU2aVzoju+TpHOqtB+9o8nu6tWr2vd8bA2lVPn24USsJ6L135uJYcjb1GGabtB9BStpCV3MYy3vMjyo0qc0hHBbSREYtyBc74pXGVYDO5OmuoHEqgLgxsJ8+rq8f7wAiwcCCIokO7ZOsvhnZJFHkzbppbOEwM7+MbQguQ2G2c6CmG+7u8ZbLPh5GDNNdcNviUxkFulwlQO+hNn273ONwY0fP0nKJoxTpPNTWrFMMxc2oKaGTSoR/7AYvK3IJpYKeMYllSoo4/X4gmD4p1iPNGVmnlPnTSS8TNMKzSAT jytQA9oF 4Q5FfZLh2KugJkvWZeFsJMZd90e/4mVPmQT1acboTeTPmNQEwCk3HC9y4Ht3wV2BTCok5Z73t+A/ETKE+KB2O4wsuShmjmjKp5KEFv7bu6r99kBYxFqGJA9QsoHEEp12HPSQm89yftfNhWTnTMBIy5uuqwnM9jSrOC8cLpHN8zOuciOlwVF1zxYQ8zpb9DBcRU9MsUitqfM8wPV99hCnnJi/27A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 09.08.24 16:59, Zi Yan wrote: >> do_numa_page() and do_huge_pmd_numa_page() share a lot of common code. To >> reduce redundancy, move common code to numa_migrate_prep() and rename >> the function to numa_migrate_check() to reflect its functionality. >> Now do_huge_pmd_numa_page() also checks shared folios to set >> TNF_SHARED flag. > > Yeah, I was also wondering why we didn't check that in the PMD case. IIUC, before commit 728be28fae8c ("mm: migrate: remove THP mapcount check in numamigrate_isolate_page()"), we don't allow to migrate THP with mapcount > 1. So, it's unnecessary to set TNF_SHARED flag at that time. However, after that commit, we need to do it. -- Best Regards, Huang, Ying