From: "Huang, Ying" <ying.huang@intel.com>
To: David Hildenbrand <david@redhat.com>
Cc: Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Yang Shi <shy828301@gmail.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] mm/migrate: move common code to numa_migrate_check (was numa_migrate_prep)
Date: Mon, 12 Aug 2024 10:20:18 +0800 [thread overview]
Message-ID: <87msliv5wd.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <17597d58-7da8-4555-b583-1997d78be018@redhat.com> (David Hildenbrand's message of "Fri, 9 Aug 2024 17:32:43 +0200")
David Hildenbrand <david@redhat.com> writes:
> On 09.08.24 16:59, Zi Yan wrote:
>> do_numa_page() and do_huge_pmd_numa_page() share a lot of common code. To
>> reduce redundancy, move common code to numa_migrate_prep() and rename
>> the function to numa_migrate_check() to reflect its functionality.
>> Now do_huge_pmd_numa_page() also checks shared folios to set
>> TNF_SHARED flag.
>
> Yeah, I was also wondering why we didn't check that in the PMD case.
IIUC, before commit 728be28fae8c ("mm: migrate: remove THP mapcount
check in numamigrate_isolate_page()"), we don't allow to migrate THP
with mapcount > 1. So, it's unnecessary to set TNF_SHARED flag at that
time. However, after that commit, we need to do it.
--
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2024-08-12 2:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 14:59 [PATCH v3 0/3] do_numa_page(),do_huge_pmd_numa_page() fix and cleanup Zi Yan
2024-08-09 14:59 ` [PATCH v3 1/3] mm/numa: no task_numa_fault() call if PTE is changed Zi Yan
2024-08-09 15:29 ` David Hildenbrand
2024-08-09 14:59 ` [PATCH v3 2/3] mm/numa: no task_numa_fault() call if PMD " Zi Yan
2024-08-09 15:29 ` David Hildenbrand
2024-08-09 14:59 ` [PATCH v3 3/3] mm/migrate: move common code to numa_migrate_check (was numa_migrate_prep) Zi Yan
2024-08-09 15:32 ` David Hildenbrand
2024-08-12 2:20 ` Huang, Ying [this message]
2024-08-12 9:06 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msliv5wd.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=shy828301@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox