From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1C7ECE57A for ; Mon, 9 Sep 2024 14:15:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 913616B0173; Mon, 9 Sep 2024 10:15:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C2556B0174; Mon, 9 Sep 2024 10:15:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 789BC6B0175; Mon, 9 Sep 2024 10:15:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A4B66B0173 for ; Mon, 9 Sep 2024 10:15:48 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EFC57804F8 for ; Mon, 9 Sep 2024 14:15:47 +0000 (UTC) X-FDA: 82545398334.09.297B107 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by imf01.hostedemail.com (Postfix) with ESMTP id B7F3D4001B for ; Mon, 9 Sep 2024 14:15:44 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=krisman.be header.s=gm1 header.b=LOi+rtgG; spf=pass (imf01.hostedemail.com: domain of gabriel@krisman.be designates 217.70.183.198 as permitted sender) smtp.mailfrom=gabriel@krisman.be; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725891243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sWkQECCtCkYRpgRDI91m9jn0h/1pf2RieDIOritsh40=; b=is8IBF8D0SRqpfvDXNn+P2YxqYciZ11AoJSi1X4b5bQ9ViHNBVif6uH4oySlg4ppSYakoY hlKKPYF4DyWouBIYs3eG/8JHZYVEscvPQGwUgNTRmXarh8PauuPSN0Gs4SLxCUm9j0sN43 Cx2NqNMuweK3hm+E4uskDs8zav090+o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725891243; a=rsa-sha256; cv=none; b=TTAI3pA33cDzyeyCaZ+nLWs555Z/ECXRHzFNH2cbGp+6lemZr1kyLXBrY45aohOGOC+6BA q8HZx2IT0rYfiTAhbNqUnQkQdqi6GijPzLtfcpaRj0l2QhV8nakPzN3QYvSjoxc0Bpuz3P ryU+JE/xJFAY8zx3V/EJ1Sr6fvfOhsg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=krisman.be header.s=gm1 header.b=LOi+rtgG; spf=pass (imf01.hostedemail.com: domain of gabriel@krisman.be designates 217.70.183.198 as permitted sender) smtp.mailfrom=gabriel@krisman.be; dmarc=none Received: by mail.gandi.net (Postfix) with ESMTPSA id E9FC7C0004; Mon, 9 Sep 2024 14:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=krisman.be; s=gm1; t=1725891342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sWkQECCtCkYRpgRDI91m9jn0h/1pf2RieDIOritsh40=; b=LOi+rtgGnheOXae/d2UEPXvxLV8PMBlILKkTb/9SKlAO+PUk7ffDzbXYTBCrc8G1wl2xhJ 4F5mWdSRfmBJrBPjd200i6xtBBcX+/Yx3xHfAZ5RGD47FvIhC4QrQPm8GDSS7L4fL5QGTU yIHPjVdYz/VDNvu42st3oXwqlg8ngAkMB14RSmneUcWH5f1f4KOUkxDLTAo8lNt0DqPrpF eQBSpjlLVj/wsW6rBwEhDbJEyBLkwKiqCT6bREUC0/SY2Kdh0kwdsJDLtHMjXB7EKAfxNA elfekdcP+i9CIjqKOPBQnLzNcIeay9Jxs9RYZvRQS/CV2hvcd/xAIdK8hx3bbw== From: Gabriel Krisman Bertazi To: =?utf-8?Q?Andr=C3=A9?= Almeida Cc: Gabriel Krisman Bertazi , Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig , Theodore Ts'o Subject: Re: [PATCH v3 6/9] tmpfs: Add casefold lookup support In-Reply-To: <956192d3-5fb8-4ecc-8625-a34812df537b@igalia.com> (=?utf-8?Q?=22Andr=C3=A9?= Almeida"'s message of "Fri, 6 Sep 2024 11:59:45 -0300") References: <20240905190252.461639-1-andrealmeid@igalia.com> <20240905190252.461639-7-andrealmeid@igalia.com> <87zfoln622.fsf@mailhost.krisman.be> <956192d3-5fb8-4ecc-8625-a34812df537b@igalia.com> Date: Mon, 09 Sep 2024 10:15:31 -0400 Message-ID: <87mskglxq4.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: gabriel@krisman.be X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B7F3D4001B X-Stat-Signature: a3z45jfg5bxqiowasexzdnykfszwrw3i X-HE-Tag: 1725891344-882886 X-HE-Meta: U2FsdGVkX1/XxfkJlo1bWi3tfMaP++D3uIQqmcjxEsPm4M8ZiRhl4kBHiGOE4k0YrKpQZVX7hq5+JAkovsG2PZ4qYQotTsNiQLvsOtk2km9Y9w5F1z9mRR3UYmqWdHBfmmEI+PCGoMxlPzvc2wBKrYYWbySsezvO9G0kU+g4nSNP83722W6n1qW1pwHjR+WbOAJF7tU2AqTNB9mHxvAxBKhAKkKNtoZg31xK0edKofrlIHBr7JPJLiDDGXOvZiIgRRkpGXpbIof6WMyjNgIh8WkFFMrlFRhhmimmNf/dRac5l3tYPYnDC86MFjLYryhXQeeGeUqsSyt3s6QgFYmxqtQ4UbZRolmMDrrLPqznBWA8l1du5PBFJ+zsg/kpkbhf5tVNjR0q4/LXjytGw2S2gQ4mfZgGud+vcUPHn8JudjF5AZEVQhre1WGmaiREumS1j9c5MA9hmaRKzd/jOEVnjwpo/UU4ucDXkpxqxnIHolSvhd3vsaDZgOChgR3koZQYO7U5Yn/e0rVqupNOSDIAvKu4nSIR++LPl5dkf59+42l0zbdgdAzAC3oRB20hHk3kmBlc9ppsX1OeyhGDT1kvy+c8DwWbZ/ghKxZ9SBn0yiXZDlPREyOM8GSe7Xz/ELxz0htklXuOtTdDxY2D8q/NvGrbwgsQqHThM9v4PY0sLMYiR7FzuodzzgH1jyN132hwOEYtFSR4dlZPAXUK2E+GskS7StsZJTQw3hOo72mtZwSwtqST1+YKhdOaf18z8bRVBM9HgSQrs5mNSTSzBxhEHDpLPgfl1ySjNWtgg4u9KKcQD88ybIaqk2kCnUuTuwDoIwaSGhtCEKPUd9VzQYLvYmQiWewbnToD4MlwUdsnFd4nBY3KWOfTST0zgzDsjsasL5+iRNZliISv8bHdHadMwHVy7anbtXRw2ruOzNHqxjZgsI/Sb02AD5RkCjDqalfHzafadTNTcxIIVaHr3Zf Pgs8liV8 tcCihwG4Tl5ldiHadEOT4gvyOluY8nqVKvHOM0VLEHYlZDBHtPSWzR1q8UN4A4xeaKxi6Pr+cxfQSY4BbHdxctcLP7BGCqq/oZ03iVEkHWrkT3TIPuGv4gG1bm5h7Ubke+VtSadZbUxZ82rDP9p34EpeixnhJu2Kr2lw/nP0MXI/WgBH8Z3r1cIipGDE0tU4aHW1XRCq3xabIp+dkZCJH80Zerd2mLeVdArtQYu3VzjMGKEyQvu54X+X/ElLBSOYv9bTaV72+tjm5WEyK9R5601FDXazRkW6mTNkjWE0RXhELpOk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andr=C3=A9 Almeida writes: >> The sole reason you are doing this custom function is to exclude negative >> dentries from casefolded directories. I doubt we care about the extra >> check being done. Can we just do it in simple_lookup? > > So, in summary: > > * set d_ops at mount time to generic_ci_always_del_dentry_ops > * use simple_lookup(), get rid of shmem_lookup() > * inside of simple_lookup(), add (IS_CASEFOLDED(dir)) return NULL > > Right? Yep, that's my suggestion. --=20 Gabriel Krisman Bertazi