From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B04C282EC for ; Mon, 17 Mar 2025 14:55:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32DB0280002; Mon, 17 Mar 2025 10:55:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DE59280001; Mon, 17 Mar 2025 10:55:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17ED8280002; Mon, 17 Mar 2025 10:55:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EFCD6280001 for ; Mon, 17 Mar 2025 10:55:26 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 167E7C015F for ; Mon, 17 Mar 2025 14:55:28 +0000 (UTC) X-FDA: 83231341536.17.B081409 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id BD0D810000A for ; Mon, 17 Mar 2025 14:55:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M6VW8HI4; spf=pass (imf14.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742223326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xNnWO/K1u8WG4XUZJxS4WUVdfdhF3mjZ+5wwJk9E/4M=; b=BfP7MOHP2HE1V2VxqH7OpCPeENFUPzQoOxl+wZCaYwOPbf7l6sIep+NbPqlVEkavU5uXzz SggKD9pe9HrjxdFdfL61elWe/juPlPKqvR9jHhqqNC9Z/4JFx+GWmsaYSRY8Og4ZzQNZuc 0u20njf9i2wBJ0lQgbJGgIXASQN+HS0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M6VW8HI4; spf=pass (imf14.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742223326; a=rsa-sha256; cv=none; b=gHIH8KMTQKz/1eE4McPhhyQproab5ydDSemI95qdx6aBPzPcHlAPgLfRyYFy8wInpVaCdy TH6GwXAEa9weQ/DRbnheB4yR8uPV6O37ooD1avCcR+GJvgbm73/9VGxq4qRcynr2OpQC6V hutyCzshUNIpgVMlN23wHB4uihBwiIw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742223325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xNnWO/K1u8WG4XUZJxS4WUVdfdhF3mjZ+5wwJk9E/4M=; b=M6VW8HI4VWEWTe/ynqN6bORakSLTwXTWIa7ZpOIF4q+WJtyNBmyIofLhGhwqSEJkDxBwj9 Dz5BNlIUyT01shAFRD54DkqrXP1+9+BxvNbg5aswVKdjQgBukobmBQqYXZ9Ejeh5mK6huR rCByUPmFovAvKn0nDnf5IpCW0LtT9Hs= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-80EABdGjPdS2gmQ7PlZh_g-1; Mon, 17 Mar 2025 10:55:23 -0400 X-MC-Unique: 80EABdGjPdS2gmQ7PlZh_g-1 X-Mimecast-MFC-AGG-ID: 80EABdGjPdS2gmQ7PlZh_g_1742223322 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-54991f28058so1729516e87.3 for ; Mon, 17 Mar 2025 07:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742223322; x=1742828122; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xNnWO/K1u8WG4XUZJxS4WUVdfdhF3mjZ+5wwJk9E/4M=; b=Rql9cKFygIU1x6yR7TgYBiqp+v829xCDbipjWJ6YMis+eioZrcGdLUUnMhwHDf7I6E i1mIhXuGIsC/2JZedsnyYUHfYY1GA6qrPl7ZwtAXZXKEkIET8+xEvurunJDk5SluO8I+ RFnL9Ntbq3+Jk3WXnq3ucVGL7ccIOHAtjrdL5zAzFe9IsJP3XS8Wsj9CbU/F1XY77/WN TsBo0Br9bJhI4Yu4pf55rj4JvNntaC20sXePnVfFSxivHROsUsO6u6iW0gWnN8hEYP8Z ORED20EKqflSB0KXOsQyIIFq4wSi6XDk326H+fA4X+gEhZnf+wUchTdUWPMBPRnIO5gy vK3g== X-Forwarded-Encrypted: i=1; AJvYcCWTTN9WGj6RBVUEQGOJp03EeZirj1YD/EdgeI5CHZdLpzHp3ID73CV/KMOvVcM6AxNFts8wiH7VCg==@kvack.org X-Gm-Message-State: AOJu0YyMVzlEwJrsi/EOk04rJqQ1do2sDBwkxEASbQgcdYy+zP7yDUdT 0Ss/O+rTB/J16bEN0qQGrLfx0VvnmZF8uqBGvPhzvGINfRWhqjZwX3rdmUAgKzQAvsyHpxqnNqJ q4F6NONpNlnxnvh9ssghGrLD5lUq+frsVk2XWkt3Qj65MIQXj X-Gm-Gg: ASbGnctqwMgC49DleGJyUgOPCAb5ZRGhZkBInvMXdA0cM7jyDW2Dz55EHSqxrtiYyRa tdz3Wa5xBbDFo+rEFuSD1ZcUdGkQzaOXhBdwHCGL2dLGdrZOME6VEOdaVTQFt+YPirdMJ9EWvBB 6tnITnCcfLtqJC7hbAVRp4SkC1SddttyfPof4Y6ZHLL/7srFBv+2SlfLjMEhJUeccqXgNTQAqHc QXHvO1EaoYDaEK/JSHF5WGghHDH2ifpR16hRYDKXY0rktPPvoM6R0qMn5rWKJ+muZFi88LjdY8H URctQKq7i0pM X-Received: by 2002:a05:6512:2256:b0:545:2eca:863 with SMTP id 2adb3069b0e04-54a03cf6675mr26259e87.42.1742223322294; Mon, 17 Mar 2025 07:55:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkU4EGv0nYoD/ziKJsZtzUZRRSbpyRPe5/A4qyQD074afFL4/ETFCYpbFS8GyZgIxIK6weCA== X-Received: by 2002:a05:6512:2256:b0:545:2eca:863 with SMTP id 2adb3069b0e04-54a03cf6675mr26237e87.42.1742223321810; Mon, 17 Mar 2025 07:55:21 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549ba7a86c1sm1374403e87.21.2025.03.17.07.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 07:55:20 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id B523218FAEC4; Mon, 17 Mar 2025 15:55:18 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Yunsheng Lin , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap In-Reply-To: References: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> <20250314-page-pool-track-dma-v1-2-c212e57a74c2@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 17 Mar 2025 15:55:18 +0100 Message-ID: <87msdjhfl5.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZNDD3ib7u6AoA-rr9HfBqe12zE6_nI44Xcr5Mi1kfKU_1742223322 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: BD0D810000A X-Rspamd-Server: rspam08 X-Stat-Signature: yinut6su34nbhrteqnm4sjny536ja6w9 X-HE-Tag: 1742223325-982362 X-HE-Meta: U2FsdGVkX1/hGKk5XlGCzWA0zql/QPJu+ntnDZ31PcicGeOBfXcLvySxT6V6szBIAYfhzE/2mlDmaErFg/HgjbOpBfev3WNLMbU0vAxu9rRA4UHb+wVM9D3jgnNLLEPS9eTvz6G1jj/l7iAKC6yqWCvdBjI+AvSyge2FTbOJfx695/yNRZNuWRj8cyuEXwOkF9mVKKvge3i9kueXB3wci73YKggYspggyusyiIf+lq3gFRJnFDQa2mClHwdsFLG4zf9zCKFvpImHqcQqSZB2Kg/qnpaCNHYrAndLKPGFENbTQoe34RQrcwr5b9dugNAXy+bTDta2d3lrO7ggxf2rEwz6A3qy+iQd0acIZHRpHq/MilE3cqwVcWE8zMi3UhpR4gviS5VZrVxvdpwgxa0VaxoetrjGeEMN+eK9w4cs7ucsCFSmzquqkFkVXEvGLgtzBy83kjyvoTqiU4DXYZepDiZCsdBZvodqluGgwTPzs+m5Iw458nJjgv1h6XPK/RCqQ8FN4bLeQZ3rVE1XQtuouKyFu6ABamR5kD8oFn7od96T+McVZmweGYZnfVggPa0jHU/+UzQ0m3vbi0LY10x+exbj34V1/ci71Is3A+cfKKE6b6jV+KVEKAnvXsaOSzUxp8KfWxPVmy7K5KQOc9oEGIv7ys7KqkAPrfHJCDPOf+Mp7+M50s5ZG1oB4jROm3AN9FvjZitvZ6UWhFgph999OY0JKdI2YMS1JFaPO96Prvid7C6t7lpdIzd+XcwzDLkkR1aE+9cV79VN/jG2qB7MU/uKrNtWBqP5eUitwgdB6XUMuXG9hw/Io2Howeuu/xKtR1t5DRQA+gILUbAEFODmjHt4voIHfv4i1sZ7BX8auV8MZA8QyBfC1QhOVPCt8c4CKrkqbll1MxvrZv/ZnfIPPfu7OIxRSIME0IdbYk0K/D8fJSHS1xgZXnjSs7GruCW1sV9GWoklWRR5LQMLu4z wDa+uyFz 2GrsCVZsdmjYsu/FAEoRSXu12TofTCBQfZS99WY+zoe8HpeTHtHTauSQ7XougZM0bnhQywz2S2ZUWID7EPld50mGioEhbTCy6NZeYcWC4lEHjAD4ENUqqYYctX5Qq72SBZ/P5az2YfeMpg/49blq7hwHIAJy3YvZXO0AkuH6cZ0HlIfA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Yunsheng Lin writes: > On 3/14/2025 6:10 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Change the single-bit booleans for dma_sync into an unsigned long with >> BIT() definitions so that a subsequent patch can write them both with a >> singe WRITE_ONCE() on teardown. Also move the check for the sync_cpu >> side into __page_pool_dma_sync_for_cpu() so it can be disabled for >> non-netmem providers as well. > > I guess this patch is for the preparation of disabling the > page_pool_dma_sync_for_cpu() related API on teardown? > > It seems unnecessary that page_pool_dma_sync_for_cpu() related API need > to be disabled on teardown as page_pool_dma_sync_for_cpu() has the same > calling assumption as the alloc API, which is not supposed to be called > by the drivers when page_pool_destroy() is called. Sure, we could keep it to the dma_sync_for_dev() direction only, but making both directions use the same variable to store the state, and just resetting it at once, seemed simpler and more consistent. -Toke