Re: [RFC 17/22] s390: Use generic show_mem()

[Johannes Weiner <hannes@saeurebad.de>]

Hi,

Heiko Carstens <heiko.carstens@de.ibm.com> writes:

> On Thu, Apr 03, 2008 at 03:00:22PM +0200, Johannes Weiner wrote:
>> Hi,
>> 
>> Heiko Carstens <heiko.carstens@de.ibm.com> writes:
>> 
>> >> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
>> >> index 8053245..27b94cb 100644
>> >> --- a/arch/s390/mm/init.c
>> >> +++ b/arch/s390/mm/init.c
>> >> @@ -42,42 +42,6 @@ DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
>> >>  pgd_t swapper_pg_dir[PTRS_PER_PGD] __attribute__((__aligned__(PAGE_SIZE)));
>> >>  char  empty_zero_page[PAGE_SIZE] __attribute__((__aligned__(PAGE_SIZE)));
>> >> 
>> >> -	printk("Free swap:       %6ldkB\n", nr_swap_pages << (PAGE_SHIFT - 10));
>> >> -	printk("%lu pages dirty\n", global_page_state(NR_FILE_DIRTY));
>> >> -	printk("%lu pages writeback\n", global_page_state(NR_WRITEBACK));
>> >> -	printk("%lu pages mapped\n", global_page_state(NR_FILE_MAPPED));
>> >> -	printk("%lu pages slab\n",
>> >> -	       global_page_state(NR_SLAB_RECLAIMABLE) +
>> >> -	       global_page_state(NR_SLAB_UNRECLAIMABLE));
>> >> -	printk("%lu pages pagetables\n", global_page_state(NR_PAGETABLE));
>> >
>> > These are all missing in the generic implementation.
>> 
>> These are all duplicates from show_free_areas().
>
> In this case ignore my comment ;)
> Btw. your patch regarding the removal of show_free_areas() from
> s390's arch code will be merged during the next merge window.

Okay.

Do you mean the removal of

	printk("Free swap:       %6ldkB\n", nr_swap_pages << (PAGE_SHIFT
		- 10));

in show_mem()?  This was my last patch series about.

Can I add your Acked-by for _this_ series?

Thanks,

	Hannes