From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, mhocko@suse.cz
Subject: Re: [PATCH] memcg/hugetlb: Add failcnt support for hugetlb extension
Date: Thu, 24 May 2012 10:10:00 +0530 [thread overview]
Message-ID: <87likiyyxr.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <20120523161750.f0e22c5b.akpm@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> writes:
> On Tue, 22 May 2012 17:13:11 +0530
> "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
>
>> Expose the failcnt details to userspace similar to memory and memsw.
>
> Why?
>
to help us find whether there was an allocation failure due to HugeTLB
limit.
> In general, it is best not to add any new userspace interfaces at all.
> We will do so, if there are good reasons. But you've provided no reason
> at all.
>
>> include/linux/hugetlb.h | 2 +-
>> mm/memcontrol.c | 40 ++++++++++++++++++++++++++--------------
>
> Documentation/cgroups/memory.txt needs updating also. You modify the
> user insterface, you modify documentation - this should be automatic
> for all of us.
How about the below
diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt
index 730e222a..3a47ec5 100644
--- a/Documentation/cgroups/memory.txt
+++ b/Documentation/cgroups/memory.txt
@@ -80,6 +80,7 @@ Brief summary of control files.
memory.hugetlb.<hugepagesize>.max_usage_in_bytes # show max "hugepagesize" hugetlb usage recorded
memory.hugetlb.<hugepagesize>.usage_in_bytes # show current res_counter usage for "hugepagesize" hugetlb
# see 5.7 for details
+ memory.hugetlb.<hugepagesize>.failcnt # show the number of allocation failure due to HugeTLB limit
1. History
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-24 4:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 11:43 Aneesh Kumar K.V
2012-05-23 23:17 ` Andrew Morton
2012-05-24 4:40 ` Aneesh Kumar K.V [this message]
2012-05-24 5:16 ` Andrew Morton
2012-05-24 8:29 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87likiyyxr.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox