From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31100C433F5 for ; Thu, 25 Nov 2021 14:25:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B00A36B0075; Thu, 25 Nov 2021 09:25:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAE3B6B0078; Thu, 25 Nov 2021 09:25:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C3B06B007B; Thu, 25 Nov 2021 09:25:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 8DAD46B0075 for ; Thu, 25 Nov 2021 09:25:21 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4EDFF181B04B3 for ; Thu, 25 Nov 2021 14:25:11 +0000 (UTC) X-FDA: 78847674822.21.7F4238E Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 31CEF190F for ; Thu, 25 Nov 2021 14:25:10 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1637850309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TFMMjS5RkT+RI71yue1n3IxbBtVRj0GIoMvASrmcer0=; b=0/Y16YWJSS1Jp545yUC26yH6psBLPlGA34T7HX1kciK8drwSXp4FmTpWEMA+SwSqhmFpUZ L+qVpr2EHNBvtOV1QjNY1HkrFka4JYHIZMdrut/I0gGa6xZpSK2X3H8yJFKkl0hcSqnGxz 1wtUOgcAMdwWPwUgKLjKmXvWD6QMnFAu5Wh6Uy3wag7Wxi4Zg4OKM6BbhBvedZyNNPbMin xc4bdy4lpSqK+QfwRBw3f0e0kVGabMNSrEZ5LOTAp7zrZ0yNkh7oiJNfYIL0y/bKpBsPCh zZxEV89Fu2AXzrIJFuAjpkhxAHvlSRW4yjcjn9vwHEM8gSn1R9oR20ijXwL3VQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1637850309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TFMMjS5RkT+RI71yue1n3IxbBtVRj0GIoMvASrmcer0=; b=j43w1IbkalIhzPTD2Fm6ml+1jb7PtzC55CNrQUfRnYUjgRJeL4L2Z76VAwjBm/vW75OJcx fphBSfpB9qW7jICQ== To: ira.weiny@intel.com, Dave Hansen , Dan Williams Cc: Ira Weiny , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , "H. Peter Anvin" , Fenghua Yu , Rick Edgecombe , x86@kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH V7 03/18] x86/pks: Add additional PKEY helper macros In-Reply-To: <20210804043231.2655537-4-ira.weiny@intel.com> References: <20210804043231.2655537-1-ira.weiny@intel.com> <20210804043231.2655537-4-ira.weiny@intel.com> Date: Thu, 25 Nov 2021 15:25:09 +0100 Message-ID: <87lf1cl3cq.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 31CEF190F X-Stat-Signature: nhg6c1877kzn7ufre1o1wsz8pxt95efd Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="0/Y16YWJ"; dkim=pass header.d=linutronix.de header.s=2020e header.b=j43w1Ibk; spf=pass (imf22.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-HE-Tag: 1637850310-120161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 03 2021 at 21:32, ira weiny wrote: > @@ -200,16 +200,14 @@ __setup("init_pkru=", setup_init_pkru); > */ > u32 update_pkey_val(u32 pk_reg, int pkey, unsigned int flags) > { > - int pkey_shift = pkey * PKR_BITS_PER_PKEY; > - > /* Mask out old bit values */ > - pk_reg &= ~(((1 << PKR_BITS_PER_PKEY) - 1) << pkey_shift); > + pk_reg &= ~PKR_PKEY_MASK(pkey); > > /* Or in new values */ > if (flags & PKEY_DISABLE_ACCESS) > - pk_reg |= PKR_AD_BIT << pkey_shift; > + pk_reg |= PKR_AD_KEY(pkey); > if (flags & PKEY_DISABLE_WRITE) > - pk_reg |= PKR_WD_BIT << pkey_shift; > + pk_reg |= PKR_WD_KEY(pkey); I'm not seeing how this is improving that code. Quite the contrary. Thanks, tglx