From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FA6C433F5 for ; Thu, 13 Jan 2022 22:00:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4F9F6B0072; Thu, 13 Jan 2022 17:00:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFDDC6B0073; Thu, 13 Jan 2022 17:00:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC5756B0074; Thu, 13 Jan 2022 17:00:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay033.a.hostedemail.com [64.99.140.33]) by kanga.kvack.org (Postfix) with ESMTP id C08576B0072 for ; Thu, 13 Jan 2022 17:00:20 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 64BE92162F for ; Thu, 13 Jan 2022 22:00:20 +0000 (UTC) X-FDA: 79026633000.02.1E4F2BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id ECE0D140041 for ; Thu, 13 Jan 2022 22:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642111217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iYMosw5qYefWLA9YPdhAGhJH1W9UqqKjH99qcPpNMYc=; b=PCXlZgqWbM6Ss5FDmEZLq5+deYDjBe1spLV44g5tm0EyigO1HwMsVXznPAY0iLs1vdh2C8 mpZc1jiIMVcxHPEGEnzZawjP/m9evS38xi8XCI8WIzX23Ih84wVGHAPwpBpqckluHkZzUm RFQj86RhFz/bT0l1FI5w7V+2jkMfB9w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-56-w9wVhzADN9q-FApepbjLOg-1; Thu, 13 Jan 2022 17:00:14 -0500 X-MC-Unique: w9wVhzADN9q-FApepbjLOg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 305738042E0; Thu, 13 Jan 2022 22:00:12 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1ABD35BE37; Thu, 13 Jan 2022 22:00:08 +0000 (UTC) From: Florian Weimer To: Andy Lutomirski Cc: linux-arch@vger.kernel.org, Linux API , linux-x86_64@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, the arch/x86 maintainers , musl@lists.openwall.com, libc-alpha@sourceware.org, linux-kernel@vger.kernel.org, Dave Hansen , Kees Cook , Andrei Vagin Subject: Re: [PATCH v3 2/3] selftests/x86/Makefile: Support per-target $(LIBS) configuration References: <3a1c8280967b491bf6917a18fbff6c9b52e8df24.1641398395.git.fweimer@redhat.com> <54ae0e1f8928160c1c4120263ea21c8133aa3ec4.1641398395.git.fweimer@redhat.com> <034075bd-aac5-9b97-6d09-02d9dd658a0b@kernel.org> Date: Thu, 13 Jan 2022 23:00:07 +0100 In-Reply-To: <034075bd-aac5-9b97-6d09-02d9dd658a0b@kernel.org> (Andy Lutomirski's message of "Thu, 13 Jan 2022 13:31:58 -0800") Message-ID: <87lezjxpnc.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Rspamd-Queue-Id: ECE0D140041 X-Stat-Signature: 8o13b6nw78gjashw43g57c9xnkyyfoft Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PCXlZgqW; spf=none (imf23.hostedemail.com: domain of fweimer@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=fweimer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-HE-Tag: 1642111217-164601 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Andy Lutomirski: > On 1/5/22 08:03, Florian Weimer wrote: >> And avoid compiling PCHs by accident. >> > > The patch seems fine, but I can't make heads or tails of the > $SUBJECT. Can you help me? What about this? selftests/x86/Makefile: Set linked libraries using $(LIBS) I guess that it's possible to use make features to set this per target isn't important. Thanks, Florian >> Signed-off-by: Florian Weimer >> --- >> v3: Patch split out. >> tools/testing/selftests/x86/Makefile | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> diff --git a/tools/testing/selftests/x86/Makefile >> b/tools/testing/selftests/x86/Makefile >> index 8a1f62ab3c8e..0993d12f2c38 100644 >> --- a/tools/testing/selftests/x86/Makefile >> +++ b/tools/testing/selftests/x86/Makefile >> @@ -72,10 +72,12 @@ all_64: $(BINARIES_64) >> EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) >> $(BINARIES_32): $(OUTPUT)/%_32: %.c helpers.h >> - $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl -lm >> + $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $(filter-out %.h, $^) \ >> + $(or $(LIBS), -lrt -ldl -lm) >> $(BINARIES_64): $(OUTPUT)/%_64: %.c helpers.h >> - $(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl >> + $(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $(filter-out %.h, $^) \ >> + $(or $(LIBS), -lrt -ldl -lm) >> # x86_64 users should be encouraged to install 32-bit libraries >> ifeq ($(CAN_BUILD_I386)$(CAN_BUILD_X86_64),01)