From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6132AC433F5 for ; Tue, 15 Mar 2022 09:19:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1BFB8D0002; Tue, 15 Mar 2022 05:19:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACBDD8D0001; Tue, 15 Mar 2022 05:19:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B9F68D0002; Tue, 15 Mar 2022 05:19:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 8BCDB8D0001 for ; Tue, 15 Mar 2022 05:19:35 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 36D378249980 for ; Tue, 15 Mar 2022 09:19:35 +0000 (UTC) X-FDA: 79246072710.22.8366D17 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf07.hostedemail.com (Postfix) with ESMTP id 3ED404000B for ; Tue, 15 Mar 2022 09:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647335974; x=1678871974; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=46zrfiN9MIVTyj5zc/5rHeZmNQw0cmaObFmdxkGALgs=; b=OSTJIiHsQryp82PUefxW0JSnqpvJpzr7le6zewOB0WUUVnIQzJwKuXSQ ZSU8rp3lqLIGu5FEnPfRdycTCeEyr9+/Ozr7vuV69BZbosdmZC10FyJv4 VpaHkTnyJpKDrA3YfWDRTg2FDSbm8xGEmi2ChaB98jNlTFsY5sTNXt+P0 O8Yy5gxMosJSYpdPv+rYpOH4tnDlDK7Nb5mGRRRxWs8hqg6KOnnwmHUCO yeZSpjdM7bdvInzRnQZ2RD0fC3OwrCBXnjQKdHolSghO2IIwi/dilZ9RA Bm3LGu9CzCoqS9YN7B0fCrzJnWwSaihQRu+zFyF8LCewYjtpQ228Wfp36 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="281022913" X-IronPort-AV: E=Sophos;i="5.90,182,1643702400"; d="scan'208";a="281022913" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 02:19:33 -0700 X-IronPort-AV: E=Sophos;i="5.90,182,1643702400"; d="scan'208";a="540356304" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 02:19:30 -0700 From: "Huang, Ying" To: Oscar Salvador Cc: Andrew Morton , Dave Hansen , Abhishek Goel , Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm: Only re-generate demotion targets when a numa node changes its N_CPU state References: <20220314150945.12694-1-osalvador@suse.de> <87pmmn3eh6.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Tue, 15 Mar 2022 17:19:28 +0800 In-Reply-To: (Oscar Salvador's message of "Tue, 15 Mar 2022 09:32:42 +0100") Message-ID: <87lexb1skf.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3ED404000B X-Stat-Signature: hcgwyn7pnc9cigc3yjznad7rwfrbbfaz Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OSTJIiHs; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf07.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=ying.huang@intel.com X-Rspam-User: X-HE-Tag: 1647335974-739133 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Oscar Salvador writes: > On Tue, Mar 15, 2022 at 02:40:53PM +0800, Huang, Ying wrote: >> Oscar Salvador writes: >> CPUHP_MM_DEMOTION_DEAD and CPUHP_AP_MM_DEMOTION_ONLINE needs to be >> deleted from include/linux/cpuhotplug.h too. > > Hi Huang Ying, > > Right. > > Andrew, can you apply this on top? Thanks > > diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h > index 411a428ace4d..8a9a2d01b7c6 100644 > --- a/include/linux/cpuhotplug.h > +++ b/include/linux/cpuhotplug.h > @@ -72,8 +72,6 @@ enum cpuhp_state { > CPUHP_SLUB_DEAD, > CPUHP_DEBUG_OBJ_DEAD, > CPUHP_MM_WRITEBACK_DEAD, > - /* Must be after CPUHP_MM_VMSTAT_DEAD */ > - CPUHP_MM_DEMOTION_DEAD, > CPUHP_MM_VMSTAT_DEAD, > CPUHP_SOFTIRQ_DEAD, > CPUHP_NET_MVNETA_DEAD, > @@ -244,8 +242,6 @@ enum cpuhp_state { > CPUHP_AP_BASE_CACHEINFO_ONLINE, > CPUHP_AP_ONLINE_DYN, > CPUHP_AP_ONLINE_DYN_END = CPUHP_AP_ONLINE_DYN + 30, > - /* Must be after CPUHP_AP_ONLINE_DYN for node_states[N_CPU] update */ > - CPUHP_AP_MM_DEMOTION_ONLINE, > CPUHP_AP_X86_HPET_ONLINE, > CPUHP_AP_X86_KVM_CLK_ONLINE, > CPUHP_AP_ACTIVE, > > Huang Ying, it would be great to have your Reviewed-by/Acked-by if you > are ok with the outome. Sure. Reviewed-by: "Huang, Ying" Best Regards, Huang, Ying