From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A98F4C4708E for ; Wed, 4 Jan 2023 00:35:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F327A8E0003; Tue, 3 Jan 2023 19:35:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE2FF8E0001; Tue, 3 Jan 2023 19:35:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD1518E0003; Tue, 3 Jan 2023 19:35:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CE6588E0001 for ; Tue, 3 Jan 2023 19:35:46 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A782A120705 for ; Wed, 4 Jan 2023 00:35:46 +0000 (UTC) X-FDA: 80315248692.06.012ABE4 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf09.hostedemail.com (Postfix) with ESMTP id D3F6114000E for ; Wed, 4 Jan 2023 00:35:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CVVqQptN; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672792545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tv8v1CqsJDSoZXAJmQkD+0YN0tEa1CBTjK7PdW1biys=; b=0vMJLX4UZKeQXX7FlhM7yXoP9GjFhLn6y1JlOtUQTbx3H1yhIr3Km8IPMqv/TAWD8Q16zk 3Y2BBTs34Ov6YRP9Y/Ep1wAxanAhKTJ6pYc1aQwXjoGFFuJXU99wFRUEGon9uoGStnZTDQ L1W/ovCQ5X6fsTwtjV22QBW/Umy1+mo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CVVqQptN; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672792545; a=rsa-sha256; cv=none; b=W6tQKJZjV2NdTF6d7S37052ZJrimH3tuRhffMlNrM+qXQjEri+bh7rDkHjSsLP8Rfuj7al 61UW2D90p3X38C064mTBXi0Fp+8Yqtsk1o/QmaVckdBjGVw2j7+MrHhJ/1lw/hqhFlDjxc qbgZMmf9+D3A8j3gpclXcbCtWjTk6JI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672792544; x=1704328544; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=AQQCUoBmBnV6RpnznP0zSFHaXETOQbD7b9hAWbdNjfc=; b=CVVqQptN55IawcZDaw6qcKDq9Qqn18gM23ca68LmYPI4L49L6K9+OL6q 1d/7hRjIg3Po9M+I/gpakw445uWFc/REvgkQCL3EQ0zHt/NgI0GCvoxdC 3e7sjZbT+IrQ6Zf1HubDVZBoNl+reRwz6f1clMguT2rYVKGWmkRnRjy04 GAh98da6MovEcKqExDFyGEa0IfrTTc6eZxP31VS6ajgaP1/y6Tkrp3xFq RwXagAEoA1NcuVORGaL8om694BERhJ1tLsKWs0bjORXXSg43M8TOJIxnl JaGMOyYQP+gQKpWo/JPyWHqsAMR1cIuIEH10COO/Xx9hgMiL+8EyWRaW7 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="302168918" X-IronPort-AV: E=Sophos;i="5.96,297,1665471600"; d="scan'208";a="302168918" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2023 16:35:43 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="743668051" X-IronPort-AV: E=Sophos;i="5.96,297,1665471600"; d="scan'208";a="743668051" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2023 16:35:40 -0800 From: "Huang, Ying" To: Zi Yan Cc: Andrew Morton , , , Yang Shi , Baolin Wang , Oscar Salvador , "Matthew Wilcox" , Bharata B Rao , "Alistair Popple" , haoxin Subject: Re: [PATCH 5/8] migrate_pages: batch _unmap and _move References: <20221227002859.27740-1-ying.huang@intel.com> <20221227002859.27740-6-ying.huang@intel.com> <05A09BF6-A30C-45A5-952D-0CCFC43FE2D7@nvidia.com> Date: Wed, 04 Jan 2023 08:34:46 +0800 In-Reply-To: <05A09BF6-A30C-45A5-952D-0CCFC43FE2D7@nvidia.com> (Zi Yan's message of "Tue, 03 Jan 2023 14:01:37 -0500") Message-ID: <87lemjnnmh.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: D3F6114000E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: m8g5pxgittn7ch1gp9sokek1k83c59j9 X-HE-Tag: 1672792544-851840 X-HE-Meta: U2FsdGVkX1/uL6CFbPg8+99xT0NBgx+XIWMSrKjuMnDnHusnretI/jbM4IQEBbrEaXV5rsBWDtzRpJcfaHLGLW8AV5MkX7kPF3joeN7QuEb8vnzcLIBb6XNleAhpS84tr8ShK8fGoim0f48FT5Kei4z9cTabfsRDjbD9JAmeUxcMcE1WxpXYfO48YzfVpR02VBuV8BOEKcXnpFjlzwcF1CBxRm51nT1lWgzfh6VooqXMUkRFY0zYJUXCetWfAacnlbPJ6pN6KB8KmR5ZrHT3MgeupU673sMy+WE5uFajyZULB5g08K5FcGOJukzSfyTLWaG1Bk8L9uRzItbWWlj1RLLA++RfMFcOQmqm1pTUgWzw1+BmEsR8nHxeZMVyQ5xFPv5quB082/KSTXAklYjcf0h4HavC8nhjoQaZU7F+iqF2PVJd9ssISTYXg67IpQFa+I18Wm/mkFibvx0Lc3/y6Fy8w8faQq9ae7OLUeXUsGK13mzRwlyfwzHlEWljCgE4vXqqIPfp4rrgcz2/IBGMVwVWR0YEfiXD2JJAFAyYjHyOF3CabiPp+kYPedwyGQs1/ZUpNgllm0ozNZ57WwdLLGNM/ecAzHUZj0qyDdRQbESq1/dYDEwoiBV5ArjoWlqjXjt9G75Msppl/eFV0RYPgumiMVG4NfW8mFBfzkXOCaxDhkVCE5LCLLzWt1RTK393EO9sIMjqt7kKAvMUUV+Wr/djyxL6qm2xMui7Fjr/Gve4zZ0qhWNPCIV+4JAxkKVAGqTLgMdZGgDnZ6RBxGh2AbQnx1HJ4BIyCPtrk49fcd1Ud4/nkZhIObyb0KZEwBJTkqGQNJ66+kotE33Lij+GvYSemXSXju29ryUtY5+0s0vuxlcY2lPy5Qs2CJb+U1DBnVRHdSk42jRI+BZuJTABgWnPKYck+QUf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Zi Yan writes: > On 26 Dec 2022, at 19:28, Huang Ying wrote: > >> In this patch the _unmap and _move stage of the folio migration is >> batched. That for, previously, it is, >> >> for each folio >> _unmap() >> _move() >> >> Now, it is, >> >> for each folio >> _unmap() >> for each folio >> _move() > > Also worth adding some notes here, we need extra code to undo the _unmap() > if _move() fails. Andrew has asked for comments on *_undo_src/dst(), > but I think it would be better to provide a high level new workflow, > in the form of pseudo code, in git log and the comment for migrate_pages(). > The extra cleanup code for a failed _move() with a previously successful > _unmap() might not be obvious to everyone. Here, I removed the detailed error processing to make it easier to understand the basic flow changing. So, I would rather to keep the pseudo code here as simple as possible and keep the detailed flow in the diff below. Best Regards, Huang, Ying >> >> Based on this, we can batch the TLB flushing and use some hardware >> accelerator to copy folios between batched _unmap and batched _move >> stages. >> [snip]