From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D60C636CD for ; Tue, 31 Jan 2023 07:28:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97AC76B0073; Tue, 31 Jan 2023 02:28:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92AED6B0074; Tue, 31 Jan 2023 02:28:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F2B16B0075; Tue, 31 Jan 2023 02:28:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7140C6B0073 for ; Tue, 31 Jan 2023 02:28:41 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4D1961604A2 for ; Tue, 31 Jan 2023 07:28:41 +0000 (UTC) X-FDA: 80414266842.11.6F8461A Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf06.hostedemail.com (Postfix) with ESMTP id 1DC7A180009 for ; Tue, 31 Jan 2023 07:28:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fOPYnvbM; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675150119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GF4ehgVAU2atc7QXhohnV3suV7zZwsGON0Ef9mDcV6A=; b=B35kHQE3jWTOo6LzivhCi3afuuEmCQ0KiViFmePv6sp+iCQDRGPE9a9Jde7JslJZv4QIpx zhuXx9WHkp+JpQOGoMkSBKce8AdzloPeAbgzqu1gD3h9r6OVjqDrBmHCcMbPEQYrx7k5BG Hz4mMzteLgZ72TpX66vdFkr44nkxtPM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fOPYnvbM; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675150119; a=rsa-sha256; cv=none; b=bJCSXlarHinv/HTRk7lrD45u/M/tylid/7Z7ZY256HVTbi7PIEG15KJYJqwuN0PQG+IxRR enh44QzLlELy0UnrQ7shMWfdUA6MwtfVlpYlWc76TwD+LjyL2Wss/VjzR57HZHeJdPdkKW /zTPpilc9Kz0+f3UTsRIIoCctM97Wng= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675150119; x=1706686119; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=/ZmJJuA60MRhmaDJdcoSBVZcQNooClU+3svm7Np3S0s=; b=fOPYnvbMojpJ+SKTK4w9Py6IFQyAMxXjwOxRzlQvUs0Vvj0rEbZoKWyr 2y5oWJGKSsrBzliwEPcbOyGztQlgu6NMEhInK2I11gpqIRghP+SAcwgK0 YPaDzc+U947/X3VGbv5ZmcLu5xAol+wCmu3l4edJcvgbetY1lXA4v2ylB l30dytkpYMeTlycRLNf7EKpF3yExaTh53Tr/CgYsfBUClxmSZ3rhKQP7R VSOEdo4jgBiiSPwhh1gq0IC+ilpRDHWA/DAB5jHWK5Ac2hpAKC1+whWi8 i31I6uYJM1nosPK1/n6AXotl1tnmOo5iSrnLiKfi6oKPNbC5wHlKvIasr w==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="326435024" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="326435024" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 23:28:36 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="993169017" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="993169017" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 23:28:34 -0800 From: "Huang, Ying" To: Longlong Xia Cc: , , , , , Subject: Re: [PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages() References: <87wn54c1fi.fsf@yhuang6-desk2.ccr.corp.intel.com> <20230131071035.1085968-1-xialonglong1@huawei.com> Date: Tue, 31 Jan 2023 15:27:44 +0800 In-Reply-To: <20230131071035.1085968-1-xialonglong1@huawei.com> (Longlong Xia's message of "Tue, 31 Jan 2023 07:10:35 +0000") Message-ID: <87leljrwnj.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 1DC7A180009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: hqxswk1oz4cai91fpwcprswk8i3z8xnp X-HE-Tag: 1675150118-187227 X-HE-Meta: U2FsdGVkX18Sm1Z2FwLXI4kwWzQiy2esehZwQzf6Wm9JUHzvnz82O+35i3PXf8CszMeIy14iHP24tDmEfHk5kLGr0UI5+5mjfJIyjryZkg49VmfRZ9DRbC5jfJzTu0IZGBi/q8c0Pk+oYy6iOEL3LMbqce4bNtngm0wZBta1/V/cUGnSrYj6nQfFjQPSOLco4mxS67797PQ3gjeybmE6z9udW87qTq/cp2X7MjGI7zMAQMC1Y4FB8O5GaYfeCpqwZnN8RkUPehWtgjyrxmf3kZe8un5fuqnIuQmBflTl4nsZNWAaGJMtO6kQ17ML45bvgWgQEnDk8h5ZjFBdQcDPCqQzqiOr1/jMGq57lwWiGCeVWb3q1ISP7IbuUL0nXcONG5zL2zZ3eT3yk9DkTsSKiTXo6n5gMzpGxZOyPJvJVgArOirX4xf6lRJ2FrUjuApZ8S/B4R4D3Dug3YjjJf2X59vKneFvGpRz+sKkGxLZTt+hgsPvXEOfOdB1eBkUS8dFn7JPPAT7Q2OjoerVxHOrx3/BvZYBmKIqVpEBwo5ySxie+QFG+6LiKafVfseB2GWy/E3RI/c8klLAnmonFtAFANN0oBlncDxOXRNnF0ajOvUQW96E3gi/BVrG8BhlB2fF2b3oq2nfR+cbDqA/xH9mz15hXeacttZekvnXkubM0Hksx9yLKxvrsusJBRIkzHpjO0V97hLW75P5G7mT4QV3R+QZHua65Vn5ZAXor2bsZXg72UPMyG9Gb3CBsMWLoww7FOdCEiNHGdcGmXsLf13ILG56kK/w2RBi4iFvjfqhsoDPBfPGG1sD+TI8S4NwOJTRAO+llErKIX7sPi53F6TOTASTlpOVAdWjl8KxnCva/tVRmcPNYhS94Vf6utEBWzsvcrDNovY87CiSPWNqULTA/aymeWMn0JqFvZ9nDQfFJe7e8afSsGmV6xgRJuv2299AojyMTEfVVqk4WzUCVea R2KuzpD6 cmOHLwUrgA/laQkjZgIAaoEBuC1lgBWE5F6F+cG5PzPlIsoxNDNlIioIf5cYA2hzObb652YMHZW1OBOlktpMdhV1k8/x/DPT0C5unxXGPNW/ss0gyttOoYhk9Vwg4SRevqBDifYgw0GCVFzZuixppXnfiVjKRfamlj6NNVB9JaMCJHcn4kV9DX1iqDbT0QWbMidmWFCPk77NhOznwRB+RuZm8aeu1P4RN34UQwm5IGvdTDK0U8x5HHP03cpypJFfCKOBa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Longlong Xia writes: > It's known that get_swap_pages() may fail to find available space > under some extreme case, but pr_debug() provides useless information. > Let's remove it. > > Signed-off-by: Longlong Xia Thanks! Reviewed-by: "Huang, Ying" > --- > mm/swapfile.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 6202a6668a63..99143875d6f0 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1098,8 +1098,6 @@ int get_swap_pages(int n_goal, swp_entry_t swp_entries[], int entry_size) > spin_unlock(&si->lock); > if (n_ret || size == SWAPFILE_CLUSTER) > goto check_out; > - pr_debug("scan_swap_map of si %d failed to find offset\n", > - si->type); > cond_resched(); > > spin_lock(&swap_avail_lock);