From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C51DEB64DD for ; Sun, 25 Jun 2023 02:34:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D19308D0002; Sat, 24 Jun 2023 22:34:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC9618D0001; Sat, 24 Jun 2023 22:34:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B90E48D0002; Sat, 24 Jun 2023 22:34:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A77DD8D0001 for ; Sat, 24 Jun 2023 22:34:39 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 78FC780750 for ; Sun, 25 Jun 2023 02:34:39 +0000 (UTC) X-FDA: 80939701878.10.6ED3C36 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf21.hostedemail.com (Postfix) with ESMTP id E32A51C0014 for ; Sun, 25 Jun 2023 02:34:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Fsblecqq; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687660476; a=rsa-sha256; cv=none; b=ZaNc7a9ONXMuzPuuTGr987MCNdWm9oYV4zwvW5GbGCU0wAbLSnuyLXJYRsoFcwMYLHaE5Z ZUcVP8nfpSZtw3IDwe+Sc1w1QSGepQxUDWVT3KBX2PSmR6cGOvzufh3HFDtFas+WEfbD/p l9RMpFSpX9Y5FhJMYf1m4jrI6FaXKK0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Fsblecqq; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687660476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qPIxEt+kk0HlvxpDoBJFzRj7FMDV3qfQbS/bduNeqDI=; b=pdjeIapm0xTuOSuGhCXfFPQ7J2fZkvjyJMjlwhJri+fMG7JZZhU2DuPZVgXEqD8Rof1d5v BpoNcBHaPjYJnb3rWcBcq8pwvmvbBQNUc1O0TYNjUk8HT/0KnU8xrfAy9Gr5nWDxTSeReI xJQf7Wes7BdY6a09a/NWlLmwtU/rmR8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687660476; x=1719196476; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=FBCY4OxzLlEFK9Pjzk6FhGgxr9EDjNsRJK4vH72YXKQ=; b=Fsblecqq792MZYVoPUfdfuFutJFYspsjF+/mhYDUztFe4UJ3vuUjMuiG VFmqs9y4cjhtQlr9dfimWxdwjjEAsx0Ig4rKLsA7HnRKLhzI8Qik7cZ9N jIy6OViLpdRVZg/iG7o1ScTFWib+KPtvsiIKM86lNhuGQnFLUOJ47UoTF LswrdSXHWUVMTAibPqJil0MxEevnBf+22jEz4ExA/U4EJ/hs6eROFd7Bv BHpG4fma03AnT16h5zh3BxEsm/vVUOCtJ1+9SLDkmdcLiAqHgcdpLadPH /SY4hc/wtgUA4G4EhDS61IzXrPGRtdrRZQTP0UcrfokfIqsaJqO3vOeEX A==; X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="364459424" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="364459424" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2023 19:34:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="745386194" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="745386194" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2023 19:34:32 -0700 From: "Huang, Ying" To: liuq Cc: , , Subject: Re: [PATCH v4] mm/page_alloc: fix min_free_kbytes calculation regarding ZONE_MOVABLE References: <37d8c6c3-0dd1-94b1-19cd-4743968b0fce@chinatelecom.cn> Date: Sun, 25 Jun 2023 10:33:02 +0800 In-Reply-To: <37d8c6c3-0dd1-94b1-19cd-4743968b0fce@chinatelecom.cn> (liuq's message of "Wed, 21 Jun 2023 21:48:01 +0800") Message-ID: <87leg86zkx.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E32A51C0014 X-Stat-Signature: qwqngwkpn9ciuoozf5rmq8qp81nbb67q X-HE-Tag: 1687660475-122974 X-HE-Meta: U2FsdGVkX1/aKI0sTKeyg71LFzS2RbSm5emkv+mj0HNSM/umwG/P6xZDahF3qFEuTSS3bKEg1Er+DZUajdjKmOi6tsP55KD3fQl/J8H7iZnmeQCgwwYKZaJPhG+q3zvPjmmkUozDAFT2y6LEi2v3+kE0dFWI2uErijA0j3JVbOHij/wBrFAqG3hoPIzOi0nDluCyk3ES4Po0LsuV9rB7nuT1JbYRPy9eUPCKYhCauLtM1jWAG4Wmcu68aAW1iGv0BgyhJu0/LOFYjZ9lTmDiiLruCTCeyEh9KstK9Tc0XKXR5P/WkFuptQsfdE7t0em5p+Ufp8SeuwJZlpmMd7MlvJSauT491sL+EopAYUk6zzW1lQGsRgbhmTasdPNErpFZeMBziH7uJyu/iIjhG2vra5CcCXr1IFme64gJvh2WsggegY0gQ8ofuAY/24WvuqSTOAAz3usDKkLKLW6M4j+ggklVfO91zjdfnZXsIC34/mc5IRW9MLw9zLHUOV78E02DdwxtAMwGdqGSJJeNNslYLR5BiGUBnk+KLaWtW2phJ2g+zqGgVmrRh/6tyL8rDVFpXk/kHGYT+1yMBSoyrYiv9YTozREBJkcBKfSSXY6OQDR4hO6Keb48TOFlJTB/075c7LFb/LzESipFYdRd9XXjuAzByU6nByIKNVPBG/LqmPjGwAQc3YaxNw+K18vyycByBNmZBQRr1fdz5Vo9/3iIkvF1WYr/au2jmSpQBnltfetxhuKxS1bshWHGMOnO2sHHwOBfIDlCap5nObCzgrzUFjVcizBYnpKbrV7XUUqaFkVQOzjRngetfegKnxNiO/Bc8rJP9+gW7N6Te5cfl/e9+QLUiF+Fdo5EOL/a2QiTXl/S5KqF9COyfvyA7C3kxP/WGxEV0y2NcaER57BSuyoEgHTB8u/fThO4+HRIFKEuYJfsz/dKmAf8BpoBMc/IhsCK2Zb+hEnQiMoT69r3XDC sAvvzi3z gdl1tAGY2nyqu5BZrLOQRy4yfmDDCh/K8x47PWXwj6y0Nl9jKVFo4oNdizkjX8wtBfy8RDzVkVcK4gxDj0vxinqx0/gpZ7RXDVLeoG55ANWU5FpZh2pvUOUGZUGq3dHQWkD8D9hWAhZ4Vabxce6iKmxzAL2cwuHxftfy3zE+deQEP8BPIswJaW4aSBDyllBPByT4M3QHOkpF5ehIgvk54R8/nBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: liuq writes: > The current calculation of min_free_kbytes only uses ZONE_DMA and > ZONE_NORMAL pages,but the ZONE_MOVABLE zone->_watermark[WMARK_MIN] > will also divide part of min_free_kbytes.This will cause the min > watermark of ZONE_NORMAL to be too small in the presence of ZONE_MOVEABLE. > > __GFP_HIGH and PF_MEMALLOC allocations usually don't need movable > zone pages, so just like ZONE_HIGHMEM, cap pages_min to a small > value in __setup_per_zone_wmarks. ~~~~~~~~~~~~~~~~~~~~~~~ Better to add () in function name to make it easier to understand. That is, "__setup_per_zone_wmarks()". Otherwise looks good to me. Reviewed-by: "Huang, Ying" > > On my testing machine with 16GB of memory (transparent hugepage is > turned off by default, and movablecore=12G is configured) > The following is a comparative test data of watermark_min > > no patch add patch > ZONE_DMA 1 8 > ZONE_DMA32 151 709 > ZONE_NORMAL 233 1113 > ZONE_MOVABLE 1434 128 > min_free_kbytes 7288 7326 > > Signed-off-by: liuq > --- > mm/page_alloc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 47421bedc12b..590ed8725e09 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6362,9 +6362,9 @@ static void __setup_per_zone_wmarks(void) > struct zone *zone; > unsigned long flags; > > - /* Calculate total number of !ZONE_HIGHMEM pages */ > + /* Calculate total number of !ZONE_HIGHMEM and !ZONE_MOVABLE pages */ > for_each_zone(zone) { > - if (!is_highmem(zone)) > + if (!is_highmem(zone) && zone_idx(zone) != ZONE_MOVABLE) > lowmem_pages += zone_managed_pages(zone); > } > > @@ -6374,15 +6374,15 @@ static void __setup_per_zone_wmarks(void) > spin_lock_irqsave(&zone->lock, flags); > tmp = (u64)pages_min * zone_managed_pages(zone); > do_div(tmp, lowmem_pages); > - if (is_highmem(zone)) { > + if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { > /* > * __GFP_HIGH and PF_MEMALLOC allocations usually don't > - * need highmem pages, so cap pages_min to a small > - * value here. > + * need highmem and movable zones pages, so cap pages_min > + * to a small value here. > * > * The WMARK_HIGH-WMARK_LOW and (WMARK_LOW-WMARK_MIN) > * deltas control async page reclaim, and so should > - * not be capped for highmem. > + * not be capped for highmem and movable zones. > */ > unsigned long min_pages; > > -- 2.27.0