From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797CDC4332F for ; Wed, 8 Nov 2023 17:10:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E921380023; Wed, 8 Nov 2023 12:10:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E40D98D0073; Wed, 8 Nov 2023 12:10:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE15980023; Wed, 8 Nov 2023 12:10:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BCC778D0073 for ; Wed, 8 Nov 2023 12:10:23 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 94933B5DB8 for ; Wed, 8 Nov 2023 17:10:23 +0000 (UTC) X-FDA: 81435425526.27.9AD846B Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by imf18.hostedemail.com (Postfix) with ESMTP id 6C9951C0022 for ; Wed, 8 Nov 2023 17:10:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=eUWrxueE; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="NKn3/MIM"; dmarc=none; spf=pass (imf18.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.27 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699463420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Q6Rk+qzMpMI23pOp3I8TlmgYyCmchkLsFD/CkDi2mw=; b=sW46z3kj9BvhPMFGH0fP97ltj9wA23/eo+aPzJBMccM/cNtldlsepHPLpcovXw3AjI7vjx zrHG/SXQNOF7kk+Pmd9mDPCeDGMxIclOaiTiWR99gy4W0Y3AbEWkjHOJYU27c5I6GjIuW7 Dhu85JzTqy6WujNW+n9xKeWVf24ivWc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=eUWrxueE; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="NKn3/MIM"; dmarc=none; spf=pass (imf18.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.27 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699463420; a=rsa-sha256; cv=none; b=J7Wzs1c8wEu9AK+uD+xCRVX9Xb6aJreH7m22B4fafUTVzlsrSFudrFiTBIQSWTt8chyL5t ef1jZTClFpadKOgZe2OaQicBK75tRa1J70HZGo9OpXALAslP5zG4m2gR+QgeGrS6IY7lry xjPPJM7gdNlTJdXfkqtWkg1PUcR9ySM= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 273B45C01B6; Wed, 8 Nov 2023 12:10:18 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 08 Nov 2023 12:10:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1699463418; x=1699549818; bh=5Q 6Rk+qzMpMI23pOp3I8TlmgYyCmchkLsFD/CkDi2mw=; b=eUWrxueEssiCj+bvgf Sq643QOe3X6h42kIJc2C4ZR4tm4w3mOdG8mMOOrmOgg0M9yYXlhsfKxDkCNkqCCG BgOwi8kOtWhJvTJkklO6nDjZNnLpGJinks5lcfiGObfANptCTPVE0woOqtneT3uJ 9U2DdjeQAOnKqKFIXNDdnFKImsdzIKXrz2xrUxh9Sf0wRj4pqTquFzfj84JdnNrC enHU1i72+MY2mDPjMpLNJt3BloxtRY1Xnwh0859u2X49iID79qpBoQk95E+FWBEO o53Ayv8FbA2H/j19polIQxiFBiw/8ogVIXTrD+e3IrI5e2SzZLXZn1SaqPiqhrpT 6MrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1699463418; x=1699549818; bh=5Q6Rk+qzMpMI2 3pOp3I8TlmgYyCmchkLsFD/CkDi2mw=; b=NKn3/MIMQ3Rnjm54WfE83DqAwKBK2 hplEw1Zsln9YKY/ZWiSFy0CcN0wh9u4YfTXhg7bxgUnyy50JS7YbOxEVCX27W66v 2DtcCXXIx/TdFs1ZOnaeUX9v198NlEGUphmLT7rMmetAI1i3kloyh43awROxkFsc nOlpqSo1gyzWl7adDulrFFLP2IuiYIVdFeFvS6bt64abESHd5mAokFox4AXEU7S3 mqwJhKdGi0s23L8rILgDQvL3uSHzrq7JtKeVv0UqB6ZCVp062S/uoO4N6UC1kqp0 DsH52V3khxQn8DPs9PExDYToZxG8sVdsicOUYEQPmI/j5mmKLiI2ZgDNQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvfevufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpefuthgvfhgrnhcutfhovghstghhuceoshhhrhesuggvvhhk vghrnhgvlhdrihhoqeenucggtffrrghtthgvrhhnpeevlefggffhheduiedtheejveehtd fhtedvhfeludetvdegieekgeeggfdugeeutdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Nov 2023 12:10:14 -0500 (EST) References: <20231107181805.4188397-1-shr@devkernel.io> User-agent: mu4e 1.10.3; emacs 29.1 From: Stefan Roesch To: Matthew Wilcox Cc: kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mm: Fix for negative counter: nr_file_hugepages Date: Wed, 08 Nov 2023 09:09:55 -0800 In-reply-to: Message-ID: <87leb8npcd.fsf@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6C9951C0022 X-Stat-Signature: 1x1bpicgug1rkn7sxm3bi14ri6ruyadb X-Rspam-User: X-HE-Tag: 1699463420-729201 X-HE-Meta: U2FsdGVkX18Ct5Q+YX6mrVaD7MDIqqxrsBGJjKzlx6KQFBtzEvDqoPxi3Lxz37uLctaDgUgxQvNbf93ovs8O4nVBe6l+RqYjXUtFSId+hpIBBaNhbI35me6j0kJWBPPdnVzE+9JsaS1fDqLP+62gk6JQW70zUHpLrMihrMvlnmIQl1kw8QuFZO5C/1qQoB50Qd9r8sQk3vfQPa6a8vDszLyAGVyVXP4cFI4RpUsOXg/IDUKpXHfn6y9lkj5f1wLPpOhPxil8AA8ZTKKOmS/qfcJVzaqa2itbWe0HDi5MJdUY+KAR+7VS/r7kQ151qJhtwhZkEcaTVra12jt09ERDAPnfMMl/uUDwsDun4WjTZnwvVQHOz5fQv14okRL/mhmzaNFxbXnR+N560lPplPpYhyo2IIG14YfnIPuGC4/vkAJ3QX4XkBFd8I5CXffL8z7BxdjSB9iFYoj8jmN639WAkFDDTUHAZT4a7ADLMvTJCUIaFKDGoyPG73pCgcZzvNzq+YswtdWZ2Lv+GEWGQS6rHR1rVuz5NYwnCq/zpQpVL4xydEs9RmWefOEMAsysKd0BS2Zj1YgGsjA1RHARI7g9UAZ9TM1yZFh7leVM/NOlkGfWPL0MMboZ1YS1oMAHee9tq06P+KC9gPytogH+d2JVga5Lz28a46AFm/PQXn0TY0x0jHqYyk3fv5GzpoN2TLEQuh8DVnfKhArTyIJ2iPLKJrnTD4Zz0lUbdzE8hopRtW2w5rYeoKaaOMSB1wEV5JZhFdg59765A2YyNI65ZFU0kiDCiR/QqFmMoKPBHrokJUvhFqpGvpTsFqDJaCQokxU6uOEvPX9Iy9K93xSfW48xb6vbi82NJx6cUocbJR3hL0bC6xI5LUr2TrC8MkvR4zx+Oo/sZyw3MVrjFOIM1aC5OoEYOieQyJH8bQ7rivFWR1jJB/kCZfgvYYz/0K779z5PXRD4LbufVws2FwCewc1 SCpcjZKA CL5s81kgAFmyZN+KTIRM7fwIPrmHPN+MBBQACBQNP3aAhKoGSmtvJC1i4uh4rv+T8T92/ArA5rTbIWTWhXFaXNh+ukiC2L/Gl5uM/KL8dgE511IaxzBq8IOj4iK3GUp7xAdndpmEOv0SV6j8KqnA3BFWMiobGsHlROYLuseDO+BVp5LLb44ZOdahcDosN+CXLL2MLz7TUkpP3mbCArubLL42j+gPByQRJP+hrH0JTomwAPQQNMJAT0jBfYEFdd4yS+rbHJtOkmEmgpdM7QOT58mlFESooUSySWTAkWb2abt/lFFy/5ex3LhOVHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox writes: > On Tue, Nov 07, 2023 at 10:18:05AM -0800, Stefan Roesch wrote: >> +++ b/mm/huge_memory.c >> @@ -2740,7 +2740,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) >> if (folio_test_swapbacked(folio)) { >> __lruvec_stat_mod_folio(folio, NR_SHMEM_THPS, >> -nr); >> - } else { >> + } else if (folio_test_pmd_mappable(folio)) { >> __lruvec_stat_mod_folio(folio, NR_FILE_THPS, >> -nr); >> filemap_nr_thps_dec(mapping); > > As I said, we also need the folio_test_pmd_mappable() for swapbacked. > Not because there's currently a problem, but because we don't leave > landmines for other people to trip over in future! I'll add it in the next version.