From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60517C25B77 for ; Wed, 22 May 2024 07:18:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA1CF6B008C; Wed, 22 May 2024 03:18:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C50446B0092; Wed, 22 May 2024 03:18:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B17906B0093; Wed, 22 May 2024 03:18:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 93B966B008C for ; Wed, 22 May 2024 03:18:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0DBEB160117 for ; Wed, 22 May 2024 07:18:05 +0000 (UTC) X-FDA: 82145177730.22.4C6487D Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf19.hostedemail.com (Postfix) with ESMTP id 900DA1A0002 for ; Wed, 22 May 2024 07:18:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dNVHsBn2; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716362283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dipBx7/Eghd3ToBxdScRhudTQd+a55G4dg758eSwG1A=; b=inWtzQFGIglwkxFZu5h62KHH81VhkcZmxFK06gaHYaKebue14hclL9gZPflcYCVPlpTaeQ NJV4fYbOKs6gn2ypr7Da2zhLh4dzngFXJHame49fFCj7+uK7JhPwwX4klyqAmtaJk61x9D vhnPnuRHfywXDNd3Px9DBgV7d1yXxbk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716362283; a=rsa-sha256; cv=none; b=YeOdD+D7gfJXjpPeljvaJTSgEB+XTb5sG6CbohByUefxi6h9nyQz5h627zX5E1ayHtwLZb HT195+ffvKptDbiZADxvwxPcAiQCr1kYLF/SBbJV24tZLpdwATgDpqkXy2W5TsHOJdbrf7 zZ3UPS33/D5HSg98JT/8jtSv9hkZZ0M= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dNVHsBn2; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716362283; x=1747898283; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=r3l/ggpM98iN9cvyHo4cv5BChwmtMqwhd9kq2chKAZo=; b=dNVHsBn2tZ8xua7nDePo5yBvPgbqQ99E+y6Bvs8v4NVYUgdLENKqZ8BM fbsc2EaheqdPRRtzUojvYvI9daYz4QSub38Uy6itgsrlPtmiS9lEFVEvK By/CAeG35BsjqteCcoXgGdIxfPDkNLtkN46asLpql76upGUqxxVcLFIuc 3DzhF6O+t6ndke6mC1BXhkx1dTwhsYVbbwKa/vxMkdQOIehyF+p3EabLU Ggx3Cp8SOVTLPF38Z7Ji+YJO/r4LMlcdvdOz7pfObBPDbCRtTQruOIkkV vF7kpYoE4ZHqU60ZiKiZYnPOVyQ1z0G0LYGPbRpdBe/Z2inqFxv4fza6e g==; X-CSE-ConnectionGUID: UFO7fAivSA+gVlKlkqQEEg== X-CSE-MsgGUID: 6hDFm6RaSxu9odaW9G47Hw== X-IronPort-AV: E=McAfee;i="6600,9927,11079"; a="16423318" X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="16423318" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2024 00:18:01 -0700 X-CSE-ConnectionGUID: x4GNIGASR5GBST9anVjgAA== X-CSE-MsgGUID: H/fnTJoAQx+f85lBEKbvqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="33783486" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2024 00:17:57 -0700 From: "Huang, Ying" To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, , , , , , , , <21cnbao@gmail.com>, , , , , Subject: Re: [RFC PATCH 1/8] mm: fix shmem swapout statistic In-Reply-To: (Baolin Wang's message of "Tue, 21 May 2024 19:03:11 +0800") References: Date: Wed, 22 May 2024 15:16:05 +0800 Message-ID: <87le42b9l6.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: z964ho7e4ckns9gd16dog43n7u8uzp8i X-Rspamd-Queue-Id: 900DA1A0002 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1716362282-382526 X-HE-Meta: U2FsdGVkX18FMQvoo1Vb0Rn676RprguoQBfCHYhnuMRMWCRtj2IGGWYN4e/QHAT5aTQmwirX/OtxW0UQqQXiiTYVjAzlog3SYKDH3mN96aC92sBbv83AsfC9LgmN1x8cdJhbkeTK9B3BEMw4C4fU9KAeAS7mC374C+4HrvJauBstkUpTG8gvXzwegpZ2WLsFDKbo5d3MGOstaBy4cy8WdNZYbVh6qVipEjeobEX1z0tS0HS5M2UYjcLwvq2+7YSA+Q2tEyJ0pg2iYpOal2M2FVKB9BrJoZ25W/O+avJCRCn39ZUJFEX5467zcqXo9nYjSfRKUh1C+ZgELCDCJA5r6uUqhhvuqR1MhS7UCtzoLPYYBICQOPgwqRdJblfSYdEYG9eaLIR1aUEXwagB883kjnYLP2wEo8zfXAIZIMZZ9mKWGdNvzxl0RRQqjnKz30No8HHkvr3x227ZWhLcKsXkdXVX6e9ap3g0cquOh+K4M27G8JhSj++xdtDXHK+mSGVbD1xZkOFQX6ZUcOLu7dh4aVtIXGglZMXrl6/FGDq06qs7IQ1IiviZ7F5fL4dV4+WJzvZeGdHl8gmEXkHUXWUS4V/lT4KfscuGjyHRlBYyr5dS9+G/zho63jr1ejOd9c9qZ8MtHfHzM0IAmXgxvBHsGys0d0YIYahtN9CU5y3g7aWcnQQGUzNpLLcltMlsuulyV2QRvNgrW3yT7Ts8alm4RzeaxHmMiC1VH5qfEPNgAQpqo5p8BU6op1nFDpm830caCsI8NhPenrPM63yuhC73AoJzpMQgzqCvu9DbUZ34sbMYcO7I5rW/JE9S9FjOzHp8IcQPsotajtz5B4KtdrufgyvcUDpYrl4i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Baolin Wang writes: > As we know, shmem not only supports the sharing of anonymous pages, but also > the RAM-based temporary filesystem. Therefore, shmem swapouts should not be > marked as anonymous swapout statistics. Fix it by adding folio_test_anon(). > > Fixes: d0f048ac39f6 ("mm: add per-order mTHP anon_swpout and anon_swpout_fallback counters") > Signed-off-by: Baolin Wang > --- > mm/page_io.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index 46c603dddf04..b181b81f39e3 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -217,7 +217,9 @@ static inline void count_swpout_vm_event(struct folio *folio) > count_memcg_folio_events(folio, THP_SWPOUT, 1); > count_vm_event(THP_SWPOUT); > } > - count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPOUT); > + > + if (folio_test_anon(folio)) > + count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPOUT); Do we need to distinguish anonymous swapout and non-anonymous swapout? IMHO, we don't. Just like we have done for small folio and THP. If so, how about fix this in another direction? That is, remove "ANON" from mTHP swapout statistics? > #endif > count_vm_events(PSWPOUT, folio_nr_pages(folio)); > } -- Best Regards, Huang, Ying