From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 031BAC3DA45 for ; Fri, 12 Jul 2024 03:24:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 830006B0092; Thu, 11 Jul 2024 23:24:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DFBC6B009C; Thu, 11 Jul 2024 23:24:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CDFF6B009D; Thu, 11 Jul 2024 23:24:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4FB026B0092 for ; Thu, 11 Jul 2024 23:24:49 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ECC7C1A08D8 for ; Fri, 12 Jul 2024 03:24:48 +0000 (UTC) X-FDA: 82329658656.17.1EA376F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf25.hostedemail.com (Postfix) with ESMTP id A9EABA0009 for ; Fri, 12 Jul 2024 03:24:45 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Y6XiHpcY; spf=pass (imf25.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720754654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6b4m9AMKxhjd/9FR53pTLv00lr+frxFKe5TXeRzAABI=; b=m9q1rEG/go0LqSmmXz18R27EV9GYO2ymNB9HjhUtIHAcZJFXc3WsKLwZTBrELevyzWeqj+ OIBeV6bJIXBUOOn/Os10D3d2tiPY2SsiCHNZyLnRsyN1r2qNDlSljelLRadnO1xRlzEPF9 co9PS9xz8/T/3DUGNw5ByQUHtC9nVCo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720754654; a=rsa-sha256; cv=none; b=BfB5PoH6TpOLJ7Rn5HXqXGa8hAkeWkYgrNxe1nU+WbtlMm8fg+q03CtzcckndwqvOyELPs TqcXXFzSR6y4dgh964yeXbhoiriLs8348n+oFnlvQSCT+ihLEM58rLetoBSY3oQfrSDTai 7pHc73iwsUDZFHuE5KU1iMuxXlnERs0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Y6XiHpcY; spf=pass (imf25.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720754686; x=1752290686; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Oi57v7GuK/09YKFkv9pnNthQOxjrDZLk4NqBoE3db/k=; b=Y6XiHpcYX57McD9RtkAp8rUSfHNR2mtWjf+Y/R0qlKyMDjZ8mZVvGg2h 8SMw8FxPQUsud4oHfhz8WJNNvSdZB+g2qx11v3HQJkF6B5uebBIPGwO8N FiiSs/NiCQHQ1MhaJFX5X4nnAwRe22hlqW+mujbAp2lc7mAjom0eufC/i z/ojL2hny9fR6GSnR9ASZkFpxtiBRMxQOL/3y8vEL67bTlCAfnCW0egwR X0XQOTiYeYQRyI0B5wTP3RkhsgGFi6U8P8G7tNJwbDX8B8UDUkpiOiu5G E/4fLbPQFd9kpLN7lyz213DAgFXrhyc9E/qtOJGpjfyKgyBatOSSDp5lr g==; X-CSE-ConnectionGUID: o3RrtaIwQG29g1taPPl9rg== X-CSE-MsgGUID: g9CdEYP2R4+5nkOMebdigw== X-IronPort-AV: E=McAfee;i="6700,10204,11130"; a="28772186" X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="28772186" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2024 20:24:44 -0700 X-CSE-ConnectionGUID: JQXs+Q0iQxKY+Mv3VkM2Kg== X-CSE-MsgGUID: A1ftitm1T2aDUcvS7PP8Vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="48792332" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2024 20:24:42 -0700 From: "Huang, Ying" To: Zi Yan Cc: David Hildenbrand , linux-mm@kvack.org, Zi Yan , Andrew Morton , Baolin Wang , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/3] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() In-Reply-To: <20240712024455.163543-2-zi.yan@sent.com> (Zi Yan's message of "Thu, 11 Jul 2024 22:44:53 -0400") References: <20240712024455.163543-1-zi.yan@sent.com> <20240712024455.163543-2-zi.yan@sent.com> Date: Fri, 12 Jul 2024 11:22:51 +0800 Message-ID: <87le278fas.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: A9EABA0009 X-Stat-Signature: 74arufxhnc9jkudub5e7twjbxs41fsau X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720754685-713800 X-HE-Meta: U2FsdGVkX18AUcpU8nMz4+KO2b0J5WDDIsMfv7618y+pvtduiqZWREdhEyCwrny5OKXZLUTWHN4qje9G99ND4QFvjtbS2hUwVlzK32lO3FGpqMwprRaIL+8xlHM1lbQo8JVMstADhpPb649Nre8l11+0ZY8ylR7DcRoAoiW8kyjFGZwXgTBrJKJgOENsHuueGUZFw7n18RSBKgKcprdYoCb9RfpOQrjkHOLzh07qSPcR+RJ+hEdAb01WdTypmt0slATaj1O4mXjXCs+tGusUYxVOOXphR6SYHhjgvxSl2xXQ0y6Ms8vC9XgwgNFpCw5bB4tW5H33BbvdCjd63hOd/rlfdzGWT8dZGwdQ6WAZ92EYiJ1YyCwlwYZAU8y95jyxet9fVaou9221nSkqqQkUQFDrndM0FnUgoYqeVYFOmGeA1fyon/ScQ1yOfEoBxH8/VQFiPvlSPUutFWkZJ2LmVcQQh15s2Hs/ccexYcWTWtaULRKdh0t6OKJl4Zjrk13FIsgO6sPJqB3jX2j9viexdRbjS8F8DOFP5ZSo13efbes3nOwe3qc/kdJiq80bym8OINUuU3GmxSJPVaaIJaHdrfuB5x5j4lJOutI0nvJsEtoGy187mTfS7icXIEu5VyW+wjfmBAIROkwvOL5+BDytkoBYl3XTOElqPPRMSetTGDXvg2Y95NNaRgEsCPmwnbQmznP1dIpSDlPHJ5X+kWGoo87igB5o6LES+L3OEHGEKOM8L5+/5lhOtUep2xUH/BNEq2iAV4Q0xAd6ne0IESMtXdOAWd6FeI7jlbm2BHmtjTaa+hOvsfftuYdZOIQWlDl6Op7Js0a9VGqvKrvtD8mfFe8Y+xy+aIT29xO9K/rkgLcNz5e97Nrz6Uvin7GPmMtHrPQMKI5RL//JJzPteREgdm9mRPzAQnZVbgZF2AnRdXBZSKOqr/puaMo8azGsBWeonMsl9csCLqM93wZDROf ZM46tRm2 XupBx6CeJnrICvGpKnQnvW4ZP7zW/Bn2yiHudmIVt2Z9QmyE/4FmMzddWKrjsQcbO4oQX0ZdDZ2kT675eQsa0UMo5P11xGu7cKJJdUrBQLermyXHidxw/SeHqdPhv9n/uNTX0ZcN3mEd+79IMD6s+C+Xlq0RnCIxZVgsXQCo2zngx0Y/meIv48Wc8OPedrlt/zMmv5IOGJu2ZYYCWIQ3tNif9KnuIsaHXf+g6be/AWT3alJqbRXCDkMBD4WU3YcLtNcfImy2iLgysBz9T8fe2ICHRQUebIek9gU5Z9IGAlwDV3Zb7n4dYHIulnyoxAvSBwlXJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: > From: Zi Yan > > last_cpupid is only available when memory tiering is off or the folio > is in toptier node. Complete the check to read last_cpupid when it is > available. > > Before the fix, the default last_cpupid will be used even if memory > tiering mode is turned off at runtime instead of the actual value. This > can prevent task_numa_fault() from getting right numa fault stats, but > should not cause any crash. User might see performance changes after the > fix. > > Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") > Signed-off-by: Zi Yan Good catch! Thanks! Reviewed-by: "Huang, Ying" > --- > mm/huge_memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d7c84480f1a4..07d9dde4ca33 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1705,7 +1705,8 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) > * For memory tiering mode, cpupid of slow memory page is used > * to record page access time. So use default value. > */ > - if (node_is_toptier(nid)) > + if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) || > + node_is_toptier(nid)) > last_cpupid = folio_last_cpupid(folio); > target_nid = numa_migrate_prep(folio, vmf, haddr, nid, &flags); > if (target_nid == NUMA_NO_NODE)