From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E66CF6495 for ; Mon, 30 Sep 2024 00:56:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FC0490000D; Sun, 29 Sep 2024 20:56:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ACBE90000C; Sun, 29 Sep 2024 20:56:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDD4F90000D; Sun, 29 Sep 2024 20:56:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D000190000C for ; Sun, 29 Sep 2024 20:56:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 43B81C05C6 for ; Mon, 30 Sep 2024 00:56:44 +0000 (UTC) X-FDA: 82619589528.16.48C5D92 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf24.hostedemail.com (Postfix) with ESMTP id 1AEFA180007 for ; Mon, 30 Sep 2024 00:56:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kLP7SOsf; spf=pass (imf24.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727657676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A6W9B/uTuaM6AiOmIBdNR79vcykHC1ZNNxfjDZJgZmU=; b=HVBzkv0YVOYEURYkyRm81GWNvmZzKEN93FGiwf9ElcDvHz0z9DeXiJ9/A3olamcAuYJeF/ puKRozPFB7szduQx7GmDi2KY5D9acdP+4rZbmmDeEpCKvOsSdut0E0MYpshIZ+FgvjBBh8 CE1RPHJGBXlAr2VICqMUp4lxBbZ5qGw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727657676; a=rsa-sha256; cv=none; b=Ys74bhUlVrArzRftLy5MM70GH4K7gy164MEfejPMv/JDYGqulChaOm9+XaTFFPe6SKfC8/ 8goGIuMTh9SQpr9mqBrEbRexVg/XBTVG6mIxDpAKS9uB1mrU3/6NC/PpFe6/SJPH7gz/6T Z5tkM9dznhwvC8DblnEHEV8dcGsLzO0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kLP7SOsf; spf=pass (imf24.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727657802; x=1759193802; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=OZoIIPzPzC9PONOLbEkOi98SbES+quudNHFDQQL7TQQ=; b=kLP7SOsfp038I/qYYKvzxhXhweU3//OziDkZwlrKzLZFUVSrg4VEG7R8 brpMCnTuSZSeupAaIKZMls6jZLAf5PHisnO+XvE0dh2RU3wRUWNEe4MF3 FMutu1fY+2tpmaT3FNOrOQPAtUqnPzd3CaiZ1PEtl1G7/9fnoOOEqRQR5 qTU3ct6q5C6duOpMihsSVKtVDBE4ls6ilcQFCh2enLt1ZK+t62Hys4w8E C+sDYr/5b1g11Ap0veUuKHGTtjbke9rzlIDwdkr2Y0WEUJT4NXjL/hgyf Q9ZkQJmAuT/iSRk275mfsQv+CQ6qf79WOSWSgtAw9EDGDy5HyIqOUa0fz w==; X-CSE-ConnectionGUID: 5pcjF6pYQfakUvIfj/h9jw== X-CSE-MsgGUID: 4AW6e2ZsR7y3j4bFaW0E/A== X-IronPort-AV: E=McAfee;i="6700,10204,11210"; a="26606283" X-IronPort-AV: E=Sophos;i="6.11,164,1725346800"; d="scan'208";a="26606283" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2024 17:56:41 -0700 X-CSE-ConnectionGUID: gBM+tIWLQZmfWCHEa3Vt4g== X-CSE-MsgGUID: HXKx1IP0TQ6m3A8jth5EeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,164,1725346800"; d="scan'208";a="73520402" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2024 17:56:37 -0700 From: "Huang, Ying" To: Kees Bakker Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Dan Williams , David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Andy Shevchenko , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH -v3 3/3] resource, kunit: Add test case for region_intersects() In-Reply-To: <9c9586ab-0426-46c1-bcc6-6ee2927b7a86@ijzerbout.nl> (Kees Bakker's message of "Sun, 29 Sep 2024 21:45:46 +0200") References: <20240906030713.204292-1-ying.huang@intel.com> <20240906030713.204292-4-ying.huang@intel.com> <9c9586ab-0426-46c1-bcc6-6ee2927b7a86@ijzerbout.nl> Date: Mon, 30 Sep 2024 08:53:03 +0800 Message-ID: <87ldzaotcg.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: i7wrh4n9qj6ydwxjfqfsctcjbf4hejab X-Rspamd-Queue-Id: 1AEFA180007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727657801-300076 X-HE-Meta: U2FsdGVkX18ilPxrFpw5DgLHauPimVqjUHWzM38ccM00z7IFrZ082IiJXHUw6t6+bOF3Ayry+9qnTVif+1xXlR0WKovva23wgBnopuvOg1rmTJuCBHLONu83dAiv96qGnKBT8uQYSMpbpi18BycJOckWoY7ilCzl32QGbCR1NJHhsJR+zPi4MB+omAZczfhMHo16jdrRXnPhy064WPI2k20qPMQ0znvP75HVYp36Oy0TOS8LEkhaMSdLweA7XKenGTEMkhzy4I7ZYIO868PCs2aF/sUSgZ0k8lhY3MMZp/1t7VRzAmS+caZtz8XSswj5ucfi4dZ0sSWemNZuPyp55YzeYvdHrjiFih5/iq7LPPt2m6rJvfTsx7XRXzugSvX4dLs+3RAc2ACxo6fROd3X0XidOIBnNV5YZVDjSN/OqpyEixBjDtFaTHlmMuhTL7p8um8QbsubqqDDyK8C2Xk6O795zvR6LPpMULpmqtp+9YdpRnQ47XQNruACEPDCyjNbUw5DCqzOBKOpZsvBX5N2GFbO5Wt8eLZCsEI+VmhplmIunoqBAyuxCj8xqChfdJiRARDVN7kYa/ooKC909T4lpV2A5gPR2T8+J+at2LPtCfoga0QEW7MrCntt7jJOSnMfBQp13OA7/er1miiGl+X4QLgL5zD86pZiscQM8lCv7vMJThQZTc8IKIkSAWml+ciMIWO5FSJThbKhGDE4HU2FD+OT20zTxN8xUW9T6sBtvp1s8MLpwKQ4pmBYaaG74mGzPjCYv4jFxEx3+wxLjmbi+RM9wWTf6CdIrGM7+oVoq/n6lehr9ndWyJ8B2RRpW3PxLf5TN7V2QzC5tNzRVRiXTkChgnCd2DX5jrAKV685UrFucQoRvCBV5ehHmrI+9ko7M7370tBZHX4Gb3myISLlITK2FzG7tEFC15TFbskaehiISERtQ/jYEpSJmgtqF8rpj/3tsj1YORkf8CFFiVH FBJqIgZV dPPuZ1fZl4N3P7ITogd6XYwYa1Z8/P6rZ97wp5/NEnFjU066EaSocDWcvm9469zahXOGSvsm9KkDYHIy44fmmtOVAA8Ut55r97a5k8Wb3KDiYkdmE++MYj5IF1aOzCgVIW0nM9xhyhb7mL2o9vLCJP7vPGHn6+Xg3F+25JtKJwbjdjGZz3pC2l5fuhp/1RceZMNCz5X/3zF5e7EoV74j0NZ+luxv8Nquh4t6QBNS4TFRg/5+o/C5VgaklWU3kRVGjdh8NEOPwuugHbz9061fX0h5olg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kees Bakker writes: > Op 06-09-2024 om 05:07 schreef Huang Ying: >> [...] >> +static void resource_test_insert_resource(struct kunit *test, struct resource *parent, >> + resource_size_t start, resource_size_t size, >> + const char *name, unsigned long flags) >> +{ >> + struct resource *res; >> + >> + res = kzalloc(sizeof(*res), GFP_KERNEL); >> + KUNIT_ASSERT_NOT_NULL(test, res); >> + >> + res->name = name; >> + res->start = start; >> + res->end = start + size - 1; >> + res->flags = flags; >> + if (insert_resource(parent, res)) { >> + kfree(res); >> + KUNIT_FAIL_AND_ABORT(test, "Fail to insert resource %pR\n", res); > Isn't this a user-after-free? Good catch! Thanks for pointing this out. I should be more careful for the error path. >> + } >> + >> + kunit_add_action_or_reset(test, remove_free_resource, res); This may cause use-after-free if failed to allocate memory for add_action. Will fix this too. >> +} >> -- Best Regards, Huang, Ying