From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC845C021AB for ; Wed, 19 Feb 2025 09:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41FF1280219; Wed, 19 Feb 2025 04:09:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A8D8280215; Wed, 19 Feb 2025 04:09:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2496F280219; Wed, 19 Feb 2025 04:09:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 00BE1280215 for ; Wed, 19 Feb 2025 04:09:02 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 802FEC1226 for ; Wed, 19 Feb 2025 09:09:02 +0000 (UTC) X-FDA: 83136119724.19.7A75524 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf02.hostedemail.com (Postfix) with ESMTP id E44E080013 for ; Wed, 19 Feb 2025 09:09:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Vtr12H1G; spf=pass (imf02.hostedemail.com: domain of a.hindborg@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739956140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rSLObtOYNhvEbwoHR+5gOiO7o0p1QXTJY22C2gSMTXU=; b=1K9Z02OE9E6BPEQb5RY+0wgDe7gPR77AgFpgYlMSPhe2A1opbv+NqTJENUHH0wEaJEMYz8 6CeyU2MpOuLoxk9ahdsuVjnnfJNB6vTkmBgKAWbJWR2BAIgqfP5vo/0Tdva+T9/rY7/vtb xWL2h8JQnbvdm0K8Z4p9GI2F1Thtfmk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Vtr12H1G; spf=pass (imf02.hostedemail.com: domain of a.hindborg@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739956140; a=rsa-sha256; cv=none; b=M3jBu1EQnW2roh5UEt7fLFcwX/lCJL5mH361XN84HiyGhLe7fuq67WS3HNyDHPpgGFpbZX 6FIavXVoU5D6BC1HawyG5ji931YFGAyQ7uGQMoQICNEiVq5zlC5G68Zt7OHCXlWJoDxS4W u0YakNrLXwbe34wBFD1Yr293tFT34XY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8D81CA41FDF; Wed, 19 Feb 2025 09:07:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78249C4CEEC; Wed, 19 Feb 2025 09:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739956140; bh=rSLObtOYNhvEbwoHR+5gOiO7o0p1QXTJY22C2gSMTXU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Vtr12H1GRzYENaEK4wQdVRf535eQVAMbGLkcePMXoZv9W3FCpva06gkuUw67YkmO7 KH9hjPmx2xqnuvHa019pC1Fj1+Zw3ZjouUTTjG5C+QXyJC13ZOaDzqfgUUW63nF/kI Oe/5geFRm2W6Ud2AbeYYYkqL8mA/GXlKhld28igIlaJXw9Sm0CnN2vQ7BZYPbKRZOu E/rQDU7S+zK7Or8CZT77BvmKzQNNB5FWUsc7LQKo75G3Izlxp219jDqq3HOj1C4s8k ZADa5INYK5ghLn/UcCNoWdfVmj+LIsMwIpMt9TJ4v3bBLMt8jp8gdNBm/VsgBgBq/Z WW/Pg+ezwMyjA== From: Andreas Hindborg To: "Asahi Lina" Cc: "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , "Benno Lossin" , "Alice Ryhl" , "Trevor Gross" , "Jann Horn" , "Matthew Wilcox" , "Paolo Bonzini" , "Danilo Krummrich" , "Wedson Almeida Filho" , "Valentin Obst" , "Andrew Morton" , , , "Abdiel Janulgue" , , , Subject: Re: [PATCH 6/6] rust: page: Make Page::as_ptr() pub(crate) In-Reply-To: <20250202-rust-page-v1-6-e3170d7fe55e@asahilina.net> (Asahi Lina's message of "Sun, 02 Feb 2025 22:05:48 +0900") References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <20250202-rust-page-v1-6-e3170d7fe55e@asahilina.net> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 19 Feb 2025 10:08:25 +0100 Message-ID: <87ldu2cnee.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E44E080013 X-Stat-Signature: rp51dcs7hk43zkgfxgoux1izyf69oxps X-HE-Tag: 1739956140-185039 X-HE-Meta: U2FsdGVkX19Cu7UyxrVA8jUxtuFXQZUArCMl0l5KAmg+g0iopYAIa84KjWQlm817CJ1TEB1icpiIM/BhgCRf0pmnV7O+lwumzSsLZBgmEoN2Z89p309cfVjn0Xp42u9XLqecVbVQpGl60tqvxogaPCkfMberIgTf0ngVTd1nopH4cfqDM5lnroWXS6T+sX89SeDNpQun7EWfQNLxhTPHBj+RQrBTrl79sjEXawGeyS15U4MUNjL4pHpHFjWPKqG/Z7/+4NNZ9yNOZ4g3GZAdL1t33K3EoeWU0ZXh1d7OSG289ET6VvwjrKIiJkredDupoHNV3+ktkmX8VdqhF0FLgr8eosLR7gHXNCDEnAE5h44OBh4E6kPLTK3RRyOyXSg8jCRYndTa3XiKymztcDDISGnBIpikLm5PIIqk9W3Mxx3fRYB/SmRBPZlkJR6AafsikbcbWn694T4pHqt5Pz/RCjjcwdtoKLmdVb3OTD4kCYtLor0oY1K7ZlsHPk2o9A6H9JnnhUIELFXqSw1dwdmr8YjEi9xM9M0yRWmBFmERC2pgosB5omx8zj0K8MVBUFOkCREmOskx5NXOZA+yfpdk9GHwPzF4y1xOgKMVlLn9lgrk+9SuXQKu+7bI0r7eUlInwFdSUCVjQeyOvHsr2mR2DM15nEN+iWxpzIsi2zheEJnOWiQngioK0/AXYq92stn4zHmoE0792W90pWLA1LxEThBUswBoXYV29W1RpXPcGBb6rvmjwq2HJTGJ5ULXYPr8O4pDQnhk/ZzO4TwzCnAw2jBuTn1fJXK0w+gFf6IMz5cfLSjw2vcsDoL9rR3YBy7y/sKPH9gjVy0W2LyAOtrQuG8EVqPu82Bq15oQPtAmNxIE4K6a6EQU1AwrAuM6jFukSaK0qmCVhKtZfNB2RiJc1q62BRiV7HJixCWiLyy3LXpY63QXqbYKyy5+gK0UmQZ+Aca/cNZqo5Amsikk/Bj s2fADJVO XqmIBTfbuhkLuCqwuHEmu7adau+zOTJMv8H1dy1emYjaNz+BNe2ZaWidcu9XZX3PgZVQeFxU+zpPb379pLpu72ibQ9zwbsI8YMaOESLYZtHJPC2ShrwbWxfbxPbT1pl8qDe5OyGMdHIkATIl7ZRjRYyg4rzfl8UFF8Q10ilif1pCNP0DtElM/uFfZJ5H4s/vy6SWetcOXYpfdu/0r0VMWqNp0v59vCNvQ8fE23bl13jxkMC40mA6lKMIUhLQthJwkDX+TyvKeyEyfqFt5gbx46PONBavI0o6RG5eHViVml7hlQJ2EpHaLkoJDogeIS/aTEeHlsRt59KUyD5MVKwYSaVmBn0FC9577Xr6M+PGiSAZoU+q7vaZpt2QYJA== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Asahi Lina" writes: > There's no good reason for drivers to need access to the raw `struct > page` pointer, since that should be handled by Rust abstractions. Make > this method pub(crate) so it is only visible to the kernel crate. > As I mentioned on another patch, we are planning to split the kernel crate per subsystem, and this would need to be pub again then. Best regards, Andreas Hindborg