From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1410DC4332F for ; Mon, 27 Dec 2021 03:19:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85E5B6B0072; Sun, 26 Dec 2021 22:19:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 850736B0074; Sun, 26 Dec 2021 22:19:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 690646B0073; Sun, 26 Dec 2021 22:19:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 5602D6B0071 for ; Sun, 26 Dec 2021 22:19:40 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0DCBF181AC9C6 for ; Mon, 27 Dec 2021 03:19:40 +0000 (UTC) X-FDA: 78962119320.30.D39750C Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf29.hostedemail.com (Postfix) with ESMTP id 6E3A0120025 for ; Mon, 27 Dec 2021 03:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640575179; x=1672111179; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=NdIek6kTYtbS5/oPywVshmnuMKBVwGh80PHZlhTHNHk=; b=Kpz0QPlnC33naOHJldx/RyeEYmlvA07K0wkCv4bQdtatDR1O2HMKsMD4 ZG+CTrRW0RnyDDpTpTJCS8k94sUA4+Y79vdObZp8gSlIvMnlwqqr3m252 vZrSRBOt7BE3UDZs2lJcuDLSUj3VTP1TsD+AWd3GVPp0/8yznL9za8zAf 8HFayTSb3wJLG2UPIu8w270iSF5q2qRAqaCwueIQkE5m6aYqSshzDec9d 0F83Jt+ahWTOiftVXovbt/h4yMcvcGK4ufA2dfGRkzKGl19vU8391O8LJ hACHpULQ2cnrNr+l58PsbBGUZcwqr3GrtQnO3ovhcm8UNW2KXX1X8QQne Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10209"; a="227989158" X-IronPort-AV: E=Sophos;i="5.88,238,1635231600"; d="scan'208";a="227989158" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Dec 2021 19:19:37 -0800 X-IronPort-AV: E=Sophos;i="5.88,238,1635231600"; d="scan'208";a="469604497" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.11]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Dec 2021 19:19:34 -0800 From: "Huang, Ying" To: cgel.zte@gmail.com Cc: akpm@linux-foundation.org, yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com, yang.yang29@zte.com.cn, minchan@kernel.org, saravanand@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/vmstat: add events for THP max_ptes_* exceeds References: <20211225094036.574157-1-yang.yang29@zte.com.cn> Date: Mon, 27 Dec 2021 11:19:32 +0800 In-Reply-To: <20211225094036.574157-1-yang.yang29@zte.com.cn> (cgel zte's message of "Sat, 25 Dec 2021 09:40:37 +0000") Message-ID: <87k0fq7n0b.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 6E3A0120025 X-Stat-Signature: 68j9mgat1njoeemtnwf1km47p89p4oy6 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Kpz0QPln; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=ying.huang@intel.com X-Rspamd-Server: rspam02 X-HE-Tag: 1640575174-166826 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: cgel.zte@gmail.com writes: > From: Yang Yang > > There are interfaces to adjust max_ptes_none, max_ptes_swap, > max_ptes_shared values, see > /sys/kernel/mm/transparent_hugepage/khugepaged/. > > But system administrator maynot know which value is the best. So > Add those events to support adjusting max_ptes_* to suitable values. > > For example, if default max_ptes_swap value causes too much failures, > and system uses zram whose IO is fast, administrator could increase > max_ptes_swap until THP_SCAN_EXCEED_SWAP_PTE not increase anymore. > > Signed-off-by: Yang Yang > --- > include/linux/vm_event_item.h | 3 +++ > mm/khugepaged.c | 7 +++++++ > mm/vmstat.c | 3 +++ > 3 files changed, 13 insertions(+) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index a185cc75ff52..7b2363388bfa 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -98,6 +98,9 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > THP_SPLIT_PAGE_FAILED, > THP_DEFERRED_SPLIT_PAGE, > THP_SPLIT_PMD, > + THP_SCAN_EXCEED_NONE_PTE, > + THP_SCAN_EXCEED_SWAP_PTE, > + THP_SCAN_EXCEED_SHARED_PTE, "SCAN" appears too general, how about THP_COLLAPSE_EXCEED_SWAP_PTE ? Best Regards, Huang, Ying [snip]