From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31535C433EF for ; Wed, 9 Mar 2022 00:29:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A39628D0002; Tue, 8 Mar 2022 19:29:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C00A8D0001; Tue, 8 Mar 2022 19:29:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 860E58D0002; Tue, 8 Mar 2022 19:29:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 73E628D0001 for ; Tue, 8 Mar 2022 19:29:47 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A0B824A0C for ; Wed, 9 Mar 2022 00:29:47 +0000 (UTC) X-FDA: 79222964814.07.E954218 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf31.hostedemail.com (Postfix) with ESMTP id 5437620017 for ; Wed, 9 Mar 2022 00:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646785786; x=1678321786; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=rTewoYY5iGutquVo0W7aUnC1d1O9Xf62XUlk7Bo0QUQ=; b=BhIqTLVSeyUgDtxQJv2sEyzABccYZyefsI9lEZCX69EaUNTLWjgPJ3vT /X/ym9ISf7p1dXrX4jw3okLs+MNS4HGQ63l3IUPUNlvvlQ0qWun2IHgyF CYo2ccLLJdmkcV+IOi6DSFYQKbD3GOuh+lnyNXEhpS2N1xq8yJftue/k4 n8hl5NxpG+Opuc8vmXVgkwZ/zIkK2sAER/aL+XtEH/iYOs/8lGsjZle7T +4GAZIua9rOCw8LIioi6ep1sqUci9iWcfazGBKmmf06Dn9udIwR9woL5Q 45vyI38cEVqPsFZuQKvwu4cwDS4i0ROSqI5q4/b4EmErpFVUs3MnLeiZY A==; X-IronPort-AV: E=McAfee;i="6200,9189,10280"; a="253679668" X-IronPort-AV: E=Sophos;i="5.90,165,1643702400"; d="scan'208";a="253679668" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 16:29:45 -0800 X-IronPort-AV: E=Sophos;i="5.90,165,1643702400"; d="scan'208";a="537793799" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 16:29:42 -0800 From: "Huang, Ying" To: Oscar Salvador Cc: Dave Hansen , Abhishek Goel , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , David Hildenbrand , Yang Shi , Andrew Morton Subject: Re: [PATCH -V11 2/9] mm/migrate: update node demotion order on hotplug events References: <20210721063926.3024591-1-ying.huang@intel.com> <20210721063926.3024591-2-ying.huang@intel.com> <4e8067e1-0574-c9d2-9d6c-d676d32071bd@linux.vnet.ibm.com> <87pmnb3ccr.fsf@yhuang6-desk2.ccr.corp.intel.com> <86383ac9-e5f2-1a2e-dd19-02e39714a3fd@intel.com> Date: Wed, 09 Mar 2022 08:29:40 +0800 In-Reply-To: (Oscar Salvador's message of "Tue, 8 Mar 2022 19:56:59 +0100") Message-ID: <87k0d4ge8b.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 5437620017 X-Stat-Signature: xucjto5ys7b5hfu9xwo1ieim4j9sahsm Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BhIqTLVS; spf=none (imf31.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646785786-889982 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Oscar Salvador writes: > On Tue, Mar 08, 2022 at 09:07:20AM -0800, Dave Hansen wrote: >> On 3/8/22 02:27, Oscar Salvador wrote: >> > @@ -2043,7 +2044,12 @@ static void __init init_cpu_node_state(void) >> > static int vmstat_cpu_online(unsigned int cpu) >> > { >> > refresh_zone_stat_thresholds(); >> > - node_set_state(cpu_to_node(cpu), N_CPU); >> > + >> > + if (!node_state(cpu_to_node(cpu), N_CPU)) { >> > + node_set_state(cpu_to_node(cpu), N_CPU); >> > + set_migration_target_nodes(); >> > + } >> > + >> > return 0; >> > } >> > >> > @@ -2066,6 +2072,8 @@ static int vmstat_cpu_dead(unsigned int cpu) >> > return 0; >> > >> > node_clear_state(node, N_CPU); >> > + set_migration_target_nodes(); >> > + >> > return 0; >> > } >> >> Yeah, those callbacks do look like they're reinventing the wheel. This >> is a much more direct way of doing it. > > Then let me play a bit more with it and I can cook a patch unless > someone feels strong against it. This looks good to me, Thanks! Best Regards, Huang, Ying