From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BECC433FE for ; Thu, 29 Sep 2022 19:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CF098D0003; Thu, 29 Sep 2022 15:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07F498D0001; Thu, 29 Sep 2022 15:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E89AF8D0003; Thu, 29 Sep 2022 15:21:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D8A068D0001 for ; Thu, 29 Sep 2022 15:21:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 78FA71A09CB for ; Thu, 29 Sep 2022 19:21:46 +0000 (UTC) X-FDA: 79966092612.02.02F77E7 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 096A3160005 for ; Thu, 29 Sep 2022 19:21:45 +0000 (UTC) Received: from localhost (unknown [IPv6:2601:281:8300:73:8b7:7001:c8aa:b65f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 5125A734; Thu, 29 Sep 2022 19:21:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 5125A734 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1664479304; bh=bJcm9pawjNycjM+Nrq5TLidpXgcC/Xq62OwmjJR1/Ag=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VTHiSta6QeIia+XRQG8Jgoq59d62Ak+77NcNkEEQFhwf/do+hoo/kDrBpCb7E9aAq ffZYCfz3EqwR8VZrakRqJoIk+VlJcSyLogJ7edBgsY1P9ynbUqYzCqzqcwwRygEhg0 znZ54jtB6CMNb9WIjbh4MwhX6XGc17YJh4ftpRCoz8f8kJgkmUlm1fnVBjBIX0Yivy vSuo7jeBRsOq/0DOZq6MZ9CndZ23DR1HTK72WvuXtCfV3RT7DKelhsdoD6JiE5WEqW wId3HIz+jvUATz0bQlia5OlL/mf8XpjrvHdVd6YiwaVvDc9t3vil0gbKq8WZkfiCVt TNazD9skBK6qg== From: Jonathan Corbet To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, David Hildenbrand , Linus Torvalds , Andrew Morton , Ingo Molnar , David Laight , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Baoquan He , Vivek Goyal , Dave Young , Jani Nikula , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Akira Yokosawa , Kalle Valo , "Daniel K ." Subject: Re: [PATCH v2 0/2] coding-style.rst: document BUG() and WARN() rules In-Reply-To: <20220923113426.52871-1-david@redhat.com> References: <20220923113426.52871-1-david@redhat.com> Date: Thu, 29 Sep 2022 13:21:43 -0600 Message-ID: <87k05mgf5k.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=VTHiSta6; spf=pass (imf08.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664479306; a=rsa-sha256; cv=none; b=8l0qr4YB6Cw3j2/UnLYSBAO9jsQwKQwv2CVdX8Ci+Ie9KxWSIRBA9DFeVwIxyUwAniCIqr EokmG93xvN2U6ZmwSUGOzyDI/wMELs2DhVKXafaXyHSuV6wmOCwcinKXXBJmxxmkS7WrWl fCTesGYnHcGVja2Llb0oemh2B733A/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664479306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bJcm9pawjNycjM+Nrq5TLidpXgcC/Xq62OwmjJR1/Ag=; b=HnjDnOsfqsRtRomctfEVeZdet5ytWbv38Gck21KNhYbuelfoo5tD0WIcuAOcWhqXHJhqiN JkbbAxSJbXZpixA6iecPlvinrUZ6vfOLRrXhp+g5/bbhzPPD5MbdQctosFymFZtIE+KDw2 6ghjZ9gweeQXX+SO9KlarcC+UFKt45A= X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=VTHiSta6; spf=pass (imf08.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net; dmarc=none X-Rspamd-Server: rspam10 X-Stat-Signature: bpqs93ag5awnzzhdbnhdua4f4oonq1oh X-Rspamd-Queue-Id: 096A3160005 X-HE-Tag: 1664479305-307687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: > As it seems to be rather unclear if/when to use BUG(), BUG_ON(), > VM_BUG_ON(), WARN_ON_ONCE(), ... let's try to document the result of a > recent discussion. > > Details can be found in patch #1. > > v1 -> v2: > * "coding-style.rst: document BUG() and WARN() rules ("do not crash the > kernel")" > -> Minor rephrasing / reference fix [John] > -> Compile fix [Akira] > * "powerpc/prom_init: drop PROM_BUG()" > -> Dropped because it will go upstream via a different tree > * "checkpatch: warn on usage of VM_BUG_ON() and other BUG variants" > -> Rephrase warning message and remove trailing period [John+Joe] > > RFC -> v1: > * "coding-style.rst: document BUG() and WARN() rules ("do not crash the > kernel")" > -> Rephrase/extend according to John > -> Add some details regarding the use of panic() > * powerpc/prom_init: drop PROM_BUG() > -> Added > * "checkpatch: warn on usage of VM_BUG_ON() and other BUG variants" > -> Warn on more variants It seems we've talked ourselves out on this one, so I've gone ahead and applied it. Thanks, jon