From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E18EDC77B73 for ; Wed, 24 May 2023 09:52:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C9506B0075; Wed, 24 May 2023 05:52:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77A49900003; Wed, 24 May 2023 05:52:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6411A900002; Wed, 24 May 2023 05:52:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 56E0A6B0075 for ; Wed, 24 May 2023 05:52:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2B581A089A for ; Wed, 24 May 2023 09:52:32 +0000 (UTC) X-FDA: 80824683744.06.3746545 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf26.hostedemail.com (Postfix) with ESMTP id 77BDF140015 for ; Wed, 24 May 2023 09:52:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=pjnHZO3I; dkim=pass header.d=linutronix.de header.s=2020e header.b=68ifIaBf; spf=pass (imf26.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684921950; a=rsa-sha256; cv=none; b=ZOIIP/91Zg1awB+C7j1Fpbryp9mnokwB6tw16qZXh01S09XotB0vF0JL9lsEhjyERh1MnE 3ahQw5f11q3C7BuLW3bL5wyhrlYgqGjDAFjO9Z1sCyRcV8L41PniiOUA8TcnWEzQMsBH8K X0fLTvayrBQPAnNmtNVpNfOHSSRWDV0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=pjnHZO3I; dkim=pass header.d=linutronix.de header.s=2020e header.b=68ifIaBf; spf=pass (imf26.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684921950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kI5WVKSvUPA1TQ9I1smnPPae9xHKQ6pSGSvTs+MRj9k=; b=HHB7LPML03thO/1SEYlyg8EmZ6toKU2vDGCJrWlsdFZSpYMV6qooAQXw2iBXrRaqYfBMml YhESnn2RKGRQd54hzyoiH/+eR1ymGdzjj9RoRh2BeM56+s+BY4sm18PrwWGJLu5qSnvES0 Lkz2Zv8emDvSx3Or2UEMUjtvPi2sIoY= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684921949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kI5WVKSvUPA1TQ9I1smnPPae9xHKQ6pSGSvTs+MRj9k=; b=pjnHZO3IioxVcxUKNDYY6+XBIcgqoCqCUeSZ2lq/NTsPsvJ1DED6sr70MXg440ZP0voiLv 7zR76Njknck4XCbnCjjIHvL9XaV10Mjqpo5MBybWjSK3PkWc0JF73NxZRmtP3nCQ86TI1p 2I5gXUD4TyLAu5IfU8eNXt7ovKh7EwHn6piRH4ShA0stYhsqz2P7nvqLVUiHNB9ObwOAXZ sV6paKk1B3QQEvDbPEy35Glnytm4f1AtbajqWFLNhIDN1z//oQ/W+6qNAVOXp5Az/yYExT LpsCpoASr4CNA60rHREmkOvDIuLrD21m9oosg+r9PbGRu+GGZzph22IhbqVsLg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684921949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kI5WVKSvUPA1TQ9I1smnPPae9xHKQ6pSGSvTs+MRj9k=; b=68ifIaBfkgmZLEs8Ws/un5YgkNU+3KEw3+fE2Ldu/GruiBs+7eDCtcUvP9nLrrgGyHhsEk tLb8z2rxiqMSJDBA== To: Baoquan He Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra Subject: Re: [patch 1/6] mm/vmalloc: Prevent stale TLBs in fully utilized blocks In-Reply-To: References: <20230523135902.517032811@linutronix.de> <20230523140002.575854344@linutronix.de> Date: Wed, 24 May 2023 11:52:28 +0200 Message-ID: <87jzwym4yr.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 77BDF140015 X-Stat-Signature: tunsqesjb3ppfynww5btnsippy76t91q X-Rspam-User: X-HE-Tag: 1684921950-964441 X-HE-Meta: U2FsdGVkX18eui+tJVUoZVWegrDVP44YQ597QTjzkoqJkTa++H3sezGPdhlbilvji4UTgUKAS7RLmZYjbnPsxm4DjcTJhqxNrTUqqhSuarZDDZ2EvTgs4F3jNBtaYJgKeuFEDjwOcuUYGc2B8pkdcr6vDJAfrBujSNM/Wjj0kUF86XGoRgh2MAXo9r7aoxMM4IffRoZtO/kHHHUhnLca8kAuoUOiu1KqTBdDjJTTUFJUZ/Uq9estrGhMiG3NnL38Zpoyx45brVLmET2QU4ISR+PIKMrzJ9YTZBgqcYok1tPxXDg47by8Tp6HD9TjULEavYQSYLUyxZDKF7XiV9ZrHGSP9l2dGE/n6IN01u95Md4IwVQ6dVkjeWt4uYoeIITAKrPthvFSZzUPTnrK2YRP8PcGHdcbyGz7sWjC3vtprdyeJT+d8Lk5Yn0v+GM0FUqQjUkcMdu9lc0zth2aik9XDFilxPJVUvrkQiqp98aq3W9K3Wq13djSDsGo9zW0lOPG4GMF1ctGHCyNbXeWMqVg/m97k+4yN4EozcJmQQ7pNHq8y4joMFd7Zncp4mCXSDmss6sEng47EI76y07lAQhkeiTwwYaXb3UIv2Ywo7lEjoatVBTyPz6jzswG+02hn1d/0WxSNfLqtfRJtm+ZmQ/JfFK/LBUlV0MZ/9rvlceeQ9X6oqx1a3ajgNHe9zXvYZZELfez2mRFpZSik2+ByqbumNae+zQkUQ9oLsx2P/mV07cdiV2jtj60Qv2EONcSMr5XH1+ceEEGv3nqRRNE10i+siUuK3DM2Msx/fUbV/0cp4YBJZ0SGi/bjx7z8FDD8XL6g/C8o7LhrU7y125yfeeBD4Ruffg/a2UpX9yJx0CChvBzRNk94mc+R+dKPDwlsHH/fZDonM/EHiIjpf2s5BSmiYhvaTilvZgS8Rr71rSJiViT2RjDBk3RJNALhUpb4WmE4xaKZpPFgxGHHfW48Ow 9WLsWmF9 vFl0/l14txHgCQbL27kXIPmx6EbfiWThpt2kRJkfD4vFT6eU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 24 2023 at 17:32, Baoquan He wrote: > On 05/23/23 at 04:02pm, Thomas Gleixner wrote: >> @@ -2236,9 +2236,10 @@ static void _vm_unmap_aliases(unsigned l >> for_each_possible_cpu(cpu) { >> struct vmap_block_queue *vbq = &per_cpu(vmap_block_queue, cpu); >> struct vmap_block *vb; >> + unsigned long idx; >> >> rcu_read_lock(); > > Do we need to remove this rcu_read_xx() pair since it marks the RCU > read-side critical section on vbq-free list? And what protects the xarray lookup? >> - list_for_each_entry_rcu(vb, &vbq->free, free_list) { >> + xa_for_each(&vbq->vmap_blocks, idx, vb) { >> spin_lock(&vb->lock); >> if (vb->dirty && vb->dirty != VMAP_BBMAP_BITS) { >> unsigned long va_start = vb->va->va_start; >>