From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA709EB64DD for ; Tue, 11 Jul 2023 04:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AC158E0002; Tue, 11 Jul 2023 00:26:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 434DF8D0001; Tue, 11 Jul 2023 00:26:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AF498E0002; Tue, 11 Jul 2023 00:26:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 154BD8D0001 for ; Tue, 11 Jul 2023 00:26:01 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 251C01A028A for ; Tue, 11 Jul 2023 04:26:00 +0000 (UTC) X-FDA: 80998043280.06.257A39F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf09.hostedemail.com (Postfix) with ESMTP id B160E140009 for ; Tue, 11 Jul 2023 04:25:56 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=j8dL+Ink; spf=pass (imf09.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689049556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q0hpPzwVxZ41g+J5RuLFNLVMcXoQxCk/OBS0MCzz+Yw=; b=eWnSpDvEff0ceExhaUOOChqpd5IGL2aMZWpGqxm/Evwod8SSOeARpOjE5jAsVF88UxJdY3 86TJyjUOjBJf8rJ05fhBEGT7RKr1LhXfzbKr/UuvDQw46wkAgRtpm/237Lu7u7TeUKGu7r PvYYlOrzyqivAMWyxXOl5AIhQm+ZM8I= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=j8dL+Ink; spf=pass (imf09.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689049556; a=rsa-sha256; cv=none; b=DQkhASzRVtdedC64x6AbcwxwG405Q2c1zwE4Ih4ox2diMCrTzpZQE/yqhJR6G5+UoDs1rQ pPosxmBUIxlTruZX1ddKaTCSV93BxfS9Gr8Hclx8sVJJ2u7yqukEzx3Ud3FTBrpANjOfHp ORJsYwyHBiRfvjydfWr4NAgL7ERxU0w= Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36B4Ga3k021893; Tue, 11 Jul 2023 04:25:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Q0hpPzwVxZ41g+J5RuLFNLVMcXoQxCk/OBS0MCzz+Yw=; b=j8dL+InkzM8cwKTTdG/b7pxuWg7OlGi7zLroR+QocjW05S1zTyry1Xy7Kdw+0udDFq/Q 0c6CW2t7egTyGdQIP/aN8h4Jg594sEedDwzsMM7EZPvvAEtQTw9I7q6iOFqVJMsW/T6b JWWMHb//RKRQL8YpXxIXQ58eYGV7QMNl3cXq2rh96FixY3qxy4urDAoFWh3cVUUh+sX4 sVxeObbPVZ6C5Esrt9y1cqPKDH2oBQ44z/NcA5Pd+dK4lQReUd+zRco02YopE7q6jTG9 B/aoM1Lo6nchQsKToWUAkUeZMpXvnkcwGK0e4f7KcalXF4d0I+AbhmcW0evGAgf5T0q4 RA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrywrg4fy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 04:25:44 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36B4HfPJ023740; Tue, 11 Jul 2023 04:25:44 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrywrg4fc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 04:25:44 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36B3lW61017128; Tue, 11 Jul 2023 04:25:43 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma01dal.us.ibm.com (PPS) with ESMTPS id 3rpye6vayp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 04:25:43 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36B4Pf3E64684410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jul 2023 04:25:41 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F29558060; Tue, 11 Jul 2023 04:25:41 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 696E55803F; Tue, 11 Jul 2023 04:25:36 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.43.86.43]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 11 Jul 2023 04:25:36 +0000 (GMT) X-Mailer: emacs 29.0.91 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Christophe Leroy , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "mpe@ellerman.id.au" , "linuxppc-dev@lists.ozlabs.org" , "npiggin@gmail.com" Cc: Oscar Salvador , Mike Kravetz , Dan Williams , Joao Martins , Catalin Marinas , Muchun Song , Will Deacon Subject: Re: [PATCH v4 03/13] mm/vmemmap: Improve vmemmap_can_optimize and allow architectures to override In-Reply-To: References: <20230710160842.56300-1-aneesh.kumar@linux.ibm.com> <20230710160842.56300-4-aneesh.kumar@linux.ibm.com> Date: Tue, 11 Jul 2023 09:55:34 +0530 Message-ID: <87jzv7oz0h.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Y9vMKLwt33qRL7NkaI5Nazf0tySI8zud X-Proofpoint-GUID: tLhkmpiI1MHPHnV-NJYuPlmn7hd7DB53 Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-11_01,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=594 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307110036 X-Rspamd-Queue-Id: B160E140009 X-Rspam-User: X-Stat-Signature: gonbub6pp8qq1kk19ddxi5rcchs9gm5d X-Rspamd-Server: rspam01 X-HE-Tag: 1689049556-541788 X-HE-Meta: U2FsdGVkX18r/54wyfydFLQHfMeVtzXkPfY7/xyjIBEk5rvfvWZ40mjYvRh80vvOOcydf02PVsYhw9TiG1zyZQAOyfF23MqYBQ4L+P0eo66eNcE7QYIKrclYRVZidMyVgT7D/Rs2H3CHt8h+nWaRUjAuXOjbVgArwE1HolUjnzZ+A3Z7J1y2JeqWp+UoZEeUCkYTHMgAl3DPdqhwf9fNvrfUWlrSbKCT9+Aeo/X0p9JnnI6AKQkcpsxQs4eXtEBzMF6Ixc7Zii+WIxh6ODIdyQRXyGLjKMHGduuGrtEVTCRdwBeEhqdNu4aaP8usinVtajNZJmwXrsinqsBeFgp0GRm+nytqEF3Sgf/Ub4CQynDeP8YicHimjrqE9OKhdgJqxnLkf4N0jKG9BIH4kbjj7Ngi4u03ceuwc/Ea2fPdpks2KxHhVEgJg2UDgSreYkfBhU0MdKZoNf04IngOID8dJtwU1mI7hEb6lZ2n5zarhYDlk7ipVTpTm9BxNRuh4pSjDg6yIo/VIUjPDKVZr4YQz2nQxbok1VLwEepfGRUYeNINk1cIM7qwnjFH0FBmfilOMl+u2tgvvjHMd15NyDBxP7fE1lZTRv40w1R+A1QWgXYPc3QyKKUceux8TKsa1MvQIcgvTbM0rKJjDh7+Bh1B0eK78kOMmglPH2r40XCHhsfWPQisx6KpQGJkXA4NZw+qjvqbtwRj3svBXZbTuwJDjNnwPpffLeS5rXdB4l1gFmCLxLxrjPoFOjbE9/UFbeTJa+qwf/QRHWXVdTeyK9Abbzei1hSd/oJex3mxIXFdP+XImuA2/mZu3fYy4tnB9bufBKFpB5IPUAxx4OLAG8QpLgvL5xjF5n+AvcwmQzrE+8EGE0miZiKDxF0huVVt6dvHoQ6NixQKsh9qSifMD9sFzMsE8yci6wNHBP5lpbCcojHBiAbPK/Yfu9MUr1GqgMNCffVzKB4DOoSvgV2N3x0 s4ZUSTx6 +wZ+nizotWACo/9mfXY6ohoGl61B0wKM6W3f8crT6skI3h4h2n5wgNgtFMYLuZbdmwTobcCfBb9AuKos69Fsd81p8sm+j/vHMKavf4pSIzfBYPHwOPU6ZUs+HzUohM+cut/+M7sCoEOcPn1BCuxZt3Qd/fF/tUezci/Ce3D434Mapb5HZneSxc3FSp6pXmuFpbIaLpnlsz5OsoZMfZaEeszvCDXXYwzQ0zSsru9q6GNNYuAWzCNXkg0CBJcMmWeAxXJTfUVyRwZgjjHPuGcFq34wx3F+V9Yt+tZ0DHCQUpwztyyRWgFXx08H76kXqDb+hg7Rdn/42w5qQRjGNQsy1c5bSwigKQm2vzM0I3jKgjsODERo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christophe Leroy writes: > Le 10/07/2023 =C3=A0 18:08, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >> dax vmemmap optimization requires a minimum of 2 PAGE_SIZE area within >> vmemmap such that tail page mapping can point to the second PAGE_SIZE ar= ea. >> Enforce that in vmemmap_can_optimize() function. >>=20 >> Architectures like powerpc also want to enable vmemmap optimization >> conditionally (only with radix MMU translation). Hence allow architecture >> override. >>=20 >> Signed-off-by: Aneesh Kumar K.V > > Reviewed-by: Christophe Leroy > > Why renaming vmemmap_can_optimize() to __vmemmap_can_optimize() and keep= =20 > it when vmemmap_can_optimize() has been override ? Is that because you=20 > expect overriding version of vmemmap_can_optimize() to call=20 > __vmemmap_can_optimize() ? > Yes, __vmemap_can_optimize will be used in patch 11 https://lore.kernel.org/linuxppc-dev/20230710160842.56300-12-aneesh.kumar@l= inux.ibm.com -aneesh