From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50562C25B48 for ; Thu, 26 Oct 2023 23:05:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99D1D8D0032; Thu, 26 Oct 2023 19:05:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9253A8D0001; Thu, 26 Oct 2023 19:05:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79ECE8D0032; Thu, 26 Oct 2023 19:05:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 667688D0001 for ; Thu, 26 Oct 2023 19:05:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3CCD51CBACF for ; Thu, 26 Oct 2023 23:05:53 +0000 (UTC) X-FDA: 81389146986.23.2EAE3C3 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 455B980003 for ; Thu, 26 Oct 2023 23:05:51 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Eb1gIXVa; dkim=pass header.d=linutronix.de header.s=2020e header.b=RqNiSkrn; spf=pass (imf02.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698361551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=301JXjESu5nnVpLjEelVyjL0FjP4Jn3OGJNIUK28IQU=; b=BaVbKYvWDEv5cqHE/a7JJZymJaCJ2xRAprDCSi8OhszgzcMcOn53ZHuJ3hBGkAcCxW8mr6 JJiz6nRWwgthJDD7OdIfeISc4NfQv1ExieUGfftf53fehbFIw2Vw3Cdtym4fiazSQ5uKwP L6gYrZNwn0K60WG34rF473TeiCecKAQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Eb1gIXVa; dkim=pass header.d=linutronix.de header.s=2020e header.b=RqNiSkrn; spf=pass (imf02.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698361551; a=rsa-sha256; cv=none; b=l+V1dlf+CYfNnQawVqbRYeXv/H9Dwilfh4M4KddXw3BeAT+z2qgPnXqZIhdZRjnqYbAWrG 7+Oa4Et5JSaB4QRfyVOplaBAC/PhMBfFdkwqLXTCFdepgQnr3/gEv+NBt5PCs/9pVhdDvn Jvvzoisxc14IR62MXtej0/edZqh0cfI= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1698361548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=301JXjESu5nnVpLjEelVyjL0FjP4Jn3OGJNIUK28IQU=; b=Eb1gIXVaXmAnj6Vz5I5vcFWzDPXOSmvemJ25H8m6l0iIfUCVbejjE5Y7/gMXNjhx38wFSY RJVefBKehaEbHZC0xz/csfH7mbPsNSfYiCauGm2dkY44hd+k+9U6KMD5ojDdWRkeQJsrx/ OV5SFLjgRLZOJiENHih/gRvsbWHp/OChDTcIMU2L2YOCFQ+alGJLgavDwv76UXYnm4FUqt mexY2UyN7A2yUcVKqUOOjL5oBsfz83nAndyc/X3E1zmQtBIV0PTUFh30pySJK6spbDflP8 y3bd6T8hJ4kPQd3jB2y/dX8ppdTvZDmpjnDFyPySE+c/jTPIO1DJJA2RSkx7MQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1698361548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=301JXjESu5nnVpLjEelVyjL0FjP4Jn3OGJNIUK28IQU=; b=RqNiSkrnkwZTXyqqspVxXRlYFLHhxLB+hajtQnaflb0qL/La0rOh7/J5t3jx5IjGn+PrXi 2bcUxpuqUgAyUpDA== To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v2 28/39] timekeeping: Fix a circular include dependency In-Reply-To: References: <20231024134637.3120277-1-surenb@google.com> <20231024134637.3120277-29-surenb@google.com> <87h6me620j.ffs@tglx> Date: Fri, 27 Oct 2023 01:05:48 +0200 Message-ID: <87jzr93rxv.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 455B980003 X-Rspam-User: X-Stat-Signature: irabtc3m4bhnwtpkzo4h9q7twcpg9cyj X-Rspamd-Server: rspam01 X-HE-Tag: 1698361551-856125 X-HE-Meta: U2FsdGVkX18wyWXExqrnaNqu48gprY8p+3hPnabsBJOxXkHx5bSdKCmfYTwewuFD1/7VYdlfc+y1yg/WpDO+uEo/meH8OZLVHOrQZKcHFTjZeSgv7yYHqUfiR13hJjzcvIoEipVCe1LRpvQFGggB+sA8hiePKRfLQwWeJPJIl3KOiyVRDErFfPbxFlCleEkLYuJc3E6f57fxVfaV+lTJuAmgXK+kXAJKmymnytmb22FnOI84fNFTNpenP2deEB/DNFgfdRm3NEieBpwmqR6TY7cPHiKlyj7kXbia5WuTrV0aETxNwvbd/HO4Zm2DFWfH8mTbxD+/z3aN8sPAJytT4rP0M44eaJ6CJ1/20mNYzkJ3Y6KlNFDm70QyXSRR06Tt+MJWW+7eOu6qmVHUZWl3AqBNWTIcGnudCm10itR6uL6trlh2dfBBpPAwUQv9QIjIi7fGESSWYfUfrxbUGSULRk89HVFiqFsN4s4K7QETEvdQTV3mkkwUKgHL25ef88Xx/B+6yKz6sCni6d/r9GgzYGu9qJJHCSL2clU2d2Etm3A22daWyp934OFiOwBpM++JrKEF5JWjCkYvPr2cZz5dNBJS0i2dkJ60/rwXjHI99gnp0HsmL72FIQ9y8+l8nlwsuVuX9TUp6a+gT8Y23RPc9AN3g51w4NMCgarlh4ZB384qoNUmzZLK4kdTEqVqIhPdT9tlx1xMKk67GRTJ3NZ1kqgBM4bdMpU53RZk3k5BQ0KeL33quQaalb40PQf3QTcUJszXGvy+kEifOX6FBjTPLuertByhIj9pHe8NgLmErld9vv1CzE1p7OSEksc43j922qvh33cwkmJ9ZbGKeiOjAua6SRz+VsSHdITqh65oRDQL/fLu7/NbZYxClDbiS+bUGrzNaQ+eguffRpaqUMYglahR+9QnJBR61wwfymHbySvjF3t+do6Uu3BKtGpB1i6ftBRTpGiIz1hPJtqzDrH P0U2XV92 xlZ0DiQuNlda3a4+C9PSOZUpog+Tv5w46irmUEPE27w3OdCMA0KpupAMbfFqzg5L5R4mJVRfrL1BSv9lafFTekQeZXfnKBymVVDkVTSqAXgHW8/dW2BvM4+ZUsNvokY4yHKd+MVbGvVCt5x7hGM/lOZtjvzADEmHhUgs2l2GdbYo40+oGIGE/j5KVvAQwcxrKNzYG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 26 2023 at 18:33, Suren Baghdasaryan wrote: > On Wed, Oct 25, 2023 at 5:33=E2=80=AFPM Thomas Gleixner wrote: >> > This avoids a circular header dependency in an upcoming patch by only >> > making hrtimer.h depend on percpu-defs.h >> >> What's the actual dependency problem? > > Sorry for the delay. > When we instrument per-cpu allocations in [1] we need to include > sched.h in percpu.h to be able to use alloc_tag_save(). sched.h Including sched.h in percpu.h is fundamentally wrong as sched.h is the initial place of all header recursions. There is a reason why a lot of funtionalitiy has been split out of sched.h into seperate headers over time in order to avoid that. Thanks, tglx