From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F734C4725D for ; Thu, 18 Jan 2024 01:30:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2CD36B0082; Wed, 17 Jan 2024 20:30:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDCBA6B0083; Wed, 17 Jan 2024 20:30:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7D3B6B0087; Wed, 17 Jan 2024 20:30:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C58496B0082 for ; Wed, 17 Jan 2024 20:30:56 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B536120287 for ; Thu, 18 Jan 2024 01:30:56 +0000 (UTC) X-FDA: 81690702912.12.AC3AE1F Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf21.hostedemail.com (Postfix) with ESMTP id 44A3A1C0002 for ; Thu, 18 Jan 2024 01:30:53 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="WcTy/elk"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705541454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pc+ILaAVJlEoymj+17DC4VUG+uclCahcq2+y73NFUpk=; b=5HQUe5pSLhKk3HUsRkuNbze7URoUXuUOFKPSL2Bhj+Y/Nj6t6olrVKBkHlWEnawEYmo8l7 CfHp2JO7O0ftZMb4rEf5U4F8T5YOgHLCBeG3dbjrKxrphKakVjghaUzkhYs8XZYefFE6xs h6UaWnCqh3uRtuQKjn8k2W6rupqvFLY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="WcTy/elk"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705541454; a=rsa-sha256; cv=none; b=OYuhkLs0IQgiCukOFarxUvrahWslu6d8PS5llj+m4Lq5yCPye2o6zjWHtDb8FalOo5S482 ENjV3Ad+nNIdlYbqoWQVlCdGggOa/G9AnWdDRL/oBv+Czpu9aEvKfug/qaD+zWItul05/K cqtPLVSn8C3/RA2RbEZywb0aW9+UUp4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705541454; x=1737077454; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=D229WF9ZvcRgm1yTACUcXfbL9j+/sJR8sCIdjdqxFcU=; b=WcTy/elkdFylVrcEu3/Q8gGO09+Wo8jxWEvGAB4kM6BlqzLOjg33BN4w TcINjFLqnFTKFbMKI+MENA7x8/teLwLgCZjntsZNvIVMdDZZ4ZLD4LuCb Xea2fVy65k9ZM6mxrePIH5tByT3TPHeE6lUuk4cbpqm7UYO4sVSGHBqJU VjlkV+FOsg68TFjsyoW6hajMd/gR+f9axLkieev3qSLPQDmddM72hbSf9 ps2WfyOTGPwX0an2TVIcLvBHTxEUFFLXF7bYLx60shwdtWXSWXwGw3fkt u/pTaRrxzPLFupaT2ToUt+rTiFRCABYBjYpXYd1JTsBXpsRx3iy3+Czud A==; X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="7078974" X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="7078974" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2024 17:30:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="180492" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2024 17:30:47 -0800 From: "Huang, Ying" To: Gregory Price Cc: Gregory Price , , , , , , , , , , , , , , , , , , , , , Srinivasulu Thanneeru Subject: Re: [PATCH 3/3] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving In-Reply-To: (Gregory Price's message of "Wed, 17 Jan 2024 00:34:30 -0500") References: <20240112210834.8035-1-gregory.price@memverge.com> <20240112210834.8035-4-gregory.price@memverge.com> <87bk9n172k.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Thu, 18 Jan 2024 09:28:49 +0800 Message-ID: <87jzo7zay6.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 44A3A1C0002 X-Stat-Signature: mpihho985e3rc7mb4omkctw1xy11b1yi X-Rspam-User: X-HE-Tag: 1705541453-804538 X-HE-Meta: U2FsdGVkX1+1u0t1O5ED827MCbLUKW81b1bpmqKVKKWVrTs2BVFUV91W7JYcvffGcgsBhpyXZ6kOVEbRyuAQNx/36IQJHx4kxS1M+sthbNPwopOecLHkJWSWc17RfRVHS1wGYr3D+sI41WfqX/PJkkJQp2d8vzRacehhrEpJWqXmY7QwAE1cHtUhIbd9SfZsarYTCuZ9KIXKeQP/XUBqF0XZMPPMC0ikPNoquNjoqJKFA6PP9W263wvCLr4YgZ1uH1f8LGCTL6hHIGr0X5XV1Mdev09ZjfwlWKwO4vXf5W0XmMvWrv1djtr+j5/rtNp1fKAWdIMgJLvLnpDO5C6sUBI1Po8+eBbeVX8m30sEBYC/PJyNxCLekLg3W4bx3V7zBZD9d2bMgGkdE10aqn5RlUv9X1lEtSE9jpC3cYw5ocpEdJXHMXgF4cuN6ZbIYcuRFZIql4ASoSYzGbHwH44BuCI248uXuw6EH2JkV08xPNf3YOgfXKqnnlcC9InO25RoVhMiLqCs4bB/ldLB0XMi2drX+cAXVp2rPwQmAduOz2nOl4mBjlrCVJpRRMyk/EoLR9mnEaZlCpL8uq+4Z8hwOyRlni5x8ydCtDWDpYWiUqvjoEZZtlzaZcwZJCfXTl6Nartv7W1sRZKkPRYWtl67t4+pZvqS5yC3dYVrtMfEyLOf7+y2N9eHW1fvCXgKM7hPf6flNDZY6677wVQXf3SOlSoORl9zwZ/Z9rxiD/dOrflurHzGJ7jiqzJUyyBb/wmPbN0pTAxqu/e0Nh8rWcNx5FUQVyp/XTk5ZwQ/Vg2HV1Vinnpj1cYRLQTJZflPyqu2rq5HKLpJrgGOTDRqolBANSLbskBeSMT4Ndi+gJdiJlviWi4ic50L/Orvcj1OrJGpj1yNG77JAC3jWU5uo+0cCxDmINMHGGWZIGGvAFAX3v4teCjdNtwz7jIHhgoop/2EECqCKkopx/hJR0Hshh9 4qK9mXdx D5Q0geqmXRnEfzJg/exlCxfAqKftgEUKv9dg6T4Cu6xe2B61of9HVHHwhie0h681oqG890z8NPSBhtU/GBfgNcLHATTNbjfVPpa2yv+0ljso4Sf8j/K5JPOg4VGdX4ncP8J+uTof7OuEqQ/BOMimIbQ4JOJBFEwAOm7bqaZx0r9aurNfNG9lTNy++oHBIGCbZmWp41Kbi+znWOA8G0W31AEE4jcMmZ8DTJR485U3IOfou9Wn1JMJzN/q2qr3PpWa92zSB/w5QhYvevFllrf5ZHJ2Uu981I9xTv7E/BB7+eFal3/KwIKBxUJPmqPiKjb7oAc/1s1jFL1wrfaQuKKxqJ0uGW7hw65iql13E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Gregory Price writes: > On Mon, Jan 15, 2024 at 01:47:31PM +0800, Huang, Ying wrote: >> Gregory Price writes: >> >> > + /* Continue allocating from most recent node and adjust the nr_pages */ >> > + if (pol->wil.cur_weight) { >> > + node = next_node_in(me->il_prev, nodes); >> > + node_pages = pol->wil.cur_weight; >> > + if (node_pages > rem_pages) >> > + node_pages = rem_pages; >> > + nr_allocated = __alloc_pages_bulk(gfp, node, NULL, node_pages, >> > + NULL, page_array); > ... snip ... >> > + if (delta > weight) { >> > + node_pages += weight; >> > + delta -= weight; >> > + } else { >> > + node_pages += delta; >> > + delta = 0; >> > + } >> > + } >> > + nr_allocated = __alloc_pages_bulk(gfp, node, NULL, node_pages, >> > + NULL, page_array); >> >> Should we check nr_allocated here? Allocation may fail anyway. >> > > I thought about this briefly in both situations. > > If you look at alloc_pages_bulk_array_interleave(), it does not fail if > __alloc_pages_bulk() fails, instead it continues and attempts to > allocate from the remaining nodes. > > Presumably, this is because the caller of the bulk allocator can accept > a partial-failure and will go ahead and allocate the remaining pages on > an extra slow path. > > Since alloc_pages_bulk_array_interleave() appears to be capable of > failing in the exact same way, I considered this safe. You are right. We should proceed with next node here. -- Best Regards, Huang, Ying >> > + if (pol->mode == MPOL_WEIGHTED_INTERLEAVE) >> > + return alloc_pages_bulk_array_weighted_interleave(gfp, pol, >> > + nr_pages, >> > + page_array); >> > + >> >> Just nit-pick, may be better to be >> >> return alloc_pages_bulk_array_weighted_interleave( >> gfp, pol, nr_pages, page_array); >> > > Wasn't sure on style when names get this long lol, will make the change > :] > > > > Probably v2 thursday or friday > > Regards > ~Gregory