From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC3CC6FD1F for ; Tue, 26 Mar 2024 20:25:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84CF46B0087; Tue, 26 Mar 2024 16:25:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6A86B0089; Tue, 26 Mar 2024 16:25:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 676C56B008C; Tue, 26 Mar 2024 16:25:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 506426B0087 for ; Tue, 26 Mar 2024 16:25:11 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1F661A08D8 for ; Tue, 26 Mar 2024 20:25:11 +0000 (UTC) X-FDA: 81940319622.09.6C0C148 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf19.hostedemail.com (Postfix) with ESMTP id 704BF1A0008 for ; Tue, 26 Mar 2024 20:25:08 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OOqFjnsT; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=jani.nikula@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711484709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z/HXG3daqgE0PqwW+2pyU625qFGIVrTBAsyYjuIB5/Q=; b=6sZN7uSZevuKAfcqva0DN6I4qkJA9d/vjMNIiJq5mQV8pVGojlZbB4m8EBuPTr07i62dBv X4Yhq1QGo4X7GpfU7ftUbCkm7LrwYNtnTp+YnVlnpOKuAufsyCW9oHFrme9tz+FEqBFuRI xTPVU4wWIjkFHwgqpMMjFsnj6/UV4Bo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OOqFjnsT; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=jani.nikula@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711484709; a=rsa-sha256; cv=none; b=49Bgi+G5k4vjbuEKKUQ9tCuyXydUy7lj56KBk5/SSawwZ2RIG6gpn2Xb4x8+4Mw/EDva/3 eG2ZDkRI1iX6OoRBq3mqEV2hOyd1pNShOVHySEf50t2CyqLUYCiVeE1H+lByY05GsWq8n4 lcdl7MwSPHgxDcJbcQefzR894gfIChw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711484709; x=1743020709; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=WKb/Rem+q45UacCFCZyCwdPQfAxbGriai4/va9sGbT0=; b=OOqFjnsTz0EYyDTwcuWJIAMlf9kgFoS2G8CVz4XU6X7PQqg6vxIR8L45 awX+gGxXJyX7vkrq3qm32n59go/lo/4wTcsqhwE98fGWAi3hdBN8gy0N6 biB6Ro5zLAtkjs39pgpVf0a8awL23YRpy472G3+bxliF0rSlVSwv4AyL1 KUy26MvRtOAKvIaRq0cXGxhl3VMBDwbenCPkzK4JELwkQmBajeg73Pwgh h2Oz2bVR39Mb9ut2FDGiT/f7Uw5wx9/pfSLF8XhRSjBST/41kfGK7a/5h xqVMH9b6qSGLJMZaA5qkdCGFCLVf4sMlbhkODqVL0dAmO9dWx2tjV+/nb w==; X-CSE-ConnectionGUID: mXp0YrawQruCXQWwdsEtMg== X-CSE-MsgGUID: NQXykhRuRbKZkRXIpWWDSA== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="17288134" X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="17288134" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 13:25:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="16509223" Received: from eldobson-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.55.140]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 13:24:58 -0700 From: Jani Nikula To: Arnd Bergmann , linux-kbuild@vger.kernel.org, Masahiro Yamada , Harry Wentland , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , Lucas De Marchi , Oded Gabbay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jakub Kicinski , Paolo Abeni , Andrew Jeffery , Linus Walleij , Joel Stanley , Alexei Starovoitov , Daniel Borkmann , Andrew Morton , Nathan Chancellor Cc: Nicolas Schier , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent In-Reply-To: <20240326144741.3094687-2-arnd@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240326144741.3094687-1-arnd@kernel.org> <20240326144741.3094687-2-arnd@kernel.org> Date: Tue, 26 Mar 2024 22:24:55 +0200 Message-ID: <87jzlohhbc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Stat-Signature: iosapi3brgwhpqm9p4xigxygeopz4gd4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 704BF1A0008 X-HE-Tag: 1711484708-29586 X-HE-Meta: U2FsdGVkX1/fH98BjSMOLqfAxjc+H5gO+BmNfeVq+kwiQxYPJguAvyEEzChhU0/X/wlZJ+3I+f/opIgRNaeynWaEM5dNqQwAB/fHS/X00ow8luUuhLUL+mrgnQ32faCfEvJwBm4dDikVcvPnd9ToAsdrJdGAVTFRj7jmIXfvIxHuCpqp/cQzasbjyvVmH60dHlbZKhggdFNNOec5Wd581VjDGY9NcobYhKiA/imym6NIqfWGaRnFi5qbJX7ayjw47sOCBn+rrU+OzMmJIcVaUdsGytPuU4wdjBtAfeyCWhswbIJb6FSOkgv5zwCeIrU4VcnUikx2Rr5d+ruX6iOz8YPEEqjUt1wB0l7sD01tJ7WyQd47NuSwW8YSc4ucca2NVGoKs/FmTYSeB2QtKgoRM7pVrAcVUZ0aNJ3xhzFCDAhbt1A+9Uoxf3dKAoLwUTJwhey0PcBQcJ29yzk8q+RnUJpOAsOkjYsvMJ+6sEKIp378qWRWVDwKddIMA3qsSjVctX+RwUHfNeJPVw9a1VgJOO1TJvoIOu9nbYkFtRsCzOwbII4dicnnAiTwCSvpb5KadX9XoTvGnJPoL4AVRhHtQsIip1qMXVWfNZ2kCE4pO2szuY5kJswpCR0/J6YUuPVrVi2Yc2vpsFUstM6qewg4zHYl/cq3qcSDH+Z0VJgYw3fWVL9st77Xq4e5jlquSD3Xud3zvi5iaafl2kp8A29kyWBl14L2OfjbOjcaMaDpF+XhPoKUJRAk+UtElLJCeJgrYiPftbKXk30JDOuTfLwqCKo5xJtlgYOy/18On/6Owa3lLTuxjDl2Pn0t40NxKnbUSz/KdxOt8M61kstAd5m4Ims2R1TJ2j6y7USggjjWIlKLwVgSKRCxUmhAV8lrv3vKvscBpDF04qajeGGqnMTMc+v682+4jFZzQOlucFegt9Gi4i7MpmyOr00YhnJQ7NRW8dQWT/6knEp0TVzymL7 wTG5jK97 3zSOVaSM5D02G0O05MAGBusLNMBaX3T56h+HzBV0lVnioxt8k4nJL2s6b36CZw9AfSDiNggOZFHK334MWLLUVjmsYq9nafqMk09v5PjOBN0PPR1yfKsL0K/UhYcQq3Hwwb1ksA48hUI6sI01PIw6UDL5x7peUm173Yu61IObs9QyJxaXbaS8MMiLzQ6DoPDqWyqlbIiM3W2osp28o8+u5qONTbpquNCwXnZSrYSbzypGcniEwZ+9mZBQi+jWthrL4OmEIjn06A9YfKprHBw+EA2hGIY6egPgSJaTMTjbLcdNiX7fJ2zxo9RIewOaaAUXIH1MLynh5L74CqJCy1vY1H/Fn8APNrqDYxQUwbeAq8orDmFjWni3DD5bToZpRpoDai3CF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 26 Mar 2024, Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default > and we have multiple settings in scripts/Makefile.extrawarn as well as > individual subsystems. > > Older versions of clang only supported -Wno-initializer-overrides with > the same meaning as gcc's -Woverride-init, though all supported versions > now work with both. Because of this difference, an earlier cleanup of > mine accidentally turned the clang warning off for W=1 builds and only > left it on for W=2, while it's still enabled for gcc with W=1. > > There is also one driver that only turns the warning off for newer > versions of gcc but not other compilers, and some but not all the > Makefiles still use a cc-disable-warning conditional that is no > longer needed with supported compilers here. > > Address all of the above by removing the special cases for clang > and always turning the warning off unconditionally where it got > in the way, using the syntax that is supported by both compilers. > > Fixes: 2cd3271b7a31 ("kbuild: avoid duplicate warning options") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/amd/display/dc/dce110/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce112/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce120/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce60/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce80/Makefile | 2 +- > drivers/gpu/drm/i915/Makefile | 6 +++--- > drivers/gpu/drm/xe/Makefile | 4 ++-- > drivers/net/ethernet/renesas/sh_eth.c | 2 +- > drivers/pinctrl/aspeed/Makefile | 2 +- > fs/proc/Makefile | 2 +- > kernel/bpf/Makefile | 2 +- > mm/Makefile | 3 +-- > scripts/Makefile.extrawarn | 10 +++------- > 13 files changed, 18 insertions(+), 23 deletions(-) > [snip] > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 3ef6ed41e62b..4c2f85632391 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -33,9 +33,9 @@ endif > subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror > > # Fine grained warnings disable > -CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init) > -CFLAGS_display/intel_display_device.o = $(call cc-disable-warning, override-init) > -CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init) > +CFLAGS_i915_pci.o = -Wno-override-init > +CFLAGS_display/intel_display_device.o = -Wno-override-init > +CFLAGS_display/intel_fbdev.o = -Wno-override-init > > # Support compiling the display code separately for both i915 and xe > # drivers. Define I915 when building i915. > diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile > index 5a428ca00f10..c29a850859ad 100644 > --- a/drivers/gpu/drm/xe/Makefile > +++ b/drivers/gpu/drm/xe/Makefile > @@ -172,8 +172,8 @@ subdir-ccflags-$(CONFIG_DRM_XE_DISPLAY) += \ > -Ddrm_i915_gem_object=xe_bo \ > -Ddrm_i915_private=xe_device > > -CFLAGS_i915-display/intel_fbdev.o = $(call cc-disable-warning, override-init) > -CFLAGS_i915-display/intel_display_device.o = $(call cc-disable-warning, override-init) > +CFLAGS_i915-display/intel_fbdev.o = -Wno-override-init > +CFLAGS_i915-display/intel_display_device.o = -Wno-override-init For i915 and xe parts, Acked-by: Jani Nikula > # Rule to build SOC code shared with i915 > $(obj)/i915-soc/%.o: $(srctree)/drivers/gpu/drm/i915/soc/%.c FORCE > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index 475e1e8c1d35..0786eb0da391 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -50,7 +50,7 @@ > * the macros available to do this only define GCC 8. > */ > __diag_push(); > -__diag_ignore(GCC, 8, "-Woverride-init", > +__diag_ignore_all("-Woverride-init", > "logic to initialize all and then override some is OK"); This is nice because it's more localized than the per-file disable. However, we tried to do this in i915, but this doesn't work for GCC versions < 8, and some defconfigs enabling -Werror forced us to revert. See commit 290d16104575 ("Revert "drm/i915: use localized __diag_ignore_all() instead of per file""). BR, Jani. -- Jani Nikula, Intel