From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C69C25B7C for ; Thu, 23 May 2024 11:14:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB3AD6B007B; Thu, 23 May 2024 07:14:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C640A6B0082; Thu, 23 May 2024 07:14:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2B486B0083; Thu, 23 May 2024 07:14:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8E2BE6B007B for ; Thu, 23 May 2024 07:14:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D5ED81A0557 for ; Thu, 23 May 2024 11:14:05 +0000 (UTC) X-FDA: 82149401250.26.26998B1 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf30.hostedemail.com (Postfix) with ESMTP id 7ECE180011 for ; Thu, 23 May 2024 11:14:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b="TrAFcD/0"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716462844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RQkvd78utY4Ja+S0DO/1Mye5FaeMmZbhGPyeP5EJKQQ=; b=t8CTdCYMkkhQ1mOpLTuyVGunzGHaFL/QrSUf5/jVVssSLFJ2Ro1r6WoWHTcn8GuqnDkA46 GTgvyPoFH4QOyCOewvNpjS67tmu+oKeZEFJQ+v89CVM1t2ZfxRQc5Pcq4E+qLOH//OnwV/ An/3I5Y7d9/ZU4RTcVN65hQOCBKM060= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b="TrAFcD/0"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716462844; a=rsa-sha256; cv=none; b=i8GH5RyV20XC+ybe1CAOJ9lh0PJ8MzTu3jt2np/UYVF6sYTsdZyLg6vongsZQt1W7tFMId eRr7RShhYqOAIbwLGrPu1DgarKZ7QVbSbNyOtvjBcXplI0xR7KsMHjCyEd8JWCLXa1XwjB 0wXYCVWNzPAXKHAq1PY5rTFrKsGd3jY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1716462840; bh=RQkvd78utY4Ja+S0DO/1Mye5FaeMmZbhGPyeP5EJKQQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TrAFcD/0oCSj4bONcbgtSXsgS11T7S6E6WEE0gffpW7ra3PdygToDHYnWt9FP325X Ulu0bqi0OxVHifCazgqTPTcv/aaBzA/83J1DT67GuP6P4kjWTmxYpR3k5d8QUw5SLX KaBhSbgX+yGymHJf39ImQ6bnlzCPqhwGCGOmHgS0sHnNQgFIAZ6faJ7xj1yh2/HfZ9 /Z9LFLWzTrGlhqhCpc9jNxdoVnW04Z3oqkCtkFgdgatmkjO7vuIyMxPYAtcwoYLtH4 NkZDz2N+aA5I64TWM3LiovfgstkBhV29OKuQ0ghCtOqMnTp1QDGg0kge9VdLNWKmjf eyL0seoYf1YEg== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VlQXk23Vyz4wcK; Thu, 23 May 2024 21:13:58 +1000 (AEST) From: Michael Ellerman To: Eric Chanudet , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Mike Rapoport , Andrew Morton , Baoquan He , Nick Piggin Cc: x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Eric Chanudet Subject: Re: [PATCH v2] mm/mm_init: use node's number of cpus in deferred_page_init_max_threads In-Reply-To: <20240522203758.626932-4-echanude@redhat.com> References: <20240522203758.626932-4-echanude@redhat.com> Date: Thu, 23 May 2024 21:13:55 +1000 Message-ID: <87jzjk3hn0.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 7ECE180011 X-Stat-Signature: 5c75nhghmnafg14f7a1w5mp6wfn5e8yf X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716462843-933661 X-HE-Meta: U2FsdGVkX19XMORNqRaaFwjOF3CeCZ/OwMkIdyfxeotCSxomVlkYvTbpPxpogaVOkgxlpRSIKJxXXEHMYZZF1k5KmIhh5SLhIoDg+KrXIRwyGXOID3ze53IR6+TeAcmTQeYlwgLA6QKJVDCLXPQkfeQ1DVWcFxXkGMa90HxLEssgLUMtM2NIYWn9FIbNhpG3bNlyiy7Z5OEdhGSwsvrUktG7EA8yTCpdGwt5Kpatnzf3DWzE0BfEBl/bzX/2UYudkiqTZMXwJQJ1dRmsUI/lxIAa2THkVuu0GGFWx/z65TG8vEkZe5W62bQddWw4NEuN+5g9mR//z3bVXJFUl7m+TA8HLkoygp9j3zclLcZPHZjM0OtKoBh0wPddvjyQC02FTKhfMHSCcl/A5GYeT43rXZbLtNwjx5HMKXaESGueGnGqH5pcee4AB2k8Ag46IPAonc5PfBLw3ucHewFdG1PI0ILPetpU/VN3AEofZ8ibArWt67m5nr8bOcj0e2Gi0Swcsb3huZLnVSnsOR498Y5ipY3piZMdUcktbHJfFoelkD6B4dlcvwbYnWhXiyL8QgRJDkdvDGdaDC+tYBzsttcjiN0NbIH2A2yRSP+flFVjbQEekf402Yr/MeJS9VZVEDlo1djsF20du9hL1ulqhkw471YR1+eaCT2AdPuq/DoO9nxUfrw7qYTlKqhwcKhCOvoD3g63rJc4mffDWG1PgHnzEfSxXCypgHAvg4AoWvzEOFkpYZrlfjsYDqjWZmGYqLuPtpi8E0taiORimy9BAbJrJt089V6ra9moPFXlwcmUqzmTny6JGJDaV54qY2QJiP/su3ySQ622sSCw22myXKpV8sJgbtD4IWyBjYr7ZCEp65RbQ08qsf3uS+tZ2B4x9R+NmzorpI1cDvn7OCnBMuVf38h3iGVM8Bu7BvyAmgcmUWJAIJBwIkxCFWs/6N/8087XCb9yi7hX33Bstym5lFV xGtjOBgQ lOFROoiyZxycZVBfIRXZZwrAp5e1BTDyp+Q6vnfY2ZaE2ioUMjcUpCzBqnUntoQVB1q1NrNc1lDVBqK8ywM/xT3DV9O242K7r1zfzQSYca3SUlXuRWDCM2oDiMsD/8ZUFhbYu1S3bAQ56vFcSs6kWdV5TuPZ/QPQGfTa9pS9YG+V2YOxpTpWbxHG9NbgEmeBKEcWwVcGv74BcKe1Cj9FxmgR3AA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Eric Chanudet writes: > x86_64 is already using the node's cpu as maximum threads. Make that the > default for all archs setting DEFERRED_STRUCT_PAGE_INIT. > > This returns to the behavior prior making the function arch-specific > with commit ecd096506922 ("mm: make deferred init's max threads > arch-specific"). > > Signed-off-by: Eric Chanudet > > --- > Setting DEFERRED_STRUCT_PAGE_INIT and testing on a few arm64 platforms > shows faster deferred_init_memmap completions: > > | | x13s | SA8775p-ride | Ampere R137-P31 | Ampere HR330 | > | | Metal, 32GB | VM, 36GB | VM, 58GB | Metal, 128GB | > | | 8cpus | 8cpus | 8cpus | 32cpus | > |---------|-------------|--------------|-----------------|--------------| > | threads | ms (%) | ms (%) | ms (%) | ms (%) | > |---------|-------------|--------------|-----------------|--------------| > | 1 | 108 (0%) | 72 (0%) | 224 (0%) | 324 (0%) | > | cpus | 24 (-77%) | 36 (-50%) | 40 (-82%) | 56 (-82%) | > > - v1: https://lore.kernel.org/linux-arm-kernel/20240520231555.395979-5-echanude@redhat.com > - Changes since v1: > - Make the generic function return the number of cpus of the node as > max threads limit instead overriding it for arm64. > - Drop Baoquan He's R-b on v1 since the logic changed. > - Add CCs according to patch changes (ppc and s390 set > DEFERRED_STRUCT_PAGE_INIT by default). > > arch/x86/mm/init_64.c | 12 ------------ > mm/mm_init.c | 2 +- > 2 files changed, 1 insertion(+), 13 deletions(-) On a machine here (1TB, 40 cores, 4KB pages) the existing code gives: [ 0.500124] node 2 deferred pages initialised in 210ms [ 0.515790] node 3 deferred pages initialised in 230ms [ 0.516061] node 0 deferred pages initialised in 230ms [ 0.516522] node 7 deferred pages initialised in 230ms [ 0.516672] node 4 deferred pages initialised in 230ms [ 0.516798] node 6 deferred pages initialised in 230ms [ 0.517051] node 5 deferred pages initialised in 230ms [ 0.523887] node 1 deferred pages initialised in 240ms vs with the patch: [ 0.379613] node 0 deferred pages initialised in 90ms [ 0.380388] node 1 deferred pages initialised in 90ms [ 0.380540] node 4 deferred pages initialised in 100ms [ 0.390239] node 6 deferred pages initialised in 100ms [ 0.390249] node 2 deferred pages initialised in 100ms [ 0.390786] node 3 deferred pages initialised in 110ms [ 0.396721] node 5 deferred pages initialised in 110ms [ 0.397095] node 7 deferred pages initialised in 110ms Which is a nice speedup. Tested-by: Michael Ellerman (powerpc) cheers