From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A56C52D7C for ; Thu, 15 Aug 2024 13:41:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 569966B00F7; Thu, 15 Aug 2024 09:41:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5198F6B00F8; Thu, 15 Aug 2024 09:41:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DFD56B00F9; Thu, 15 Aug 2024 09:41:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 13B8D6B00F7 for ; Thu, 15 Aug 2024 09:41:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8480BA8C20 for ; Thu, 15 Aug 2024 13:41:26 +0000 (UTC) X-FDA: 82454591772.29.74B96E4 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf04.hostedemail.com (Postfix) with ESMTP id BCD9940004 for ; Thu, 15 Aug 2024 13:41:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=vtFlbMjn; dkim=pass header.d=linutronix.de header.s=2020e header.b=69CflsgF; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf04.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723729231; a=rsa-sha256; cv=none; b=r2kH8huuC5sVD8CrTOw24PkH3a6kSu4dvSrWWdDR9PjYd4LJ23qGG2LfSbv6QyLZoLgGPG 9BI61Bd3JZep7Gfe/MqJP38QTxWvKDKcJ519oyMJFVecZjwO1ZdBHeyP1ZeVxfNCNyGA+g nwfjqNxe0S+FXEHWMqswRBbh/Xgtyy4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=vtFlbMjn; dkim=pass header.d=linutronix.de header.s=2020e header.b=69CflsgF; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf04.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723729231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nUPq7nTcZ/5rB57N+BBqv8C/kYVFpDlbnSC0IU4n96M=; b=MexBWS6CC6h5zhGDzF7kpiYEyiMDO5jKTPSzAKcFPkQyH49hK+KQgHpBA+KgFmxSARpQ2r SWnnJVh9N+enCCpuz5YQRboVJxgebAETz2eU2nkOx3LlvdbPTMLaOUK0NXFXs23mDXzi0I DsOi7jrd617ZAsMzNxwwyQ/G14J6Sfw= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723729282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nUPq7nTcZ/5rB57N+BBqv8C/kYVFpDlbnSC0IU4n96M=; b=vtFlbMjnttTNEK6DwcBO/ep/1+D5odt8EKylE38aUyYa6fbrCocecsx9NQuPf6y5yAVv/8 el6JhM4lL8oeQ/FGZ0J9tJmMj3jIl1QefPLFaFufjSfHp++orcg4w2UOtmDuVliXpclK3N hDEaXwAOEGzFHwH49JX54vsHHjvTulvXGhtBlBCTnJHvBi8MAAyyQ2dj+X04eIdOwuViyg ItLeyE1iq2S94j9j1VDFHxmXi2MxwPaHnlWaVnxpQAdCRefc7mtY+iBI2HhH3ay2GO9xwr 3zhwuShYns5oWv/hwhKhfXmW5z+5Su9OGa7M+TfrYaaBr6mn0q4Ah+UBuwQsFw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723729282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nUPq7nTcZ/5rB57N+BBqv8C/kYVFpDlbnSC0IU4n96M=; b=69CflsgFp4EQ2HSJQhGLkJXTsuc003qsFjiyDb0DxnOcAGXsvfATfmFrWCKigUDGMiA0Ep 9/Mn8wZyaWjPQ+Dg== To: Christoph Hellwig , Alistair Popple Cc: Christoph Hellwig , Max Ramanouski , x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() In-Reply-To: <87wmkjnqi4.ffs@tglx> References: <20240812203538.82548-1-max8rr8@gmail.com> <878qwzpfbi.ffs@tglx> <87le0zmhdp.fsf@nvdebian.thelocal> <87wmkjnqi4.ffs@tglx> Date: Thu, 15 Aug 2024 15:41:22 +0200 Message-ID: <87jzghnbst.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: BCD9940004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: q3hu3oh874mksyez7pt5tfirou4gnfh1 X-HE-Tag: 1723729284-876154 X-HE-Meta: U2FsdGVkX1+CkX0wpZoQPS8xWg57ifBMPoHs9QEw2lohliOB6To22eDwrGploaH5R7iyvkK+NmudW/f2Z2kJkWcQbR6LePqoWM0sPLG5ml8mXfHAa6Kv+gPklAm1aRcKsy1ivHeHbljNaWqPxJLH8OBFezTz+OYEiwITgCRK29n0Oo3OAQ11tmr/7bSj8zhbxhYmq0vAQ91yrxbFihSzjMgEsxYLBzme7P2eiLqwd8/3vKhQbap9I+F7r15wTlmnH941iKPlkz4vOjWR15vyHT14wE74QXpjDqJBj0K1c9eibmHJcU0SD1r9Bv5b6dzdaX4vvWJTJLZtquSZ1CAZMxTpq/8nYinPgKyHk9qUI5od7LNLIGE9CPTDzXw5bZFeeah6BDFgVNY7TNshezQ2VMJDnv81jMTGDmQ7p4Bt0hyuAkPTtkDhMosSuypGRlfbHUaQL+A9sN4q1MaITvPJq5jappFV6go9guREcB/NZOudKgmgRUf5rrfe4qbb5RVrUT7VUKQEnCHuAZm2y/IVl7UdiabGw787WMQVjUgXvoB7sSZUSKUETwxV27Zbt9/Hu8FpY1KLBaNLLKCQGoFUQwfcnaUoWLt8T8ksfZXy0NKZfuaG2CxO6koBjf5QtJ1lF9pleFxtwAun1XMJLY/LrnrNPOLNxRpCyir6+MsvdxG2BioRvFbNzLHgrys/XY/5k0cWGUojUfT99fu4wh1mcJpE2JGZ7M1jr1rlP9ssryS5sl0xA3Mp86C246DbGHcgmcoaOI9dIyua2r9uniSPCBRv/qF/C0+s6UH+6lNDB2EQ5o9dkwNArdvl4RBB6CkMsXF2TR9C6r4AsCbdQiBFeBNXupFlpAGvuHq9YgXuumFMM76cjYdiOiOAe1TrIUkTCVvgeH3F66Kenk125pbqhRjSN9Iat+djZ89FIIBOTDvdtyCeV2PsXSGP8vbBGKNQ1Twz60c/ArEliJAN6Yt 4s0RcMyd 2WpIp99UnchpHZ5ryToZdqiVzS6Z4KSBCeIfdHQhB0pda0Y8V1TinlK1sistC6BZvr765iERfxTxp8HfsMjnXl2PRkwcUswGFRQncOjntRrcH8MABIoy0DYpzGxYBtN7duLFQhn0jj2YE2MCW3y66SNhbsmiWTp/x6wk4no/6nWcDPqzwUTtZr9276Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14 2024 at 16:11, Thomas Gleixner wrote: > On Wed, Aug 14 2024 at 05:16, Christoph Hellwig wrote: >> On Wed, Aug 14, 2024 at 10:08:23PM +1000, Alistair Popple wrote: >>> I would tend to agree and had the same thought when we found this. At >>> least some kind of message (WARN_ON, WARN_ON_ONCE, printk, etc) would >>> have made the issue we were debugging much more obvious. FWIW I have >>> tested running with a WARN_ON() there and it never fired except in the >>> bug scenario. >> >> Various architectures had either an early ioremap variant that got >> silently ignored here, or magic carveout that don't get remapped at all. >> None of this should currently apply to x86, though. > > So I'm inclined to have: > > if (WARN_ON_ONCE(is_ioremap_addr(addr))) > return; > > in the x86 variant then. Max, care to provide that with a reasonable change log? Thanks, tglx