From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A018CD3448 for ; Tue, 3 Sep 2024 16:15:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A61068D01A6; Tue, 3 Sep 2024 12:15:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EA388D018A; Tue, 3 Sep 2024 12:15:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83C988D01A6; Tue, 3 Sep 2024 12:15:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5EF8E8D018A for ; Tue, 3 Sep 2024 12:15:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D96F0140620 for ; Tue, 3 Sep 2024 16:15:57 +0000 (UTC) X-FDA: 82523928354.19.4DEBE4C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 88AB74000A for ; Tue, 3 Sep 2024 16:15:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1tD2r3Ex; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8wnYF0FF; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1tD2r3Ex; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8wnYF0FF; spf=pass (imf17.hostedemail.com: domain of krisman@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=krisman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725380080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AXur40dr6oJg+rkmyFjm1pAR/rLEyXQXabzhNZLheUg=; b=wyBYCcbZU1q+u25Bhwswb8ZAiMKPbSANFAiM7HwwJrXOZuwZ7QgpyCNFEMajJkwYkD7VAD /cPLvYj/6tHCoAQsRpn0VQ4llyVzAQmqTKKke2u1tlPQW2aNNif1r3bB7de00Zvo0k4hgY fdOy9Jw+tZ2omHrJgiMLKz48rraGckg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1tD2r3Ex; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8wnYF0FF; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1tD2r3Ex; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8wnYF0FF; spf=pass (imf17.hostedemail.com: domain of krisman@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=krisman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725380080; a=rsa-sha256; cv=none; b=B1HZzmXISI2RNVtzn7o+OI0YYPWmTUMCvrI4UNbaTgsCCqXRQxC9lCVTMwfbxMGHVzMctO xbK+Vp3DFaaSmx3a5uA8y9sUNzlvOiU27Eds+d3tZC7LB2se7xeDLz4vKxGIMG4E6sdV/I 2AB9qsf1U4CXnOcO+VzDXMlULeNRxPk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B71B921A43; Tue, 3 Sep 2024 16:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725380153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AXur40dr6oJg+rkmyFjm1pAR/rLEyXQXabzhNZLheUg=; b=1tD2r3ExVY87qinoFJQz9t9WbudP5EuPQNvH+UOy61VmsEn7rapqaCdQ48hGOHIvKqPZtN iGWsllBF24upTmYJ21drPLputS5oC0F7vf9tscwwQignHrO8j5ZshLJ2JyxqFMmQSMlBP9 fGO9owstxV6lwDp6iYRxLWK3dSeWaeE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725380153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AXur40dr6oJg+rkmyFjm1pAR/rLEyXQXabzhNZLheUg=; b=8wnYF0FFNltu1jN/0MLW2VO/+Bcy2ICUE3C0ZNKKIF80/ikgPviplk2983UdkrnDB20Rr3 tbeDtgEzhlambhBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725380153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AXur40dr6oJg+rkmyFjm1pAR/rLEyXQXabzhNZLheUg=; b=1tD2r3ExVY87qinoFJQz9t9WbudP5EuPQNvH+UOy61VmsEn7rapqaCdQ48hGOHIvKqPZtN iGWsllBF24upTmYJ21drPLputS5oC0F7vf9tscwwQignHrO8j5ZshLJ2JyxqFMmQSMlBP9 fGO9owstxV6lwDp6iYRxLWK3dSeWaeE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725380153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AXur40dr6oJg+rkmyFjm1pAR/rLEyXQXabzhNZLheUg=; b=8wnYF0FFNltu1jN/0MLW2VO/+Bcy2ICUE3C0ZNKKIF80/ikgPviplk2983UdkrnDB20Rr3 tbeDtgEzhlambhBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7615013A52; Tue, 3 Sep 2024 16:15:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aY3OFjk212ZdfQAAD6G6ig (envelope-from ); Tue, 03 Sep 2024 16:15:53 +0000 From: Gabriel Krisman Bertazi To: =?utf-8?Q?Andr=C3=A9?= Almeida Cc: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig Subject: Re: [PATCH v2 6/8] tmpfs: Add flag FS_CASEFOLD_FL support for tmpfs dirs In-Reply-To: <20240902225511.757831-7-andrealmeid@igalia.com> (=?utf-8?Q?=22Andr=C3=A9?= Almeida"'s message of "Mon, 2 Sep 2024 19:55:08 -0300") References: <20240902225511.757831-1-andrealmeid@igalia.com> <20240902225511.757831-7-andrealmeid@igalia.com> Date: Tue, 03 Sep 2024 12:15:52 -0400 Message-ID: <87jzfshfwn.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Stat-Signature: icadxk8nhp1u1rxtkgrjpnqps3r1jhmu X-Rspam-User: X-Rspamd-Queue-Id: 88AB74000A X-Rspamd-Server: rspam02 X-HE-Tag: 1725380155-968199 X-HE-Meta: U2FsdGVkX19Mv/c4UtrDsaC0ObAdYp9GHnCeKc+v8MWjijWFqXYNGn97AwgS/RlNGIxsbtArspN2FJo6q4jzbK6ffvRi3izFglrHICqDhOYcDzJyvV/2OXGSdmWfOia8pCFjYPnR70Ay5R99tUbky5i3a0AF83YjdQc6pGbG8tUcElRIyvNplwbBYPVVvXSDLFFn5y/4YVj7bXZDexFuFQR45bB+l51VlXUYih6XqZBjYOGCHoIXflinBGbGAJYW9v5rZJcLZqt2CorcFH/eUi1pVM5Oovm6vgyQL5ojst44+i2ZOjxauuHl3Wqaq8koMFT+jbxwtwzFRKu7vATkEFXQEcjEnSAj4+n147p4BAJUcpqpEi5rRMvcY9zI6L232FcuS9NhU3DXrNrzTXc5FSyFXSGMYAJrsPtgmtYKrYJFp9ZwdjYXKsE6LP93bHhv/18uNsDEpK8PcdPZn6EeSIlNUQNqLR/nL0QZa8N/xRUoJ6dbS2MlQcFcIlSqAKDaARwhdabPFtWkilNB/zdY0Ic3MOxpbDvIpi9zD4S6v+ZdqhtcLhEnk6brGO6iu2nXKM8sPsCmiSBiIQiJleioszPBusdv1AiQVD/M2VFxtYq0c955TFGDoFGCzXlCwZuvQzDTHfnf+4upxoUMRG4UiVHVPUxBJ1ON0l/uq3uXesJ1kh6KTM+UTJuraaFjQDUN3SiOFoNKpMjjo6ww86BSgwJWsrZbDVGxJv5+cn4ghJg4og1ML06T8pTNWdkpcUSskNrOPD4Qx473yWjOf/BS5rjNqTmFeudjOFhP+RK/kUzAJevU1b00ERro3ziBEAarVFlCbIeNlYcBpXqWvz/ix5wodz4NJIO7dakZwwuVaJqSsdestQ5Wo5v5o2S5YscpwDsJKBXZr1GOjpQWHzJV1QwkW1cX+SkE2j+YWzDUmGCax8xuiY5ePCMmsuZZJTAVoklC9DcpGcZ0Dfmw/jP 2AH3t2dB 62I6Pq7sGdEoJ52G7h1z/FehQyrlCMSMGcJa5Nx+6VJouvglFWxVoyo+H1W/jROJ9oGCsqluf25CrHO9Vb9/A3tjBGekVgjsvkzWEPuUKb82cdmATWPWaPzuko26YmBqNl0YLKF6dtdwUN/X+oFCxd7fYazHa7ZQ+NLD7nas04nANK4lTfmMBCfaGKwVYrrDADP8uFev7SdqOqCLqHW1Ak9Yac+HL8s+0BfHOLoj6ohRgoGxQKCqIhterzdI3njUgZg3pAqdGgo5mS/rLI3s+bStGOcrNpuFjGwz5o/U7nW8wPW+gVT/w+P00q9rFe2LdervNAckswHHI7k7+Yx/AZG3NeekI+UA2nXfqyzkZIdqzGa0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andr=C3=A9 Almeida writes: > Enable setting flag FS_CASEFOLD_FL for tmpfs directories, when tmpfs is > mounted with casefold support. A special check is need for this flag, > since it can't be set for non-empty directories. > > Signed-off-by: Andr=C3=A9 Almeida > --- > include/linux/shmem_fs.h | 6 +++--- > mm/shmem.c | 40 +++++++++++++++++++++++++++++++++------- > 2 files changed, 36 insertions(+), 10 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index 1d06b1e5408a..8367ca2b99d9 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -42,10 +42,10 @@ struct shmem_inode_info { > struct inode vfs_inode; > }; >=20=20 > -#define SHMEM_FL_USER_VISIBLE FS_FL_USER_VISIBLE > +#define SHMEM_FL_USER_VISIBLE (FS_FL_USER_VISIBLE | FS_CASEFOLD_FL) > #define SHMEM_FL_USER_MODIFIABLE \ > - (FS_IMMUTABLE_FL | FS_APPEND_FL | FS_NODUMP_FL | FS_NOATIME_FL) > -#define SHMEM_FL_INHERITED (FS_NODUMP_FL | FS_NOATIME_FL) > + (FS_IMMUTABLE_FL | FS_APPEND_FL | FS_NODUMP_FL | FS_NOATIME_FL | FS_CAS= EFOLD_FL) > +#define SHMEM_FL_INHERITED (FS_NODUMP_FL | FS_NOATIME_FL | FS_CASEFOLD_= FL) >=20=20 > struct shmem_quota_limits { > qsize_t usrquota_bhardlimit; /* Default user quota block hard limit */ > diff --git a/mm/shmem.c b/mm/shmem.c > index 0f918010bc54..9a0fc7636629 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2617,9 +2617,26 @@ static int shmem_initxattrs(struct inode *, const = struct xattr *, void *); > * chattr's fsflags are unrelated to extended attributes, > * but tmpfs has chosen to enable them under the same config option. > */ > -static void shmem_set_inode_flags(struct inode *inode, unsigned int fsfl= ags) > +static int shmem_set_inode_flags(struct inode *inode, unsigned int fsfla= gs, struct dentry *dentry) > { > - unsigned int i_flags =3D 0; > + unsigned int i_flags =3D 0, old =3D inode->i_flags; > + struct super_block *sb =3D inode->i_sb; > + > + if (fsflags & FS_CASEFOLD_FL) { > + if (!sb->s_encoding) > + return -EOPNOTSUPP; > + > + if (!S_ISDIR(inode->i_mode)) > + return -ENOTDIR; > + > + if (dentry && !simple_empty(dentry)) > + return -ENOTEMPTY; > + > + i_flags |=3D S_CASEFOLD; > + } else if (old & S_CASEFOLD) { > + if (dentry && !simple_empty(dentry)) > + return -ENOTEMPTY; We don't want to fail if a directory already has the S_CASEFOLD flag and we are not flipping it in the current operation. Something like: if ((fsflags ^ old) & S_CASEFOLD) { if (!sb->s_encoding) return -EOPNOTSUPP; if (!S_ISDIR(inode->i_mode)) return -ENOTDIR; if (dentry && !simple_empty(dentry)) return -ENOTEMPTY; i_flags |=3D fsflags & S_CASEFOLD; } > > if (fsflags & FS_NOATIME_FL) > i_flags |=3D S_NOATIME; > @@ -2630,10 +2647,12 @@ static void shmem_set_inode_flags(struct inode *i= node, unsigned int fsflags) > /* > * But FS_NODUMP_FL does not require any action in i_flags. > */ > - inode_set_flags(inode, i_flags, S_NOATIME | S_APPEND | S_IMMUTABLE); > + inode_set_flags(inode, i_flags, S_NOATIME | S_APPEND | S_IMMUTABLE | S_= CASEFOLD); > + > + return 0; > } > #else > -static void shmem_set_inode_flags(struct inode *inode, unsigned int fsfl= ags) > +static void shmem_set_inode_flags(struct inode *inode, unsigned int fsfl= ags, struct dentry *dentry) > { > } > #define shmem_initxattrs NULL > @@ -2680,7 +2699,7 @@ static struct inode *__shmem_get_inode(struct mnt_i= dmap *idmap, > info->fsflags =3D (dir =3D=3D NULL) ? 0 : > SHMEM_I(dir)->fsflags & SHMEM_FL_INHERITED; > if (info->fsflags) > - shmem_set_inode_flags(inode, info->fsflags); > + shmem_set_inode_flags(inode, info->fsflags, NULL); > INIT_LIST_HEAD(&info->shrinklist); > INIT_LIST_HEAD(&info->swaplist); > simple_xattrs_init(&info->xattrs); > @@ -3790,16 +3809,23 @@ static int shmem_fileattr_set(struct mnt_idmap *i= dmap, > { > struct inode *inode =3D d_inode(dentry); > struct shmem_inode_info *info =3D SHMEM_I(inode); > + int ret, flags; >=20=20 > if (fileattr_has_fsx(fa)) > return -EOPNOTSUPP; > if (fa->flags & ~SHMEM_FL_USER_MODIFIABLE) > return -EOPNOTSUPP; >=20=20 > - info->fsflags =3D (info->fsflags & ~SHMEM_FL_USER_MODIFIABLE) | > + flags =3D (info->fsflags & ~SHMEM_FL_USER_MODIFIABLE) | > (fa->flags & SHMEM_FL_USER_MODIFIABLE); >=20=20 > - shmem_set_inode_flags(inode, info->fsflags); > + ret =3D shmem_set_inode_flags(inode, flags, dentry); > + > + if (ret) > + return ret; > + > + info->fsflags =3D flags; > + > inode_set_ctime_current(inode); > inode_inc_iversion(inode); > return 0; --=20 Gabriel Krisman Bertazi