From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B97C5B549 for ; Wed, 4 Jun 2025 16:57:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DE046B0612; Wed, 4 Jun 2025 12:57:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38DDF6B0613; Wed, 4 Jun 2025 12:57:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 258D76B0614; Wed, 4 Jun 2025 12:57:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 05AC56B0612 for ; Wed, 4 Jun 2025 12:57:10 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A8D72B720C for ; Wed, 4 Jun 2025 16:57:10 +0000 (UTC) X-FDA: 83518323420.24.B09FE08 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 52DE41C0006 for ; Wed, 4 Jun 2025 16:57:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C21mvKqk; spf=pass (imf20.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749056228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gw+d+3S7IYA06FhUQyd+hYu00sNtRnUnl76qT+h9VuM=; b=t73+ydP54oIouh/Rw/UnQnnG+Le4oCUkvzQz2qc+ASEawaRjRvQQQtZlDwkdlIGs7bktGz 3caPxmxHoyMtNZEm1USSQSmxrAEL2GN4rIki6glgcd0QQbPeMlKMjD2ynu6HUapzmOJmh5 GdDvWGLeAcKPuCxg1FMLOj+kBNJ37A8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C21mvKqk; spf=pass (imf20.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749056228; a=rsa-sha256; cv=none; b=I4zHmJjhMlM+ZmR7yGgjryl4BZzIrFF5dSX0UjJ7lgpmIhIOunAeKSqAVyPevKzpiFoDaU /eRrRWX/ZrocUQsflNiXGbejq9aAhU8A1PRQskIaGEC/E3ymDMKQfBBvuvLWFdiMTC1kUB d3TcETpm0OZ1bjJ0IHR4fUUK7pe/ju4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749056227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gw+d+3S7IYA06FhUQyd+hYu00sNtRnUnl76qT+h9VuM=; b=C21mvKqkLS0A/YrHS/EtdqzOYjc98nNuFpGO1bflNmzD7R9KSJTSTkheFTCtQV9dZaMjrM Ecd/InFBn1gFdVjXuNrYkzZAJvI3JnKs+tNejMEM3B2EKgMiKe36Qx53mxuQJ/tWlBmAAT IhvAPgpcB1SQ7LAncp3Q6sET49Iuczo= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-VKIttfuOMiuiRAFgsooMig-1; Wed, 04 Jun 2025 12:57:06 -0400 X-MC-Unique: VKIttfuOMiuiRAFgsooMig-1 X-Mimecast-MFC-AGG-ID: VKIttfuOMiuiRAFgsooMig_1749056225 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ad88ac202c0so7631266b.1 for ; Wed, 04 Jun 2025 09:57:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749056225; x=1749661025; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gw+d+3S7IYA06FhUQyd+hYu00sNtRnUnl76qT+h9VuM=; b=prpU+Jm3dLNADfB65aQbzEuCPQZRbXc+Ir/gGN6UXHqq32FPXjpye6lmns8Gjh5s/1 61NDRN76Cw4qacqCSCBiq5KYCa0vcGSczh/sBBJTzMPjZg4ytwdL/p52boRKpvi4oDkp MHvDGzt09B8omn96BbwDMr2e14ZiPGYPuuSMT6Xc72DFaZprUpQFtbWZkt0Qio8JR+fe TbzPE3ctNIkhOQ9ATAnNN1PP+ghi7Vw/jMUm0QnXHj6MErEMMJyxBSNPY/6TLokYG9JM hdLdeX2NFUruqU+n4n+M7IQsfjOX1tidSB9ZUy0TukEK9YNuWTLjwW8cJOidXU/hvAXZ 0gig== X-Forwarded-Encrypted: i=1; AJvYcCVbZFHRXmpK6CKT8sCBIsVWNUWs5s+va68fQKU9vYOZEesOPCbJbT/ZNiC8/njHwLg/lSHVlKcz6A==@kvack.org X-Gm-Message-State: AOJu0YykjLyvQFHdjpo5hpLsInFhO0Wanpc0XcJXpdisUnxA9sEtbZIw J+t56/axzqJjPiGNZOc3eg0XUwCJ9u6VA3tmpwRAtEkFe+hGU+6F9n0J6QCSoFA5hE+lTpb8Xfy OqL1fo2HkLEahk2varIu1z+YBV99v4HGaPMCLpGpeighJUtpQ5b8C X-Gm-Gg: ASbGncumbhYoksYsMpNEnmsO4r+Ov88+/vcS+Wg+dneD7PgjIBeDA84rykBjevOnuHf lIXpSGuMFqSu2AR/s9HcQispY30z6mEs0L41KAGtea9wZA0hiM9c/pmgAQSZ5niMtMx68pyku7j TCVfW8digsk/fO7UOdhK6eOSWBeLMsQ2W4pohcC1bomNYz1imWQN6ZKWCtZYrPX+Lb6jrc0dkV5 M7BGjg2jYRENxMhNyc81dLYHSbZ8VL5rtr0FYI73NW1iO6U/gytB6Rk5N5cuDcyqL/BLaMZvwN0 9/PQVdSJ X-Received: by 2002:a17:907:1c26:b0:ad8:942b:1d53 with SMTP id a640c23a62f3a-ade078951c7mr24903966b.27.1749056225236; Wed, 04 Jun 2025 09:57:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqG4TOAjPvMml/YdZyEoQ+QahksC02aQ5Whxm4dNHjvxJYD+wb6qalU2zcWL3KxMHhCO06XA== X-Received: by 2002:a17:907:1c26:b0:ad8:942b:1d53 with SMTP id a640c23a62f3a-ade078951c7mr24899166b.27.1749056224800; Wed, 04 Jun 2025 09:57:04 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad6ab8esm1110204166b.185.2025.06.04.09.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 09:57:04 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 59CA91AA9166; Wed, 04 Jun 2025 18:57:03 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Subject: Re: [RFC v4 14/18] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() In-Reply-To: <20250604025246.61616-15-byungchul@sk.com> References: <20250604025246.61616-1-byungchul@sk.com> <20250604025246.61616-15-byungchul@sk.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 04 Jun 2025 18:57:03 +0200 Message-ID: <87jz5rv40w.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hq1xAKwBNErjWcEyH6WjwIEZ1iGkyMwiDxIl6ua97KA_1749056225 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 52DE41C0006 X-Stat-Signature: qrdsox1uhos8da4p3ffkm5f478mfbpk1 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749056228-953886 X-HE-Meta: U2FsdGVkX188LkHZC8A9/dTYnZVWnuh3Sa2K7iHqTMpD+y+J/1Bl9ex0J6snPc9FNXTT3pBjKFsjuhUf9H1Un+vgJYMSlfl/rEo2NjVCYOx9BKtOpPNZZ5t3GIXDgPgPRSOAzK+xalbldHiEWETWB+21ZmGXODVOIpiMNfg+rRUrCokjc1I7JD7D6dsioL8rayrL/pUCnif7Z55TtMU9w0V3fhDJTEMupyRJO6HkWMipmMmq+mWh0+LTUsO1WXV4dxlcM17ptGwbngVaJFd0jIJ/Ce6++Mbdy2fsLoN634lSXxRseGxzouqqnSFpNX4y26ho09JYhZt2apgKxwBsj42oW1n7RG27hosYcnBAL3Ox+mGjrlUQIsgCbT5VwoK4UutbolMvy+8sYx/O+7vLoOZ2/atP44dyjfXgaJaP3fkHQ8RkCjJ6H/FiwrHz/xvvBhvV6hkbqnri6tvZtRHhpLXDl5fB7NZ9GUtNm/c+EN54WL6GJ/CWIi4lF3Vz8VcI/SQcAIucG1nC29+no3TX9arJLTVEzENr7RRpWqqOZioqmRq6ffBCmtizqVn7wIQwYpZucpuZmt3LAw1Hgh0XQHpuL3xzjNnulaaYAd8kChL1+Zj2qldnBlPmM3HKGuEiRNmpF9UGyOEje9ts4lbcVYLI/p1QukrM6by1WacIQkKaceRo0op5WoMhoBLJ3ZG+97yFIbXe1F7+R60Gt8WQ1AQXDzd7eqdin7m+uFejyDjgJ9LiBqqB3cA4pLjS5YJD13JAdtEUWYu0qeD6qqu/34w/Q0++K5ysG0qUsZ/D/Uv5lIX22G6T44SeK5B+Aps7qZckYINEoDAoH4No+KXts/PlEJVVJOoPJhO075cHjeh0pyM1+MIExSXF075tU/sVowwp3wuQXSqL93zZgAhJ6qPTj3cBQjFShrmjg2KBRwEWmMUSddUod09YUMM5i7maFm+hdDbNwGfW9SrsQJN HFRbHQ2O Wug7SY1bQ6lU0mk/uxvAZIWOQKu/YHi8jJlaz9qFLOQjfpeu8Pplkq9jjFvRAwM8Ivd7zzRoc3Z8T6JUFRHbBkkmeMOV99y2YXECcWPBwOyK977Bi2kitC3PMjxp7LoncG8QB5IPH4USDNk7nbEVfDuru82U5i+BSKEDft+KxMP43WeiFhtRcH1hvfYafha9z3yQvBeq2JK2LlSFPvZJTg3pB28F9Cbb5q3tMfm4SA0GuFeF/mRZZ+7dtOQqMGfHu+UuNC9WeJYyFeu54rnlTA0SRQj4wuzKbgR9OTStU0U/rmGdAJ920BdgW843BxBnjKOWlExWbwI3a+wJ6Nar7AOyQIDieUlhcUikFSCMqwLG5Q9uKVP+uub1kn4phpf4dFww+JSS2OxOcmLpKJtH5PZhYG1GrFc7YfZNUTFsCJijUBpfK65XM+VfdMRvHrcb+/9TKpCNaDwgRCGbPS9p2CvzU0H+NIe90zWO+8EytyCZpVM18td6og9a/XeSPyHRn3oV07L/6z7iLd+vT/kjx+zfWbwc9m3aRBvoj41wvx3jR+GISNRTWLRmLowd7r4cVvURlBPUc9BVA0+Z/78Z+id8V88JOwXXSimwVgAoDUYgXFczx7XxKBIfCeldxX3SJLaMlkxgszuzKsa2G0Q+dTCivOcDpFUI8ZR4xyQrWUO4bSMowRxi1voIxfQ+EWqyCbs2y/zCCXUIxHPpI/3t0u0ZJ3EOlAG8VJoTdy3WyAX994utsRSJN322kH4+gofNxZGo2vv22os88lAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Byungchul Park writes: > The page pool members in struct page cannot be removed unless it's not > allowed to access any of them via struct page. > > Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but > just wrap page_pool_get_dma_addr_netmem() safely. > > Signed-off-by: Byungchul Park > Reviewed-by: Mina Almasry > Reviewed-by: Ilias Apalodimas Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen