From: Michael Ellerman <mpe@ellerman.id.au>
To: Dave Hansen <dave.hansen@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
zwisler@kernel.org, vishal.l.verma@intel.com,
thomas.lendacky@amd.com,
Andrew Morton <akpm@linux-foundation.org>,
mhocko@suse.com, linux-nvdimm@lists.01.org, linux-mm@kvack.org,
Huang Ying <ying.huang@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Jerome Glisse <jglisse@redhat.com>
Subject: Re: [PATCH 2/5] mm/resource: move HMM pr_debug() deeper into resource code
Date: Tue, 29 Jan 2019 12:34:50 +1100 [thread overview]
Message-ID: <87imy8s0ud.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <b191ad4a-da4e-9bc7-4468-d6e4a8b3d66f@intel.com>
Dave Hansen <dave.hansen@intel.com> writes:
> On 1/25/19 1:18 PM, Bjorn Helgaas wrote:
>> On Thu, Jan 24, 2019 at 5:21 PM Dave Hansen <dave.hansen@linux.intel.com> wrote:
>>> diff -puN kernel/resource.c~move-request_region-check kernel/resource.c
>>> --- a/kernel/resource.c~move-request_region-check 2019-01-24 15:13:14.453199539 -0800
>>> +++ b/kernel/resource.c 2019-01-24 15:13:14.458199539 -0800
>>> @@ -1123,6 +1123,16 @@ struct resource * __request_region(struc
>>> conflict = __request_resource(parent, res);
>>> if (!conflict)
>>> break;
>>> + /*
>>> + * mm/hmm.c reserves physical addresses which then
>>> + * become unavailable to other users. Conflicts are
>>> + * not expected. Be verbose if one is encountered.
>>> + */
>>> + if (conflict->desc == IORES_DESC_DEVICE_PRIVATE_MEMORY) {
>>> + pr_debug("Resource conflict with unaddressable "
>>> + "device memory at %#010llx !\n",
>>> + (unsigned long long)start);
>>
>> I don't object to the change, but are you really OK with this being a
>> pr_debug() message that is only emitted when enabled via either the
>> dynamic debug mechanism or DEBUG being defined? From the comments, it
>> seems more like a KERN_INFO sort of message.
>
> I left it consistent with the original message that was in the code.
> I'm happy to change it, though, if the consumers of it (Jerome,
> basically) want something different.
At least using pr_debug() doesn't match the comment, ie. the comment
says "Be verbose" but pr_debug() is silent by default.
cheers
next prev parent reply other threads:[~2019-01-29 1:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 23:14 [PATCH 0/5] [v4] Allow persistent memory to be used like normal RAM Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` [PATCH 1/5] mm/resource: return real error codes from walk failures Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-25 21:02 ` Bjorn Helgaas
2019-01-25 21:02 ` Bjorn Helgaas
2019-01-25 21:09 ` Dave Hansen
2019-01-25 21:19 ` Bjorn Helgaas
2019-01-25 21:19 ` Bjorn Helgaas
2019-01-29 1:18 ` Michael Ellerman
2019-01-24 23:14 ` [PATCH 2/5] mm/resource: move HMM pr_debug() deeper into resource code Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-25 19:07 ` Jerome Glisse
2019-01-25 21:18 ` Bjorn Helgaas
2019-01-25 21:18 ` Bjorn Helgaas
2019-01-25 21:24 ` Dave Hansen
2019-01-29 1:34 ` Michael Ellerman [this message]
2019-01-24 23:14 ` [PATCH 3/5] mm/memory-hotplug: allow memory resources to be children Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` [PATCH 4/5] dax/kmem: let walk_system_ram_range() search child resources Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-24 23:14 ` [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM Dave Hansen
2019-01-24 23:14 ` Dave Hansen
2019-01-25 6:13 ` Jane Chu
2019-01-25 6:27 ` Dan Williams
2019-01-25 6:27 ` Dan Williams
2019-01-25 8:20 ` Du, Fan
2019-01-25 17:18 ` Dan Williams
2019-01-25 18:20 ` Verma, Vishal L
2019-01-25 19:10 ` Jane Chu
2019-01-25 19:15 ` Dan Williams
2019-01-25 19:15 ` Dan Williams
2019-01-25 23:30 ` Jane Chu
2019-01-28 9:25 ` Michal Hocko
2019-01-28 16:34 ` Dan Williams
2019-01-28 16:34 ` Dan Williams
2019-02-09 11:00 ` Brice Goglin
2019-02-11 16:22 ` Dave Hansen
2019-02-12 19:59 ` Brice Goglin
2019-02-13 0:30 ` Dan Williams
2019-02-13 8:12 ` Brice Goglin
2019-02-13 8:24 ` Dan Williams
2019-02-13 8:43 ` Brice Goglin
2019-02-13 13:06 ` Brice Goglin
2019-02-13 16:19 ` Dan Williams
2019-01-25 19:08 ` [PATCH 0/5] [v4] Allow persistent memory to be used " Jerome Glisse
2019-01-28 11:09 ` Balbir Singh
2019-01-28 16:50 ` Dave Hansen
2019-01-28 16:50 ` Dave Hansen
2019-02-25 18:57 [PATCH 0/5] [v5] " Dave Hansen
2019-02-25 18:57 ` [PATCH 2/5] mm/resource: move HMM pr_debug() deeper into resource code Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imy8s0ud.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=thomas.lendacky@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox