From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA318C3B186 for ; Wed, 12 Feb 2020 10:12:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A2EF2082F for ; Wed, 12 Feb 2020 10:12:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=axtens.net header.i=@axtens.net header.b="l9MckMLM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A2EF2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B2DB96B0418; Wed, 12 Feb 2020 05:12:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE806B0419; Wed, 12 Feb 2020 05:12:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CCBB6B041A; Wed, 12 Feb 2020 05:12:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 8502A6B0418 for ; Wed, 12 Feb 2020 05:12:18 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1651B1F1B for ; Wed, 12 Feb 2020 10:12:18 +0000 (UTC) X-FDA: 76481059956.15.crate42_31207ba5ff81a X-HE-Tag: crate42_31207ba5ff81a X-Filterd-Recvd-Size: 5173 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 10:12:17 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id 4so1001728pfz.9 for ; Wed, 12 Feb 2020 02:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=KF/rQa9b+YDdw75c1nDcpos7LuX+EOPNM62K9KllEpE=; b=l9MckMLM6VWO1ur/vOxwH7Ki/VdQKc3ohUWRt7Z+z5CEQdKhRYppYU0suH5JuIRRlW zMhhtPNhmyl6LV8NVVEBOxpA493MJxADljyEKDs7i7DResuH38OdDodI3gJp2XbHbmzF pl4+t+bEOXPrykcn67P2WFq+uELfWizH8f2Yw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=KF/rQa9b+YDdw75c1nDcpos7LuX+EOPNM62K9KllEpE=; b=qQFtLRqoVbskBQy44FL/fSuF8Xshm6ktxlZu70ID9uQAqmYsZLEdeVBbLrz6hnYnRo /T+v1zE+OV0EFOFh+KRQyKKZOcycRNUkVUbFPLNL94jKgaog9WP2/ybx0pVfVAyzEZeX iAf+fdl3i8szd7OyRfvV1d/e1crazre5a11+mfbV7fpT84+ldx1jfFnG1T0SUrTrLMyy n9iOUSaDSnIA/MOOf+lcyHyCatRBWV3u9y+GcahK4lXN6+63qHzVwkQy6r/3IEX0+iQM 7jsdPOKYoR8v989oHSaqFR9I/W5UisZyImop46fJJUUO/cJY8X0qUt/GCIB53AUs+FJe Fayg== X-Gm-Message-State: APjAAAUe4OV6K490J5WpX6ciJq74QLSa4XVmiACd++T1nVD1ysr+sIC8 E+bjVdMDJmiw88UzGXVtciy3DQ== X-Google-Smtp-Source: APXvYqx8As5sCy+kyC1OBVsfxJsYqEDJa2CntdnKeubs3WgKdDjGAI/TLJdKgvADeZfCHkDrxyuXxQ== X-Received: by 2002:a63:d44e:: with SMTP id i14mr7939813pgj.417.1581502336089; Wed, 12 Feb 2020 02:12:16 -0800 (PST) Received: from localhost (2001-44b8-1113-6700-65dc-9b98-63a7-c7a4.static.ipv6.internode.on.net. [2001:44b8:1113:6700:65dc:9b98:63a7:c7a4]) by smtp.gmail.com with ESMTPSA id e7sm190440pfj.114.2020.02.12.02.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 02:12:15 -0800 (PST) From: Daniel Axtens To: Christophe Leroy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com, aneesh.kumar@linux.ibm.com, bsingharora@gmail.com Cc: Michael Ellerman Subject: Re: [PATCH v6 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support In-Reply-To: <224745f3-db66-fe46-1459-d1d41867b4f3@c-s.fr> References: <20200212054724.7708-1-dja@axtens.net> <20200212054724.7708-5-dja@axtens.net> <224745f3-db66-fe46-1459-d1d41867b4f3@c-s.fr> Date: Wed, 12 Feb 2020 21:12:12 +1100 Message-ID: <87imkcru6b.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christophe Leroy writes: > Le 12/02/2020 =C3=A0 06:47, Daniel Axtens a =C3=A9crit=C2=A0: >> diff --git a/arch/powerpc/include/asm/kasan.h b/arch/powerpc/include/asm= /kasan.h >> index fbff9ff9032e..2911fdd3a6a0 100644 >> --- a/arch/powerpc/include/asm/kasan.h >> +++ b/arch/powerpc/include/asm/kasan.h >> @@ -2,6 +2,8 @@ >> #ifndef __ASM_KASAN_H >> #define __ASM_KASAN_H >>=20=20=20 >> +#include >> + >> #ifdef CONFIG_KASAN >> #define _GLOBAL_KASAN(fn) _GLOBAL(__##fn) >> #define _GLOBAL_TOC_KASAN(fn) _GLOBAL_TOC(__##fn) >> @@ -14,29 +16,41 @@ >>=20=20=20 >> #ifndef __ASSEMBLY__ >>=20=20=20 >> -#include >> - >> #define KASAN_SHADOW_SCALE_SHIFT 3 >>=20=20=20 >> #define KASAN_SHADOW_START (KASAN_SHADOW_OFFSET + \ >> (PAGE_OFFSET >> KASAN_SHADOW_SCALE_SHIFT)) >>=20=20=20 >> +#ifdef CONFIG_KASAN_SHADOW_OFFSET >> #define KASAN_SHADOW_OFFSET ASM_CONST(CONFIG_KASAN_SHADOW_OFFSET) >> +#endif >>=20=20=20 >> +#ifdef CONFIG_PPC32 >> #define KASAN_SHADOW_END 0UL >>=20=20=20 >> -#define KASAN_SHADOW_SIZE (KASAN_SHADOW_END - KASAN_SHADOW_START) >> +#ifdef CONFIG_KASAN >> +void kasan_late_init(void); >> +#else >> +static inline void kasan_late_init(void) { } >> +#endif >> + >> +#endif >> + >> +#ifdef CONFIG_PPC_BOOK3S_64 >> +#define KASAN_SHADOW_END (KASAN_SHADOW_OFFSET + \ >> + (RADIX_VMEMMAP_END >> KASAN_SHADOW_SCALE_SHIFT)) >> + >> +static inline void kasan_late_init(void) { } >> +#endif >>=20=20=20 >> #ifdef CONFIG_KASAN >> void kasan_early_init(void); >> void kasan_mmu_init(void); >> void kasan_init(void); >> -void kasan_late_init(void); >> #else >> static inline void kasan_init(void) { } >> static inline void kasan_mmu_init(void) { } >> -static inline void kasan_late_init(void) { } >> #endif > > Why modify all this kasan_late_init() stuff ? > > This function is only called from kasan init_32.c, it is never called by= =20 > PPC64, so you should not need to modify anything at all. I got a compile error for a missing symbol. I'll repro it and attach it. Regards, Daniel > > Christophe