From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85317C48BE5 for ; Wed, 16 Jun 2021 04:39:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9F4A61375 for ; Wed, 16 Jun 2021 04:39:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9F4A61375 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 768716B006E; Wed, 16 Jun 2021 00:39:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73F826B0070; Wed, 16 Jun 2021 00:39:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 593256B0071; Wed, 16 Jun 2021 00:39:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 27F146B006E for ; Wed, 16 Jun 2021 00:39:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B161C181AC9B6 for ; Wed, 16 Jun 2021 04:39:45 +0000 (UTC) X-FDA: 78258333930.06.28DD8D4 Received: from smtprelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by imf17.hostedemail.com (Postfix) with ESMTP id 477EA40002E4 for ; Wed, 16 Jun 2021 04:39:38 +0000 (UTC) Received: from forelay.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 0B446100E7B44 for ; Wed, 16 Jun 2021 04:39:45 +0000 (UTC) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EB747DB5C for ; Wed, 16 Jun 2021 04:39:44 +0000 (UTC) X-FDA: 78258333888.32.A858392 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf28.hostedemail.com (Postfix) with ESMTP id 0B6B52001096 for ; Wed, 16 Jun 2021 04:39:34 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id z3-20020a17090a3983b029016bc232e40bso993742pjb.4 for ; Tue, 15 Jun 2021 21:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=5w3M3t3Z4U9itzhliFyQ9k6bBdvkeu8fXdsAtgl3rqo=; b=BhoZH0Nr3ZHtpXLjF2kiPY7YRdY/6qIXrextonsCRJ2vn3Ezw0B6jrysimae7W7qYW GJT+ozMHK5wtRIoAwyz/ClsSc9N8NjfRoqLmP+nkRlD07lAlZHdxBXpDjiEXhF1kl+MA k7rvWoYBPTW3FwCCoyeB+RXgdsINqgpyon4BM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=5w3M3t3Z4U9itzhliFyQ9k6bBdvkeu8fXdsAtgl3rqo=; b=oECc8HPPkU+ULvgpAyweFqJ8mgpGnnzb3+OBK7xKSKNbtzk+Gx8h57GytxTqtTQAEM JbFXRwT/OvNWS6YwfynuWsEFBvb1jUu5l/GJrtmRCKn9XNB53bjb6Cd/ChUAiFOnopFb TC+TtOtgmqJeI0Et+sTI7+b21K2+SMHjTQBEi1CUU5eTnqy/8G2W/p5WjlkIzdv7k3AV WvtFGMUZDaK1ojVRu0jro9fRqiO5Z+ayzyNolsbDk81EeoQnYIsOIsHP5ckkbuZ0CY5F ctQB2aE8eTU5avkWWMSjWSFtC+RIxt+UYrq5uv/zURkTIx2AkDdJVgUjPzpvYRFLFiLB cPhQ== X-Gm-Message-State: AOAM533la8BG8KIkpsEqVAk6BHxzVOad9aPQqx2y1x7jcDwNztBdlAHd xV++dScb8W09lxj4hApNDUXuKg== X-Google-Smtp-Source: ABdhPJxS52+0zEjYNpTjrkU9yDk9Lb9mREVnKzrzxmFtRrSP1pLKGqx/loFfJeSlNx4FwkYBioRzNg== X-Received: by 2002:a17:90b:1805:: with SMTP id lw5mr2950044pjb.120.1623818383687; Tue, 15 Jun 2021 21:39:43 -0700 (PDT) Received: from localhost ([203.206.29.204]) by smtp.gmail.com with ESMTPSA id f28sm732424pgb.12.2021.06.15.21.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 21:39:43 -0700 (PDT) From: Daniel Axtens To: Marco Elver Cc: LKML , Linux Memory Management List , linuxppc-dev@lists.ozlabs.org, kasan-dev , Christophe Leroy , aneesh.kumar@linux.ibm.com, Balbir Singh Subject: Re: [PATCH v12 1/6] kasan: allow an architecture to disable inline instrumentation In-Reply-To: References: <20210615014705.2234866-1-dja@axtens.net> <20210615014705.2234866-2-dja@axtens.net> Date: Wed, 16 Jun 2021 14:39:38 +1000 Message-ID: <87im2ev2wl.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain X-HE-Tag: 1623818374-904583 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=axtens.net header.s=google header.b=BhoZH0Nr; spf=softfail (imf17.hostedemail.com: 216.40.44.193 is neither permitted nor denied by domain of dja@axtens.net) smtp.mailfrom=dja@axtens.net; dmarc=none X-Stat-Signature: jcxkgx4c87xc4fjx9kdo3w8dotc369cg X-Rspamd-Queue-Id: 477EA40002E4 X-Rspamd-Server: rspam06 X-HE-Tag: 1623818378-131623 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Marco, @@ -12,6 +12,15 @@ config HAVE_ARCH_KASAN_HW_TAGS >> config HAVE_ARCH_KASAN_VMALLOC >> bool >> >> +# Sometimes an architecture might not be able to support inline instrumentation >> +# but might be able to support outline instrumentation. This option allows an >> +# arch to prevent inline and stack instrumentation from being enabled. > > This comment could be moved into 'help' of this new config option. It could. I did wonder if that made sense given that this is not a user selectable option so I'm not sure if the help will ever be visible, but I see that we do this sort of thing in Kconfig.kcsan and Kconfig.kgdb. I've changed it over. >> +# ppc64 turns on virtual memory late in boot, after calling into generic code >> +# like the device-tree parser, so it uses this in conjuntion with a hook in >> +# outline mode to avoid invalid access early in boot. > > I think the ppc64-related comment isn't necessary and can be moved to > arch/ppc64 somewhere, if there isn't one already. Fair enough. I'll pull it out of this file and look for a good place to put the information in arch/powerpc in a later patch/series. Kind regards, Daniel