From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5467BC54EBE for ; Thu, 12 Jan 2023 19:24:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 488BE8E0002; Thu, 12 Jan 2023 14:24:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 411838E0001; Thu, 12 Jan 2023 14:24:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D8EC8E0002; Thu, 12 Jan 2023 14:24:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1BC588E0001 for ; Thu, 12 Jan 2023 14:24:04 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D8BFC1C5F3C for ; Thu, 12 Jan 2023 19:24:03 +0000 (UTC) X-FDA: 80347122366.08.05ECCEF Received: from mx.cjr.nz (mx.cjr.nz [51.158.111.142]) by imf13.hostedemail.com (Postfix) with ESMTP id 3D62620015 for ; Thu, 12 Jan 2023 19:24:02 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=cjr.nz header.s=dkim header.b=i+65F8jl; spf=pass (imf13.hostedemail.com: domain of pc@cjr.nz designates 51.158.111.142 as permitted sender) smtp.mailfrom=pc@cjr.nz; dmarc=pass (policy=quarantine) header.from=cjr.nz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673551442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I2YK0KStoZilkvt5Gd+Z0QXSKrgiOl1UdETNcSgpEpE=; b=8PtGwgpOCyKHhnpekL9AfkqaZhnyJbmPHHKRxLZCfvC8IRaCKE93wF5BbcNZ3Gey2JEXxB VxrGa77ZLuPG2xH8oXz+1GzPWl06eVtbJnoReW5RfYYLOF+eNEuKekr6Tenl6zsRZYGKUo rfBZI9U4UZ0XvmiSGyp/+t0leObRlbA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=cjr.nz header.s=dkim header.b=i+65F8jl; spf=pass (imf13.hostedemail.com: domain of pc@cjr.nz designates 51.158.111.142 as permitted sender) smtp.mailfrom=pc@cjr.nz; dmarc=pass (policy=quarantine) header.from=cjr.nz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673551442; a=rsa-sha256; cv=none; b=WIW/drkXjeRbEW80X/kFCabbXvo4AXHkr2vSq9ye1h6VBJvyV6taqA3nDUIMlsdlAMTVx7 7qPCO4nbU8mVkeR/s/xq4bevYJEpjgKA3+B2mqb4Qk9oZ6Sv+KVtsaqtl/PjvhR9bsJk0n sMKIK9go6sxXQGs+6EJiCcd3cI/qSi0= Received: from authenticated-user (mx.cjr.nz [51.158.111.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pc) by mx.cjr.nz (Postfix) with ESMTPSA id D0E2A7FCE1; Thu, 12 Jan 2023 19:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjr.nz; s=dkim; t=1673551439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I2YK0KStoZilkvt5Gd+Z0QXSKrgiOl1UdETNcSgpEpE=; b=i+65F8jlt9SrxFye0Gw20zt6UKpTEaqiZQ5hMVqSu0k7iplUUCLaWGe7MPjLIcUXvR2Ze2 EPZvayy3ujt17G7U6k4N9U3mDmbAViZrJRkdIjJ30e2YmzNFL9kFY3KN4OmLssXkKylqmj E8tOKo4JSk3JfhG8aJ26Wc/wDEh7vUicPsX8QXZqm+7WwOK9nS0qxN7D/+flVsxas11Fth oU/iflnYw8+Gm87I9cBkOHMwnYst1u7763QKPIvahJlVCd3cUAf31rG9cwxkdB+Sbii/p1 NDe89irKrvEmsmtdfYfdlUgHuTnNrT2Ps2o/IkqPzfauQjAjCU8/6VVNF8HXCA== From: Paulo Alcantara To: "Vishal Moola (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, "Vishal Moola (Oracle)" Subject: Re: [PATCH v5 09/23] cifs: Convert wdata_alloc_and_fillpages() to use filemap_get_folios_tag() In-Reply-To: <20230104211448.4804-10-vishal.moola@gmail.com> References: <20230104211448.4804-1-vishal.moola@gmail.com> <20230104211448.4804-10-vishal.moola@gmail.com> Date: Thu, 12 Jan 2023 16:23:54 -0300 Message-ID: <87ilhb36b9.fsf@cjr.nz> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3D62620015 X-Rspam-User: X-Stat-Signature: 9xzhp1w9eptxtngmmft9xy9i316qi793 X-HE-Tag: 1673551442-170929 X-HE-Meta: U2FsdGVkX19/EfMwiXMHXsNHu4iKvN5j6DlNDzjXtVC3rv/X//Tatqft+x8FpDiWVdIlP0tbVvm9fJA1CDkhIMdgfcdPYek/EXepKnPCzqwwvmsWKpFQcJysr6H4+0BNWPqZZeVI7c1fIjYn4Qeu1XwcDxFp0xL1TlXaDLkjm6YRwsSW7UO6393pOxrddSRZ/L+1k49rbs9fI4ihjMRMqz3WeotxxKBEYg1R0hWBDJrGGrXZwL+It9J2nfodAO2JviqUZj8cI0po/lhKbRh5TiViykaPSQ2JTY9zEgmoKRiiOI8BVbiKOWWVAp/P/jIH5PhW43ldfnCDjJZ15kmKV3xvoAKfmm8f7iw8MNH6YA4FdG+1zd7PtXkYyalY5s+luQB7lMBG71ygJ0zLlwZfhNwy/VbZnJawuyBmUG4jNBYjdnFgF+SIePo+jTi/8ieLJ4daMXTp1AetsXCaptSx6Sif/dn/M/YTuA0B7CjpmHHsWkU1PQ8L45tXhi7+BAm/7lZHtKVnMpwi2VhM3t4xSWcBPpf9ZDjDYdA2Ym94Eb7AE61p7DUPOReKv3vdDwg0P7hsVnd5QyIe8/1zaijHFS3Zo8aWfWbJprw9TonntNWjSUuJxBGpI98t5NYL0VfzVySNiaK/GcyK6yblQQtuGBXgvBZNt1LwMtmB//FjS4z/XUBld581sXU1hMzjr8NvQqdh+Ef2J7ox41vOnBaDnd2fSgRRTstzDK2JCd5cJd/0tAqzNrOGHEWP01IewPjl8pj3QLg+2+jkAKQcaJL450RJTDfuq42sSb1Masx6OhXQSsKv7Gqk+F99G1uS3aqyNDRNhlOkhIS3/IIEUlR3UT3eCK8OpGFUDvIkeQduIerbQD1qYUaEiD++4sOYlk9PAtXtB8wVo6A54KFGvyczAmdYrO/y/SwKe2caF/BsLfDzhT5kIkbk6M0ItFyUezeSwq/hoyTl98U40YNVYAa pnoRw9FS maRc6E8y/rXTQWj2ng39egU0evMlPe7xWBN42GH/hP3pQhHk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.008981, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Vishal Moola (Oracle)" writes: > This is in preparation for the removal of find_get_pages_range_tag(). Now also > supports the use of large folios. > > Since tofind might be larger than the max number of folios in a > folio_batch (15), we loop through filling in wdata->pages pulling more > batches until we either reach tofind pages or run out of folios. > > This function may not return all pages in the last found folio before > tofind pages are reached. > > Signed-off-by: Vishal Moola (Oracle) > --- > fs/cifs/file.c | 32 +++++++++++++++++++++++++++++--- > 1 file changed, 29 insertions(+), 3 deletions(-) Looks good. Acked-by: Paulo Alcantara (SUSE)