From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A44E8C7EE24 for ; Tue, 16 May 2023 10:17:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A85A28000A; Tue, 16 May 2023 06:17:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20A8B280001; Tue, 16 May 2023 06:17:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ABC228000A; Tue, 16 May 2023 06:17:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EB269280001 for ; Tue, 16 May 2023 06:17:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BEDD51401B9 for ; Tue, 16 May 2023 10:17:36 +0000 (UTC) X-FDA: 80795716512.01.24F4FBF Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf30.hostedemail.com (Postfix) with ESMTP id 833E480013 for ; Tue, 16 May 2023 10:17:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=softfail (imf30.hostedemail.com: 148.163.158.5 is neither permitted nor denied by domain of jjs.tarun@gmail.com) smtp.mailfrom=jjs.tarun@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684232253; a=rsa-sha256; cv=none; b=K6bCeXmTLZ5ZVGwc9r61X6ph03npUODSS1PirSoiO/Rn1bJFtHyqMPK1svR21wVyXGejL6 e3qQrTUj+/j6Q8bbrbcgGFjEuOrLwM7KPeGVw+bM8VK70FgMpgRo0k+2xUw/TSzGU4fmu2 r50pG5F2KZzZ0Wj+wOkDfFJn6dbtiIk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=softfail (imf30.hostedemail.com: 148.163.158.5 is neither permitted nor denied by domain of jjs.tarun@gmail.com) smtp.mailfrom=jjs.tarun@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684232253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p1bz8mGYrWHAbMdMSplQwSH6zZJKsWVx3F4VsXzqKgg=; b=5N5qxT2bCXlr7YdayE9n9hs5HT8A7Tiiw1pSk74ZPJeFoNW6uMny3HAvtMV3q5NSOD+jOi LbfQJOsbkfYAWKqXbDwUA4VXf+d4rNpoOU5njUJQD0kBveVKpIPPmA1/dwVYaYb7/hgzbH zhBld2EtCJi1R/fuVbAhrqJv8csnIVo= Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34GAEZjm015805; Tue, 16 May 2023 10:17:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qm7kngp2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 May 2023 10:17:29 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 34GAFbfh018353; Tue, 16 May 2023 10:17:28 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qm7kngp1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 May 2023 10:17:28 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34G5UiLi005778; Tue, 16 May 2023 10:17:27 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3qj264sjd3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 May 2023 10:17:26 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34GAHO3o38732252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 May 2023 10:17:24 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 945DA2006A; Tue, 16 May 2023 10:17:24 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EC9BC20067; Tue, 16 May 2023 10:17:22 +0000 (GMT) Received: from tarunpc (unknown [9.199.157.25]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 16 May 2023 10:17:22 +0000 (GMT) From: Tarun Sahu To: Yuwei Guan , rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yuwei Guan , aneesh.kumar@linux.ibm.com Subject: Re: [PATCH] memblock: Add flags and nid info in memblock debugfs In-Reply-To: <20230516020645.160-1-ssawgyw@gmail.com> References: <20230516020645.160-1-ssawgyw@gmail.com> Date: Tue, 16 May 2023 15:47:20 +0530 Message-ID: <87ilcsr367.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: nIWvXz9dR5epq57_e9VXgjA0BjCEgX89 X-Proofpoint-GUID: FAlfHxlzAjqnYoKJk5QwReglLVqG9-5a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-16_04,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 clxscore=1034 phishscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0 mlxlogscore=759 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305160085 X-Rspam-User: X-Stat-Signature: pps36bxwoc1ufsqznmaa7um84tzbd3sp X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 833E480013 X-HE-Tag: 1684232253-407592 X-HE-Meta: U2FsdGVkX184ZBsLZ6tIP8MQhQsDYxc20MZsE1811e8pyKlPMgcAslmvhYAAN7+iIGUOl7RnD5YIQiGT6qfn0dQ2rq1teymgYmy0+tXeQfM3mKuZWxsUTSHE0oIBhp3/tj4mrQ9+0gipLx2HjeQZyuYY9RDYlqlGu0/k3CG7k40E/oT+UQQWNGmCPRmfTnSBc01kZOaj5H0sjJLh1tkCnzKHfTmkK5F0Be98SgaoZvzEeY2UaYmn0/DiJQjk7kUUBOs/ZH46aVD0JGFIcebhT3Tj3mfhbq2nQexV3wEGvhfMDYrjoc0XbaDAvVt1ov03LDWN5Q3JuVo9g+WzFTJyVzjUY2EhJIj+Cn6YjGqDKxTtII//jfbEhio2odai5hWgXAh42Wp1+9zy97tm0T2F4yKZtj+UnMwHQewWIAOpl9EPYXbGl5DkUPdJksV1z48YAxzB9r1AKLTJjhJgl23b6j6+7mzdFrAS0WOeBbG1qlDfwr+uU4NmEQjRihPmI9TRKUj9knmVIdltWIMVZ9DlRdCqR/IQ/foTIPIpyjSXbrmePYOFxwb+xWke0BfOOHKE3PZgv0fD0K4s8ZwIA0/10D0r9vJ8e4aBfcEucPLMQDy3ibqE41FedTHaiS80192aW+hQTfZrMGDnFuEGWuCtPbK5B/IzMkfxbxCoS7zMHm/yjcs+IdUGsr1LFl6zNiNadZ+eSGP109Fu91xT0FT7W6zEcmcQavkKwgagtbflFIf8/ckma10qEJ+wboUkFGQD37Vhy57W86LnBOgqiuPbxDIdfpEHo88vnEZ7K0ZFMlWmAZfcTuKyhF9S5yZStolHMGBG7NWxSZSfhhU+Ry7Cj+Y1kXC0LDMFV7gt/wb7KX7l7e1R2NBNe3j7HzDz3JInKUegpKT+xi3qSlFSxFrJJEd98y01ry7J/kIzNg/7cCDdvlHKoZBD9OAJiHNWGbBBuaSF7AnRfl3kCyXq5ho w7UxLnW8 7GWnIwa+tEb4IeBEfWgL61kptDqK1kBOCB0Lz65/CCzN5dW9W44WUXVdc9HYS5HII1Hxk9cgu6thdz/LfRru8aAHq59wxugMB3nTbSFPXXOaStLhUMlg6Y/Nk5tiD8XFo3PpsYb/m9LIa1/EaggmTo9brtbejy9PjYC6WkL43BMgqclqyqMHdjjUZ1OR4sThf2eIVYmJp46Smw00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Guan, Looks good to me, I tested it on my system. Feel free to add Reviewed-by: Tarun Sahu Yuwei Guan writes: > Currently, the memblock debugfs can display the count of memblock_type and > the base and end of the reg. However, when the following scenario occurs, > the information in the existing debugfs cannot make it clear why the > address is not consecutive. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff > 1: 0x0000000090200000..0x00000000905fffff > 2: 0x0000000090600000..0x0000000092ffffff > 3: 0x0000000093000000..0x00000000973fffff > 4: 0x0000000097400000..0x00000000b71fffff > 5: 0x00000000c0000000..0x00000000dfffffff > 6: 0x00000000e2500000..0x00000000f87fffff > 7: 0x00000000f8800000..0x00000000fa7fffff > 8: 0x00000000fa800000..0x00000000fd3effff > 9: 0x00000000fd3f0000..0x00000000fd3fefff > 10: 0x00000000fd3ff000..0x00000000fd7fffff > 11: 0x00000000fd800000..0x00000000fd901fff > 12: 0x00000000fd902000..0x00000000fd909fff > 13: 0x00000000fd90a000..0x00000000fd90bfff > 14: 0x00000000fd90c000..0x00000000ffffffff > 15: 0x0000000880000000..0x0000000affffffff > > So we can add flags and nid to this debugfs. > > For example, > cat /sys/kernel/debug/memblock/memory > cnt flags base..end > 0: 0x0 0x0000000080000000..0x00000000901fffff > 1: 0x4 0x0000000090200000..0x00000000905fffff > 2: 0x0 0x0000000090600000..0x0000000092ffffff > 3: 0x4 0x0000000093000000..0x00000000973fffff > 4: 0x0 0x0000000097400000..0x00000000b71fffff > 5: 0x0 0x00000000c0000000..0x00000000dfffffff > 6: 0x0 0x00000000e2500000..0x00000000f87fffff > 7: 0x4 0x00000000f8800000..0x00000000fa7fffff > 8: 0x0 0x00000000fa800000..0x00000000fd3effff > 9: 0x4 0x00000000fd3f0000..0x00000000fd3fefff > 10: 0x0 0x00000000fd3ff000..0x00000000fd7fffff > 11: 0x4 0x00000000fd800000..0x00000000fd901fff > 12: 0x0 0x00000000fd902000..0x00000000fd909fff > 13: 0x4 0x00000000fd90a000..0x00000000fd90bfff > 14: 0x0 0x00000000fd90c000..0x00000000ffffffff > 15: 0x0 0x0000000880000000..0x0000000affffffff > > Signed-off-by: Yuwei Guan > --- > mm/memblock.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 45f198750be9..34230b258e21 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2045,11 +2045,21 @@ static int memblock_debug_show(struct seq_file *m, void *private) > int i; > phys_addr_t end; > > +#ifdef CONFIG_NUMA > + seq_puts(m, "cnt\tflags\tnid\tbase..end\n"); > +#else > + seq_puts(m, "cnt\tflags\tbase..end\n"); > +#endif > + > for (i = 0; i < type->cnt; i++) { > reg = &type->regions[i]; > end = reg->base + reg->size - 1; > > - seq_printf(m, "%4d: ", i); > + seq_printf(m, "%d:\t", i); > + seq_printf(m, "0x%x\t", reg->flags); > +#ifdef CONFIG_NUMA > + seq_printf(m, "0x%x\t", reg->nid); > +#endif > seq_printf(m, "%pa..%pa\n", ®->base, &end); > } > return 0; > -- > 2.34.1