From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8DCC0015E for ; Wed, 9 Aug 2023 08:41:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48A316B0071; Wed, 9 Aug 2023 04:41:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43BA48E0001; Wed, 9 Aug 2023 04:41:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D94C6B0075; Wed, 9 Aug 2023 04:41:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1E14E6B0071 for ; Wed, 9 Aug 2023 04:41:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E244780853 for ; Wed, 9 Aug 2023 08:41:15 +0000 (UTC) X-FDA: 81103921710.07.33A99EC Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by imf11.hostedemail.com (Postfix) with ESMTP id BC1E340004 for ; Wed, 9 Aug 2023 08:41:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691570474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gqexseAy8x9XfBgwRk35PK/BfcqKAg2w45FhtDl/m1c=; b=kLWMbuKD4Ot/4Z/38uyllvo5HwlQ2XRewSYAgUD0kstNqInXNaHO1OwvvuKZhbDqrzG1ye 1Ldl12Bs4qNzyZ7x5dyshEhUflT3BSVN5q7PPfu8lJKf6eXlyxoWDOFkwPliYcEfUjWOEW VldmQ3T1CVfFTcgYFcO/xnedg45H7uU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691570474; a=rsa-sha256; cv=none; b=uyXIhv5f8hgY3kV5JNvhYaLBMiexCKV00N8oBgSY90CeSjLtfAnTPs1oKHw8CwthgBA33j d/6OskdryU/upgj50+NL3QlJktHybnX2IRh8J9cdkzXqxLDOW9aBmj6sa384Auc45kzHp4 8apuMnnA0t16TPExvdczmwX+cfpIE/c= Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 2BF732055FA1; Wed, 9 Aug 2023 17:41:12 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 3798fAMk208573 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 17:41:11 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 3798fAiA140744 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 17:41:10 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 3798f9uW140743; Wed, 9 Aug 2023 17:41:09 +0900 From: OGAWA Hirofumi To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp In-Reply-To: <87msz08vc7.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of "Wed, 09 Aug 2023 17:37:44 +0900") References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> <87msz08vc7.fsf@mail.parknet.co.jp> Date: Wed, 09 Aug 2023 17:41:09 +0900 Message-ID: <87il9o8v6i.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BC1E340004 X-Stat-Signature: 19woa5pi1ofz6a54kknru1s4nuy4xo9s X-Rspam-User: X-HE-Tag: 1691570473-661078 X-HE-Meta: U2FsdGVkX1+dZzv01QMC2z3fuxr/uXxQ/3rC6fHXDwhSjNDYmOWA2Ty5iVdTPzdX5uyxEVgPK07vd4goWrDU4Z+/tG3xRWRbxuxCSaj3cleEVWuO7XOuo+n6oN3gLP25QOsGSHkNZGigliubUMyBdHdZfJj4+vAVsYiMW99//v6IovzZ1NxtPvpAzVHNnMrk9qeWWhoTXOy2dEM5bceC6mCbTO/89hj18f8/C7KgWqsZFki91UJ0ueAsyiEtulWwXl7sBNnpwk3lae3Bm68a+QIpOJGps/M0U+qz9hBFC0+WuHrJ12iVeZV6bsuJlCm1xrapCmh5KoHKts0eY3FmzwOzNV5dL4/MgsCTH0kufriQRLJ8pJffttG8mYMFR3/RBtaPaY9NzXoygVYWsjEmqSkbdzfhcEQBTWa6M8eX72io6jSGAVh3H0akMWRlrjZIsacCCRm1FCXWNkgzU4VkUTHeU6qtaeXQSC4Q4hjup9+MSiZN1/SR7s3cxs8vVritngYwrcCKmiYWO9OGMQGPbXqEVNHFE/Bik/XGl/Ov6U42ppjHO3ihoWRDQqDv9O5Xsq0hIWhvIvW1Wo05eJAnhI3WqU9rgfz0A5Fwpfoc2SuAdHIwWtXeMVqkOHgvuNa/6rpRcn2pNh0XYgyuXMByKW3F+f14AD0uV93O+DbLbJkQNKwWJC6Q8MMvU60lspXjUmhlSgtRcYiCi89aOvDloo+NyYeupHNDB32AKD0sO9CQkAOkQbC9k3VKh1nQh2c2J3y67F64yQdkGPc/b13wa/Yf2a42voqg+qxS+OXf9cx9sXcMZpvDns3dRXXxyvOBwds1wY/WABkBskavzSoYkvNP+pdbLJXSMtc/7hnmqw5ZuKE0MCqf93uuwrgxJD9QyPKPjCRXIgono64b29VTNppHUTcFmbG3E9xrowrK46WoRAtDAZ+BzmpZjYN0qWSMh1UBo/OOjooQ/dntSWT BBHejm8d lTc8PUt3XhOHoxlzj3WrlSl+qNuBOvwh1yxHUSQk96nr0the6x0fAENTuZI2N7pIGDqs+UpZb2EC50JVT9oKDQKayuYdbELhpaO20KYCbAvKXxuOPLCLZv9qPECE2lYOw8hBGZRVCD1RpP7ijn9uoZcSOfUi0Znx0n3ZnfJTNX25zSToR5CRWlEHugir4RzV8c37qRWBwiOxjkRQaROrQj3UGvIvLPM2deW7vmEmuHqs5w6Y3nt2tavchSvDDC5M6j2ozhEY2q/yXRaqxGI+olvyExG78jVNW+CrR0I3VPFQVFJOY5RYQvlzAbaJlQnXoRHdsd8g4IgU5+6MV2fdH4QFBG4X+EIlNHfL+lI0lFBWP9WZ4SghdMdn3gCPEr1gP/odK7WpBgpHC9obEM/68SuawEG7PMsSy7d+J/NJVStou0LI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: OGAWA Hirofumi writes: > Jeff Layton writes: > >> Also, it may be that things have changed by the time we get to calling >> fat_update_time after checking inode_needs_update_time. Ensure that we >> attempt the i_version bump if any of the S_* flags besides S_ATIME are >> set. > > I'm not sure what it meaning though, this is from > generic_update_time(). Are you going to change generic_update_time() > too? If so, it doesn't break lazytime feature? > > Thanks. BTW, fat is not implementing lazytime now, but it is for future. -- OGAWA Hirofumi